Nora 07ea7ca1d6 fix(sp38): restore per-kind control_number in find_ack_orphans + review cleanups ...

Three pr-reviewer followups from the 2026-07-07 review of commit ad14b56:

1. BUG: find_ack_orphans refactor routed 277ca/ta1 through
   _ack_control_number which only knew 999 — restored per-kind source
   (999 reads raw_json.envelope.control_number, 277ca/ta1 read the ORM
   control_number column). Added regression test pinning all three
   kinds.

2. DOCSTRING DRIFT: reconcile_orphan_st02s said 'remaining columns
   take their defaults' but explicitly passes parsed_at and
   transaction_set_control_number — added both to the explicit list
   and clarified the rest take schema defaults.

3. WASTED SORT: _iter_orphan_999_st02s yielded sorted() but the
   caller re-sorts by (-ack_count, st02) — yielding unsorted now.

Plus three cleanups the reviewer flagged:

* Hoisted 'json' / 'uuid' / 'datetime' imports to module top of
  store/__init__.py (replaced in-method imports).
* Added two missing tests: sentinel grep-discoverability via
  LIKE '<synthetic:%>' + 999-walk tolerance for non-dict raw_json
  (None / list shapes — bytes is unreachable through the ORM).
* Aligned spec/plan exit codes to the cyclone-cli convention
  (exit 1 on DB error, not 2 — matches the existing CLI
  sys.exit(1) and the cyclone-cli skill documentation).

36/36 SP38 tests pass.

2026-07-07 13:11:29 -06:00

..

fixtures

feat(sp37): cyclone.submission.submit_file helper

2026-07-07 10:50:48 -06:00

conftest.py

feat(sp32): _content_keys_match prefers typed NPI columns over raw_json fallback

2026-07-02 17:08:09 -06:00

test_999_rejected_state.py

feat(sp6): wire 999 ingest → claim rejected state

2026-06-20 18:29:28 -06:00

test_ack_endpoints_authenticated.py

fix(permissions): expose GET /api/acks, /api/ta1-acks, /api/277ca-acks

2026-06-24 17:51:44 -06:00

test_ack_id_helpers.py

feat(sp27): create handlers/ package skeleton + dedup ack ID helpers

2026-06-29 10:09:10 -06:00

test_ack_orphan_summary.py

fix(sp38): restore per-kind control_number in find_ack_orphans + review cleanups

2026-07-07 13:11:29 -06:00

test_ack_orphans_cli.py

feat(sp38): 'cyclone ack-orphans {status,reconcile}' CLI subcommands

2026-07-07 12:53:51 -06:00

test_acks.py

fix(sp37): sync head-assertion + update batch_envelope_index docstrings

2026-07-07 10:34:46 -06:00

test_api_277ca.py

feat(sp35): regression locks on parse-999/277ca/ta1 envelope guards

2026-07-06 09:53:53 -06:00

test_api_835.py

feat(sp35): /api/parse-835 envelope + empty-claims guards

2026-07-06 09:52:51 -06:00

test_api_999.py

feat(sp35): regression locks on parse-999/277ca/ta1 envelope guards

2026-07-06 09:53:53 -06:00

test_api_ack_stream.py

feat(sp25): /api/acks/stream + /api/ta1-acks/stream NDJSON endpoints

2026-07-02 09:00:54 -06:00

test_api_audit_log.py

feat(sp11): tamper-evident hash-chained audit_log

2026-06-20 23:45:43 -06:00

test_api_backup.py

feat(sp17): encrypted DB backup automation

2026-06-21 09:43:51 -06:00

test_api_batch_export_837.py

feat(release): v0.2.0 — batch 837 export, ClaimCard, theme tokens

2026-06-22 11:01:58 -06:00

test_api_claim_acks.py

fix(sp28): align Batch.kind filter with prod ('837p' not '837')

2026-07-02 12:22:29 -06:00

test_api_claim_detail.py

feat(sp7): claim detail includes lineReconciliation slim projection

2026-06-20 19:37:38 -06:00

test_api_clearhouse_patch.py

fix(sftp): swap inbound/outbound paths — FromHPE is inbound, ToHPE is outbound

2026-06-24 22:05:55 -06:00

test_api_dedup.py

feat(sp27): dedup ack ID helpers — one copy in handlers/_ack_id.py

2026-06-29 11:00:37 -06:00

test_api_eligibility.py

feat(parsers+api): 270/271 eligibility request + response (SP3 P4)

2026-06-20 08:22:31 -06:00

test_api_gets.py

feat(sp30): Dashboard Recent batches widget with billing outcome

2026-07-02 14:18:55 -06:00

test_api_line_reconciliation.py

feat(sp7): GET /api/claims/{id}/line-reconciliation endpoint

2026-06-20 19:35:17 -06:00

test_api_parse_includes_batch_id.py

feat(release): v0.2.0 — batch 837 export, ClaimCard, theme tokens

2026-06-22 11:01:58 -06:00

test_api_parse_persists_ack.py

feat(parsers+api+ui+db): 999 ACK transaction set end-to-end (SP3 P3)

2026-06-20 08:03:37 -06:00

test_api_parse_persists.py

feat(ta1): TA1 interchange ACK parser, persistence, and API

2026-06-20 18:58:56 -06:00

test_api_remittances_summary.py

feat(sp27): server-aggregate Remittances KPIs (count, paid, adjustments)

2026-06-29 14:32:10 -06:00

test_api_rotate_key.py

feat(sp36): absorb 20 admin endpoints into api_routers/admin.py

2026-07-06 14:01:37 -06:00

test_api_scheduler.py

fix(sftp): swap inbound/outbound paths — FromHPE is inbound, ToHPE is outbound

2026-06-24 22:05:55 -06:00

test_api_serialize_837.py

feat(sp8): GET /api/claims/{id}/serialize-837 endpoint

2026-06-20 20:34:44 -06:00

test_api_stream_live.py

feat(api): GET /api/{claims,remittances,activity}/stream + unsubscribe

2026-06-20 16:57:30 -06:00

test_api_submit_batch.py

fix(sp37-followup): SubmitOutcome.UNEXPECTED_ERROR for non-typed failures

2026-07-07 12:19:42 -06:00

test_api_ta1.py

feat(sp35): regression locks on parse-999/277ca/ta1 envelope guards

2026-07-06 09:53:53 -06:00

test_api_validate_provider.py

feat(sp20): NPI Luhn checksum + Tax ID (EIN) format validation

2026-06-21 10:46:10 -06:00

test_api.py

feat(sp35): /api/parse-837 envelope + empty-claims guards

2026-07-06 09:51:27 -06:00

test_apply_277ca_rejections.py

feat(sp10): 277CA parser + Payer-Rejected Inbox lane

2026-06-20 23:41:01 -06:00

test_apply_999_rejections.py

feat(sp33): apply_999_rejections uses batch_envelope_index

2026-07-02 21:07:07 -06:00

test_apply_claim_ack_links.py

fix(sp38): restore per-kind control_number in find_ack_orphans + review cleanups

2026-07-07 13:11:29 -06:00

test_audit_log_user_id.py

feat(audit): record user_id on log events

2026-06-22 15:34:18 -06:00

test_audit_log.py

feat(sp11): tamper-evident hash-chained audit_log

2026-06-20 23:45:43 -06:00

test_auth_admin.py

test(auth): add test_existing_endpoints_require_auth + per-test AUTH_DISABLED flips

2026-06-22 15:59:08 -06:00

test_auth_bootstrap_file.py

feat(sp23): auth bootstrap reads CYCLONE_ADMIN_*_FILE for Docker secrets

2026-06-23 17:24:23 -06:00

test_auth_bootstrap.py

feat(auth): bootstrap first admin from env vars

2026-06-22 15:34:05 -06:00

test_auth_login_rate_limit.py

test(auth): add test_existing_endpoints_require_auth + per-test AUTH_DISABLED flips

2026-06-22 15:59:08 -06:00

test_auth_permissions_matrix.py

fix(sp37-followup): remove dead /api/resubmit permissions entry

2026-07-07 12:17:14 -06:00

test_auth_routes.py

test(auth): add test_existing_endpoints_require_auth + per-test AUTH_DISABLED flips

2026-06-22 15:59:08 -06:00

test_auth_sessions.py

test(auth): add test_existing_endpoints_require_auth + per-test AUTH_DISABLED flips

2026-06-22 15:59:08 -06:00

test_auth_users.py

test(auth): add test_existing_endpoints_require_auth + per-test AUTH_DISABLED flips

2026-06-22 15:59:08 -06:00

test_backfill_cli.py

feat(sp32): add backfill-rendering-npi CLI subcommand

2026-07-02 17:16:59 -06:00

test_backup_crypto.py

feat(sp17): encrypted DB backup automation

2026-06-21 09:43:51 -06:00

test_backup_scheduler.py

feat(sp17): encrypted DB backup automation

2026-06-21 09:43:51 -06:00

test_backup_service.py

feat(sp17): encrypted DB backup automation

2026-06-21 09:43:51 -06:00

test_batch_diff.py

feat(batch-diff): side-by-side claim diff between two batches

2026-06-20 17:17:09 -06:00

test_batch_envelope_index_sp37.py

feat(sp37): batch_envelope_index now resolves by ST02 or ISA13

2026-07-07 10:30:23 -06:00

test_batch_txn_set_cn.py

feat(sp37): populate batches.transaction_set_control_number on 837P ingest

2026-07-07 10:22:32 -06:00

test_cas_codes.py

feat(parsers+api+ui): expose CARC-labeled CAS adjustments (SP3 P2)

2026-06-20 07:44:41 -06:00

test_clearhouse_api.py

fix(sftp): swap inbound/outbound paths — FromHPE is inbound, ToHPE is outbound

2026-06-24 22:05:55 -06:00

test_cli_835.py

fix(backend): make 835 summary counts consistent with total_claims

2026-06-19 17:07:54 -06:00

test_cli_backup.py

feat(sp17): encrypted DB backup automation

2026-06-21 09:43:51 -06:00

test_cli_users.py

feat(auth): CLI users subcommand

2026-06-22 15:34:18 -06:00

test_cli_validate.py

feat(sp20): NPI Luhn checksum + Tax ID (EIN) format validation

2026-06-21 10:46:10 -06:00

test_cli.py

feat(backend): click CLI for parse-837

2026-06-19 16:00:47 -06:00

test_co_medicaid_835_fixture.py

feat(backend): 835 ERA parser with BPR/CLP/SVC balancing, CO Medicaid config, CLI, and FastAPI route

2026-06-19 17:01:57 -06:00

test_co_medicaid_fixture.py

feat(sp33): cli resubmit-rejected-claims + fixture/test payer_id refresh

2026-07-02 21:50:23 -06:00

test_co_medicaid_payer_id_emits_CO_TXIX.py

feat(sp33): PayerConfig.co_medicaid() emits CO_TXIX

2026-07-02 20:23:56 -06:00

test_dashboard_kpis.py

feat(sp27): server-aggregate Dashboard KPIs so 100-row sample doesn't lie

2026-06-29 12:51:28 -06:00

test_db_crypto.py

feat(sp15): SQLCipher key rotation via PRAGMA rekey

2026-06-21 00:33:37 -06:00

test_db_migrate.py

feat(sp37): add batches.transaction_set_control_number column

2026-07-07 10:13:00 -06:00

test_db_models.py

refactor(sp31): rename Match strategy 'auto' to 'pcn-exact' for audit clarity

2026-07-02 14:59:49 -06:00

test_db.py

feat(backend): add cyclone.db with engine, SessionLocal, Base, init_db

2026-06-19 21:03:21 -06:00

test_docker.py

test(sp26): assert CYCLONE_SFTP_PASSWORD_FILE + cyclone_sftp_password in compose

2026-06-24 16:09:19 -06:00

test_e2e_999_to_claim_drawer.py

fix(sp28): align Batch.kind filter with prod ('837p' not '837')

2026-07-02 12:22:29 -06:00

test_exceptions.py

feat(backend): add CycloneParseError and CycloneValidationError

2026-06-19 15:31:06 -06:00

test_existing_endpoints_require_auth.py

test(auth): add test_existing_endpoints_require_auth + per-test AUTH_DISABLED flips

2026-06-22 15:59:08 -06:00

test_filenames.py

fix(sftp): case-insensitive inbound regex, skip _warn.txt, add targeted pull

2026-06-24 23:23:46 -06:00

test_handlers_277ca.py

feat(sp27): extract handle_277ca from scheduler.py into handlers/

2026-06-29 10:46:29 -06:00

test_handlers_835.py

feat(sp27): unify 835 ingest + reconciliation in handle_835 (atomic)

2026-06-29 12:08:47 -06:00

test_handlers_999.py

feat(sp25): drop event_bus kwarg from handlers; thread event_bus into parse endpoints

2026-07-02 08:52:20 -06:00

test_handlers_ta1.py

feat(sp27): extract handle_ta1 from scheduler.py into handlers/

2026-06-29 10:38:32 -06:00

test_inbound_filename_loose.py

feat(sp27): loosen INBOUND_RE to accept suffix-less inbound filenames

2026-06-29 11:30:00 -06:00

test_inbox_endpoints_sp7.py

feat(sp7): inbox lanes matched_remittance includes matched/total line counts

2026-06-20 19:43:43 -06:00

test_inbox_endpoints.py

feat(sp10): 277CA parser + Payer-Rejected Inbox lane

2026-06-20 23:41:01 -06:00

test_inbox_lanes.py

feat(sp29): inbox rejected-row 999 ack chips + per-row Resubmit

2026-07-02 13:16:38 -06:00

test_inbox_state.py

feat(sp6): apply_999_rejections state helper

2026-06-20 18:25:25 -06:00

test_iter_claims_received.py

Populate receivedAmount from matched Remittance.total_paid

2026-06-22 17:46:47 -06:00

test_lane_filter_acknowledged.py

feat(sp14): 5-lane Inbox UI with Payer-Rejected acknowledge action

2026-06-21 00:13:47 -06:00

test_line_reconciliation.py

feat(sp7): match_service_lines() pure function + tests

2026-06-20 19:29:21 -06:00

test_list_endpoint_counts.py

fix(sp27): /api/claims + /api/remittances total counts the full population

2026-06-29 13:22:42 -06:00

test_logging_formatter.py

feat(sp18): structured JSON logging + PII scrubber

2026-06-21 09:59:34 -06:00

test_logging_scrubber.py

feat(sp18): structured JSON logging + PII scrubber

2026-06-21 09:59:34 -06:00

test_logging_setup.py

feat(sp18): structured JSON logging + PII scrubber

2026-06-21 09:59:34 -06:00

test_migration_0020_no_drift.py

fix(sp37-followup): load BACKFILL_SQL from migration file (no drift)

2026-07-07 12:21:27 -06:00

test_migration_0020.py

fix(sp37-followup): load BACKFILL_SQL from migration file (no drift)

2026-07-07 12:21:27 -06:00

test_models_270.py

feat(parsers+api): 270/271 eligibility request + response (SP3 P4)

2026-06-20 08:22:31 -06:00

test_models_271.py

feat(parsers+api): 270/271 eligibility request + response (SP3 P4)

2026-06-20 08:22:31 -06:00

test_models_835.py

feat(backend): 835 ERA parser with BPR/CLP/SVC balancing, CO Medicaid config, CLI, and FastAPI route

2026-06-19 17:01:57 -06:00

test_models_999.py

feat(parsers+api+ui+db): 999 ACK transaction set end-to-end (SP3 P3)

2026-06-20 08:03:37 -06:00

test_models.py

feat(backend): Pydantic v2 models for 837P claims

2026-06-19 15:39:08 -06:00

test_npi.py

feat(sp20): NPI Luhn checksum + Tax ID (EIN) format validation

2026-06-21 10:46:10 -06:00

test_parse_270.py

feat(parsers+api): 270/271 eligibility request + response (SP3 P4)

2026-06-20 08:22:31 -06:00

test_parse_271.py

feat(parsers+api): 270/271 eligibility request + response (SP3 P4)

2026-06-20 08:22:31 -06:00

test_parse_277ca.py

feat(sp10): 277CA parser + Payer-Rejected Inbox lane

2026-06-20 23:41:01 -06:00

test_parse_835.py

feat(sp32): extract 835 NM1*1P (service provider NPI) per ClaimPayment

2026-07-02 16:56:01 -06:00

test_parse_837.py

feat(sp33): cli resubmit-rejected-claims + fixture/test payer_id refresh

2026-07-02 21:50:23 -06:00

test_parse_999.py

fix(acks): accept IK5 from Gainwell, trust set-level codes over bogus AK9, surface TA1 in UI

2026-06-25 00:26:13 -06:00

test_parse_ta1.py

feat(ta1): TA1 interchange ACK parser, persistence, and API

2026-06-20 18:58:56 -06:00

test_payer_config_277ca.py

feat(sp10): 277CA parser + Payer-Rejected Inbox lane

2026-06-20 23:41:01 -06:00

test_payer_config_loading.py

feat(sp9): multi-payer, multi-NPI, SFTP stub for dzinesco/TOC

2026-06-20 23:07:31 -06:00

test_payer_rejected_acknowledge.py

feat(sp14): 5-lane Inbox UI with Payer-Rejected acknowledge action

2026-06-21 00:13:47 -06:00

test_payer_summary.py

feat(sp33): cli resubmit-rejected-claims + fixture/test payer_id refresh

2026-07-02 21:50:23 -06:00

test_payer.py

feat(sp33): apply_999_rejections uses batch_envelope_index

2026-07-02 21:07:07 -06:00

test_prodfiles_smoke.py

feat(sp8): outbound 837P serializer — full rebuild + round-trip tests

2026-06-20 20:27:48 -06:00

test_provider_extended_response.py

feat(sp31): expose keys_matched/candidate_count in Match dataclass and ActivityEvent payload, fix broken pre-existing test

2026-07-02 16:23:42 -06:00

test_providers_seed.py

fix(sftp): swap inbound/outbound paths — FromHPE is inbound, ToHPE is outbound

2026-06-24 22:05:55 -06:00

test_pubsub.py

feat(api): GET /api/{claims,remittances,activity}/stream + unsubscribe

2026-06-20 16:57:30 -06:00

test_reconcile_line_level.py

feat(sp7): wire match_service_lines into reconcile.run

2026-06-20 19:33:02 -06:00

test_reconcile.py

feat(sp32): _content_keys_match prefers typed NPI columns over raw_json fallback

2026-07-02 17:08:09 -06:00

test_routes_have_auth_coverage.py

fix(sp37-followup): close auth-coverage gaps and drop dead matrix entries

2026-07-07 12:31:11 -06:00

test_scheduler_reconfigure.py

feat(sp25): scheduler.reconfigure_scheduler() hot-reload helper

2026-06-24 15:36:19 -06:00

test_scheduler_status_errors.py

feat(sp27): surface consecutive_failures + last_error in Scheduler.status()

2026-06-29 11:53:56 -06:00

test_scheduler.py

fix(sftp): case-insensitive inbound regex, skip _warn.txt, add targeted pull

2026-06-24 23:23:46 -06:00

test_scoring.py

feat(sp6): 4-field weighted scoring module

2026-06-20 18:30:05 -06:00

test_secrets_envvar.py

feat(sp25): secrets.get_secret() env-var-first lookup

2026-06-24 15:29:52 -06:00

test_secrets_file.py

feat(sp26): secrets.get_secret() _FILE-tier lookup for Docker secrets

2026-06-24 16:06:54 -06:00

test_secrets.py

feat(sp9): multi-payer, multi-NPI, SFTP stub for dzinesco/TOC

2026-06-20 23:07:31 -06:00

test_security.py

feat(sp19): security hardening + rich health probe

2026-06-21 10:21:01 -06:00

test_segments.py

feat(backend): X12 segment tokenizer with ISA delimiter detection

2026-06-19 15:36:01 -06:00

test_serialize_270.py

feat(parsers+api): 270/271 eligibility request + response (SP3 P4)

2026-06-20 08:22:31 -06:00

test_serialize_837.py

feat(release): v0.2.0 — batch 837 export, ClaimCard, theme tokens

2026-06-22 11:01:58 -06:00

test_serialize_999.py

feat(parsers+api+ui+db): 999 ACK transaction set end-to-end (SP3 P3)

2026-06-20 08:03:37 -06:00

test_service_line_payments.py

feat(sp7): persist ServiceLinePayment + link CAS rows on 835 ingest

2026-06-20 19:27:24 -06:00

test_sftp_client_stat.py

fix(sp37-followup): add SftpClient.stat() method

2026-07-07 12:24:35 -06:00

test_sftp_op_timeout.py

feat(sp27): wrap SFTP list_inbound in asyncio.wait_for with CYCLONE_SFTP_OP_TIMEOUT_SECONDS

2026-06-29 11:43:58 -06:00

test_sftp_paramiko.py

fix(sftp): case-insensitive inbound regex, skip _warn.txt, add targeted pull

2026-06-24 23:23:46 -06:00

test_sftp_stub.py

fix(sftp): swap inbound/outbound paths — FromHPE is inbound, ToHPE is outbound

2026-06-24 22:05:55 -06:00

test_store_acks_publish.py

feat(sp25): add_*_ack publish ack_received / ta1_ack_received / two77ca_ack_received

2026-07-02 08:47:03 -06:00

test_store_claim_detail.py

fix(sp27): Claim.patient_control_number populated from CLM01 (claim_id), not 2010BA NM109 (member_id)

2026-06-29 14:32:10 -06:00

test_store_match_invariant.py

feat(sp27): pin Claim↔Remit matched-pair invariant + startup drift audit

2026-06-29 12:21:34 -06:00

test_store_reconcile.py

fix(sp27): Claim.patient_control_number populated from CLM01 (claim_id), not 2010BA NM109 (member_id)

2026-06-29 14:32:10 -06:00

test_store_ui_acks.py

feat(sp25): move ack UI serializers to store/ui.py

2026-07-02 08:45:19 -06:00

test_store_update_clearhouse.py

fix(sftp): swap inbound/outbound paths — FromHPE is inbound, ToHPE is outbound

2026-06-24 22:05:55 -06:00

test_store.py

fix(835): drop over-constraining UNIQUE constraints, add multi-BPR warning

2026-06-20 18:10:07 -06:00

test_submission.py

fix(sp37-followup): use CliRunner in test_submit_batch_cli_help

2026-07-07 12:17:50 -06:00

test_unexpected_error_outcome.py

fix(sp37-followup): SubmitOutcome.UNEXPECTED_ERROR for non-typed failures

2026-07-07 12:19:42 -06:00

test_validation_r200_r210.py

feat(sp9): multi-payer, multi-NPI, SFTP stub for dzinesco/TOC

2026-06-20 23:07:31 -06:00

test_validator_835.py

feat(backend): 835 ERA parser with BPR/CLP/SVC balancing, CO Medicaid config, CLI, and FastAPI route

2026-06-19 17:01:57 -06:00

test_validator.py

feat(sp20): NPI Luhn checksum + Tax ID (EIN) format validation

2026-06-21 10:46:10 -06:00

test_writer.py

feat(backend): per-claim JSON writer + summary.json

2026-06-19 15:56:09 -06:00