Commit Graph

3 Commits

Author SHA1 Message Date
Tyler d0a12d33da fix(communications): create email_templates table + resolve platform_admin brand fallback
Deploy to route.crispygoat.com / deploy (push) Failing after 3m19s
Two related bugs caused the 'New Template' modal on
/admin/communications to fail with a database error:

1. The `email_templates` table was defined in `db/schema/marketing.ts`
   (Drizzle) but never migrated, so the modal's `upsertTemplate`
   server action errored with 'relation "email_templates" does not
   exist'. Adds migration 0092 to create the table (and `campaigns`)
   to match the Drizzle schema. Uses CREATE TABLE IF NOT EXISTS,
   gen_random_uuid() PKs, and the standard set_updated_at trigger
   pattern from 0001_init.sql.

2. `/admin/communications/page.tsx` resolved `effectiveBrandId`
   with a hard-coded UUID ('64294306-...') for sessions without a
   brand (e.g., dev platform_admin). That UUID isn't in the local
   dev DB (brands are '11111111-...' and '22222222-...'), so the
   modal would FK-violate on insert with 'violates foreign key
   constraint email_templates_brand_id_fkey'. Replaced with a
   `listBrandsForAdmin()` lookup that picks the first accessible
   brand.

3. `listBrandsForAdmin()` (`src/actions/brands.ts`) was SELECTing
   `logo_url` from `brands`, but that column doesn't exist (the
   brands table only has id/name/slug/plan_tier/limits/stripe_*/...).
   The query threw 'column "logo_url" does not exist', got caught
   by the silent try/catch, returned [], which made #2 above render
   the page with brandId="" — and any submit would then error with
   'invalid input syntax for type uuid: ""'. Removed logo_url
   from the SELECT; BrandListItem.logo_url is always null until a
   future migration adds the column.

E2E verified: opening /admin/communications → Templates tab → New
Template → fill name → Create Template inserts a row in
email_templates with the correct brand_id.
2026-06-26 20:43:01 -06:00
tyler b8317a200e migrate: replace Supabase REST with Drizzle/pg in water-log/time-tracking/reports/etc (wave 4) 2026-06-07 03:05:00 +00:00
tyler 63842a9efc feat(admin): multi-brand admin support
Implements the design at
docs/superpowers/specs/2026-06-04-multi-brand-admin-design.md.

Adds:
- admin_user_brands junction table (m:n admin<->brand) via migration 207
- New role 'multi_brand_admin' (auto-set when an admin has 2+ brands)
- 'active_brand_id' cookie that persists the admin's currently-selected
  brand across navigations; switchable via the new BrandSelector dropdown
  in the sidebar
- Centralised brand resolution in src/lib/brand-scope.ts:
  - getActiveBrandId (URL > cookie > legacy brand_id > first of brand_ids)
  - assertBrandAccess (defence-in-depth for cases where the brandId
    comes from a URL form or RPC return)
- ~30 server actions and ~10 page server components migrated to use
  getActiveBrandId instead of the silent brandId ?? adminUser.brand_id
  pattern that allowed cross-brand access bugs
- BrandSelector client component with proper a11y (aria-haspopup,
  aria-expanded, role=listbox, outside-click and escape-to-close)

Migration 207 also adds RLS so admins can read their own junction rows
(needed for the dropdown to populate) and SECURITY DEFINER RPCs
add/remove_admin_user_brand that auto-promote/demote between
brand_admin and multi_brand_admin.

Notes:
- Migration number is 207 not 204 — 204-206 were taken in this worktree
  by the concurrent locations work.
- The legacy admin_users.brand_id column is preserved for backwards
  compat; a follow-up migration 220_* will drop it.
- Dev sessions (dev_session cookie, NEXT_PUBLIC_USE_MOCK_DATA) get
  brand_ids: []; the documented limitation is that dev store_employee
  will see <AdminAccessDenied /> if no real brands exist.
- Pages that hardcode a Tuxedo brand UUID as a fallback
  (adminUser.brand_id ?? '64294306-...') are NOT migrated in this PR —
  they still work for single-brand admins and are out of scope.

Co-authored-by: implementer subagent (cancelled mid-run), Grok orchestrator
2026-06-04 17:09:40 +00:00