fix: react-doctor → 64/100 (Bugs 122, Perf 286, A11y 613, Maint 436)

- CartContext: lazy initializers replace mount-only useEffect
  hydration; remove 8 no-initialize-state warnings
- Toast/AdminSearchInput: React 19 useContext/use + drop
  forwardRef (3 no-react19-deprecated-apis)
- ProductFormModal: lazy initializers + useSyncExternalStore
  for mount; parent adds key=editingProduct.id
- InstallPrompt: useReducer for prompt state (no-cascading-set-state)
- QRScanModal: ref-based latest-callback pattern replaces
  useEffectEvent deps mistake
- OnboardingFlow: functional setState (rerender-functional-setstate)
- UsersPage/StopsCalendar/FeaturesAndStats: lazy initializers
  (rerender-lazy-state-init)
- FAQClientPage: server-side brand settings fetch via getBrandSettingsPublic
  in layout; remove supabase import
- LandingPageWrapper: href='#' → href='#top' (anchor-is-valid)
- TuxedoVideoHero: replace animate-bounce with ease-out-expo
  (no-inline-bounce-easing)
- ProductTableClient: useCallback for handleDeleted
  (jsx-no-new-function-as-prop)
- excel-parser: pre-compile delimiter regexes (js-hoist-regexp)
- water-log/settings: Promise.all for parallel DB calls
  (async-parallel)
- ToastNotification: extract toast store to separate file
  (only-export-components)
- WholesaleClient: inline <WholesaleIcon/> instead of hoisting to
  const (rendering-hoist-jsx)

src/components/admin/AnalyticsDashboard.tsx

@@ -1,7 +1,7 @@
 // Admin Analytics Dashboard - Real metrics and business insights
 "use client";
 
-import { useState, useEffect, useCallback } from "react";
+import { useState, useEffect, useEffectEvent, useCallback } from "react";
 import Link from "next/link";
 import { formatDate } from "@/lib/format-date";
 import { analytics } from "@/lib/analytics";
@@ -396,13 +396,18 @@ export default function AnalyticsDashboard({ brandId }: { brandId?: string }) {
     }
   }, []);
 
+  // useEffectEvent so we always call the latest fetchAllData without
+  // re-running the effect every time the parent re-renders.
+  const fetchAllDataEffect = useEffectEvent(() => {
+    fetchAllData();
+  });
   useEffect(() => {
     analytics.featureUsed("analytics_dashboard", { brand_id: brandId });
     // Wrap in requestAnimationFrame to avoid sync setState
     requestAnimationFrame(() => {
-      fetchAllData();
+      fetchAllDataEffect();
     });
-  }, [brandId, fetchAllData]);
+  }, [brandId]);
 
   if (isLoading) {
     return (