13 Commits

Author SHA1 Message Date
Tyler 3f672d5db3 spec: drop claims UNIQUE constraint + 409 UX 2026-06-21 16:54:07 -06:00
Tyler 65d98cf674 feat(dashboard): Recent activity events route to entity by kind
SP21 Task 2.5 — the Dashboard's 'Recent activity' card now routes clicks
to the matching entity drawer / page by event kind:

  - claim_*       → /claims?claim=<id>  (drawer in Phase 5)
  - provider_added → /providers?provider=<npi>  (ProviderDrawer)
  - remit_received → toast 'coming in a later phase' (RemitDrawer in Phase 4)
  - anything else  → toast (manual_match, unknown kinds)

Implementation:
  - New src/lib/event-routing.ts with the eventKindToUrl() helper,
    plus a unit test covering all 6 + default branches.
  - src/components/ActivityFeed.tsx gains an optional onItemClick
    prop; when set, each row gets role='button', tabIndex=0, the
    drillable hover affordance (chevron + tint), and an Enter/Space
    keybinding. e.stopPropagation() is called before the handler so a
    parent row click can't double-fire (same fix as Task 2.4).
  - src/pages/Dashboard.tsx wires the handler on the 'Recent activity'
    card via eventKindToUrl + sonner toast for unhandled kinds.
  - Backend: CycloneStore.recent_activity() now exposes claimId and
    remittanceId on each row (read from ActivityEvent.claim_id /
    remittance_id) so the routing helper has the entity ids it needs.
  - The frontend Activity interface gains optional claimId /
    remittanceId fields; the in-memory sample data and the
    addClaim store action populate them so the dashboard works in
    both API-configured and sample-data modes.
2026-06-21 16:41:15 -06:00
Tyler d15c04d983 feat(claims): provider cell drillable to /providers?provider=NPI 2026-06-21 16:41:15 -06:00
Tyler 980627b675 feat(providers): directory cards drillable — opens ProviderDrawer 2026-06-21 16:41:15 -06:00
Tyler 1db6b8841c fix(drill): ProviderDrawer quality pass — error branching, demo fallback, flex layout
Quality-fix iteration on 078c9ad. Resolves the 4 Important issues
flagged in the code review while preserving everything that's working.

Issue 1 — ProviderDrawer silently swallowed error states (infinite
skeleton on any failure). Now mirrors ClaimDrawer/RemitDrawer:
  - Destructure { data, isLoading, isError, error, refetch }
  - Compute errorKind = ApiError(404) → not_found, else → network
  - New ProviderDrawerError.tsx renders the right copy + retry/close
  - Body branches on errorKind → loading → data

Issue 2 — useProviderDetail did not match the useClaimDetail contract:
  - 404 retry guard (no retries on 404, <=3 on everything else)
  - Explicit typed return shape { data, isLoading, isError, error,
    refetch }
  - npi === null short-circuit after the useQuery call

Issue 3 — Provider drilldown was non-functional in demo mode. Added
the useSyncExternalStore fallback to useAppStore.providers (same
pattern as useProviders), gated by api.isConfigured. Unknown NPI in
demo mode surfaces via the error branch instead of an infinite
skeleton.

Issue 4 — Test was shape-only (1 case). Rewrote with vi.hoisted +
vi.fn() hook mock and 7 cases covering null/loading/404/network/
close/success/hook-call-shape.

Issue 5 — Replaced h-[calc(100%-64px)] with a flex layout
(flex h-full flex-col on DialogContent, flex h-full flex-col
overflow-y-auto on inner wrappers). Mirrors RemitDrawer's pattern;
no more coupling to DrillDrawerHeader's padding/font sizes.

Issue 7 — Removed the dead npi === null ? null : (...) wrapper
inside DialogContent; Dialog open={npi !== null} already gates it.

Issue 8 — Trailing newlines added across all touched + created files.

Self-review: tsc clean on changed files; drawer test suite 211/211
passing; full test suite 369/372 (3 pre-existing Inbox/Reconciliation
failures unchanged). ProviderDrawer now 7/7.
2026-06-21 16:41:15 -06:00
Tyler 0678e25de7 feat(drill): ProviderDrawer with Overview tab + DrillDrawerHeader shell 2026-06-21 16:41:15 -06:00
Tyler 5b3b8619e6 feat(drill): useProviderDrawerUrlState — provider drawer URL state (mirrors remit hook) 2026-06-21 16:41:15 -06:00
Tyler b6607b2009 feat(api): harden CORS and surface 500/409 errors with proper CORS headers
Three independent improvements that fix real browser-facing bugs:

1. CORS: allow 127.0.0.1:5173 in addition to localhost:5173. Both
   resolve to the same Vite dev server but CORS treats them as distinct
   origins, so tabs opened via the IP form silently break.
2. CORS: support CYCLONE_ALLOWED_ORIGINS env var (comma-separated) for
   LAN / staging hosts. The middleware reads it at module import.
3. Catch-all exception handler: returns JSON 500 with CORS headers
   instead of a bare Uvicorn text/plain response. Without this, any
   unhandled exception is misreported by browsers as a CORS error
   because the body can't be read without the allow-origin header.
4. IntegrityError → 409: when (batch_id, patient_control_number) is
   UNIQUE-constrained and a duplicate collides, return 409 with the
   batch id instead of letting the exception 500. Same problem as (3)
   for the most common ingest failure mode.

Tests added:
- test_cors_headers_present_for_loopback_ip
- test_cors_extra_origins_via_env (uses importlib.reload because the
  allow-list is built at module import)
2026-06-21 16:29:59 -06:00
Tyler c0b7924aad docs(sp22): drop speculative uv.lock note from deviations 2026-06-21 16:28:24 -06:00
Tyler ebd2834cc4 docs(sp22): backfill plan with 10 as-built deviations
The implementation shipped with 10 inline bug fixes that weren't reflected
in the original plan document. This commit updates the plan so it
matches the as-built code and adds a summary table near the top so a
future reader of the plan knows what was adjusted and why.

- Bug 1a: AckTimeoutError.__init__ signature widened from int to float
  plus adds self.phase attribute for report remediation hints.
- Bug 1b: wait_for passes timeout_s through without int() round-trip.
- Bug 2: Markdown table assertion updated to match the actual format.
- Bug 3: Added ## Remediation section to write_report_md for soft/hard fails.
- Bug 4: 835 expected-by text now says 'typically the following Monday'.
- Bug 5: Removed bogus HealthSnapshot import in test_pipeline.py.
- Bug 6: All phase tests wrapped in 'async with CyclonePipeline(...) as p:'.
- Bug 7: Playwright + UploadPage imports moved to module level in pipeline.py.
- Bug 8: Added _phase_records_to_results() helper for PhaseRecord→PhaseResult.
- Bug 9: Resume test uses _make_stub factory so stubs append to completed_phases.
- Bug 10: CLI uses context_settings={'allow_interspersed_args': True}.
2026-06-21 16:28:07 -06:00
Tyler 888c99d848 docs: cross-link to cyclone-pipeline sibling project
Add a 'Pipeline automation agent' section under '## Dev' that
points operators to the sibling project at
/Users/openclaw/dev/cyclone-pipeline/. Add a 'Sub-project 22
(shipped)' entry to the roadmap so the new project is discoverable
from the cyclone README's release history.
2026-06-21 16:12:10 -06:00
Cyclone UI 388ea6e49b Refine Batch Diff page with hybrid dark/paper treatment
- Replace small header with editorial hero: massive 'Compare *batches.*'
  (clamp 48-80px serif, italic for 'batches.') + ghost 'DIFF' watermark
  + GitCompareArrows pill (837P/835/first vs second) + pick-a-batch hint
- Add torn-page fold with '↘ A → B ↙' label and 48-dot perforation
- Cream paper plane (max-w-[1280px] mx-auto) with paper-grain SVG and
  double-bordered title block: 'SHEET 01 · COMPARE TWO BATCHES' over
  'Compare them.' (clamp 48-96px) plus A→B wire indicator (blue A,
  amber B, paper-ink-3 placeholder)
- New Folio helper renders the § N + vertical-rl italic label; reused
  on the picks and diff sections
- § 01 The picks: BatchPicker gets a paper-toned card with side badge
  (A blue / B amber tinted square) and claim count, preserving the
  data-testid='diff-picker-{a,b}' and 'diff-picker-kind-{kind}' and
  'diff-picker-option-{id}' contracts
- § 02 The diff: conditional rendering (awaiting-picks dashed card,
  loading skeleton, not-found, error, empty diff, full diff view)
  with paper-toned wrappers
- BatchDiffView refactored to paper-toned chrome: SideMeta cards
  (warm surface, surface-ink text), SummaryCards → new DiffKpiTile
  helper (success/destructive/amber/ink accent rails with lucide
  icons), SectionTables → tone='paper' tables with cream header band
  and surface-ink text. All section/row/indicator testids preserved.
- Action footer: 'Comparing A with B.' italic note + Refresh / Clear
  picks buttons; paper-toned container, sits inside the paper plane
- Bottom footer: 'End of sheet 01 / Cyclone · Batch diff / A vs B
  or awaiting picks'

Round 11/11 — last page in the hybrid sweep.
2026-06-21 14:37:36 -06:00
Cyclone UI 736bf4d333 Refine Batches page with hybrid dark/paper treatment
- Add tone='paper' prop to shared Table/TableHeader/TableRow/TableHead/
  TableCell components; paper-toned chrome swaps dark muted/20 header
  for cream paper, dark hover for warm cream hover, dark selected for
  paper blue tint, muted-foreground text for surface-ink. Dark tone
  is the default and unchanged.
- Extend BatchesList with tone='paper' variant: cream hover, warm
  surface-ink text, paper-tinted open-row (blue tint + ring). Kind
  badge (text-sky-300 / text-amber-300 + data-testid) and row
  data-testid='batch-row-{id}' preserved for the test contract.
- Replace PageHeader with editorial hero: massive 'Parsed *batches.*'
  (clamp 48-80px serif, italic for 'batches.') + ghost 'PARSED'
  watermark + Files pill (837P/835/envelope) + tap-to-open hint
- Add torn-page fold with '↘ THE REGISTER ↙' label and 48-dot perforation
- Cream paper plane (max-w-[1280px] mx-auto) with paper-grain SVG and
  double-bordered title block: 'REGISTER · PARSED BATCHES' over
  'The register.' (clamp 48-96px) plus on-file count column
- Folio system: § 01 Vital signs (4 paper KPI tiles via new
  BatchesKpiTile: On file / 837P / 835 / Claims with ink/blue/amber/
  success accent rails and Icons from lucide), § 02 The register
  (paper-toned BatchesList)
- Error/Loading/Empty states wrapped in paper-toned containers
- Footer: 'End of register / Cyclone · Batches / N rows'

Round 10/11.
2026-06-21 14:34:26 -06:00
35 changed files with 3831 additions and 410 deletions
+37
View File
@@ -51,6 +51,32 @@ VITE_API_BASE_URL=http://127.0.0.1:8000
Without that, the UI falls back to its in-memory sample store via the Without that, the UI falls back to its in-memory sample store via the
existing `data` adapter (parses are disabled). existing `data` adapter (parses are disabled).
## Pipeline automation agent
For unattended round-trips (an agent / scheduler drops an 837P file
into the pipeline and waits for the 999 back from Gainwell), see the
`cyclone-pipeline` sibling project at `/Users/openclaw/dev/cyclone-pipeline/`.
It drives the full 7-phase state machine — preflight → browser upload →
parse verification → SFTP submit → TA1 wait → 999 wait → scan +
report — with structured JSON logs, crash-safe resume, and a
self-contained per-run folder under `./runs/`.
```bash
# Single file
cyclone-pipeline run /path/to/axiscare-837p.txt
# Resume a crashed run
cyclone-pipeline resume 2026-06-21-1430-001
# On/after the following Monday, verify the 835 arrived
cyclone-pipeline check-835 2026-06-21-1430-001
```
The 835 is **not** waited for inline (it lands the following Monday on
the CO Medicaid payment cycle). See
[`cyclone-pipeline/README.md`](../cyclone-pipeline/README.md) for
install, embed-in-agent example, exit codes, and the report format.
## Skills ## Skills
Cyclone ships 8 project-scoped AI-assistant skills under Cyclone ships 8 project-scoped AI-assistant skills under
@@ -743,6 +769,17 @@ scope.
Shipped sub-projects (most recent first): Shipped sub-projects (most recent first):
- **Sub-project 22 (shipped) — Pipeline automation agent.** A
sibling project at `/Users/openclaw/dev/cyclone-pipeline` that
drives the full 7-phase round-trip (preflight → browser upload →
parse verify → SFTP submit → TA1 wait → 999 wait → scan + report)
with crash-safe resume, structured JSON logging, idempotency
dedup, and a per-run report. Pure Python 3.11+ (httpx, Playwright,
Click, pydantic v2, structlog). The 835 is not waited for inline —
it lands the following Monday — and is verified by a separate
`check-835` subcommand. Embeddable as a library for OpenClaw / Nora
agent integration. See
[Pipeline automation agent](#pipeline-automation-agent) above.
- **Sub-project 19 (shipped) — Security hardening + health probe.** - **Sub-project 19 (shipped) — Security hardening + health probe.**
Three pure-ASGI middlewares (`BodySizeLimitMiddleware`, Three pure-ASGI middlewares (`BodySizeLimitMiddleware`,
`RateLimitMiddleware`, `SecurityHeadersMiddleware`) close the `RateLimitMiddleware`, `SecurityHeadersMiddleware`) close the
+89 -6
View File
@@ -9,8 +9,11 @@ The frontend (Vite/React on http://localhost:5173) uploads an X12 file via
— one envelope, one line per claim/payout, then one summary — so the — one envelope, one line per claim/payout, then one summary — so the
UI can render records incrementally as they're produced. UI can render records incrementally as they're produced.
CORS is configured to allow the Vite dev origin (``http://localhost:5173``) CORS is configured to allow the Vite dev origins (``http://localhost:5173``
plus GET/POST with any header. and ``http://127.0.0.1:5173`` — both forms are valid dev-server addresses
but CORS treats them as distinct origins) plus GET/POST with any header.
Additional origins (LAN IPs, staging hosts) can be appended via the
``CYCLONE_ALLOWED_ORIGINS`` env var as a comma-separated list.
""" """
from __future__ import annotations from __future__ import annotations
@@ -19,6 +22,7 @@ import csv
import io import io
import json import json
import logging import logging
import os
import uuid import uuid
from datetime import datetime, timezone from datetime import datetime, timezone
from contextlib import asynccontextmanager from contextlib import asynccontextmanager
@@ -33,6 +37,7 @@ from pydantic import ValidationError
from cyclone import __version__, db from cyclone import __version__, db
from cyclone.db import Claim, ClaimState, Remittance from cyclone.db import Claim, ClaimState, Remittance
from sqlalchemy import desc, or_ from sqlalchemy import desc, or_
from sqlalchemy.exc import IntegrityError
from cyclone.inbox_state import apply_999_rejections from cyclone.inbox_state import apply_999_rejections
from cyclone.inbox_state_277ca import apply_277ca_rejections from cyclone.inbox_state_277ca import apply_277ca_rejections
from cyclone.audit_log import AuditEvent, append_event, verify_chain from cyclone.audit_log import AuditEvent, append_event, verify_chain
@@ -214,7 +219,17 @@ PAYER_FACTORIES_835: dict[str, Any] = {
"generic_835": PayerConfig835.generic_835, "generic_835": PayerConfig835.generic_835,
} }
VITE_DEV_ORIGIN = "http://localhost:5173" # Allow both common dev-server origins. ``localhost`` and ``127.0.0.1``
# resolve to the same Vite dev server but CORS treats them as distinct
# origins, so the allow-list has to list both — otherwise a tab opened
# via the IP form gets blocked even though the dev server is identical.
VITE_DEV_ORIGINS: list[str] = [
"http://localhost:5173",
"http://127.0.0.1:5173",
]
_extra_origins = os.environ.get("CYCLONE_ALLOWED_ORIGINS", "").strip()
if _extra_origins:
VITE_DEV_ORIGINS.extend(o.strip() for o in _extra_origins.split(",") if o.strip())
app = FastAPI( app = FastAPI(
title="Cyclone 837P / 835 Parser API", title="Cyclone 837P / 835 Parser API",
@@ -225,7 +240,7 @@ app = FastAPI(
app.add_middleware( app.add_middleware(
CORSMiddleware, CORSMiddleware,
allow_origins=[VITE_DEV_ORIGIN], allow_origins=VITE_DEV_ORIGINS,
allow_credentials=False, allow_credentials=False,
allow_methods=["GET", "POST"], allow_methods=["GET", "POST"],
allow_headers=["*"], allow_headers=["*"],
@@ -282,6 +297,35 @@ def _resolve_payer_835(name: str) -> PayerConfig835:
return PAYER_FACTORIES_835[name]() return PAYER_FACTORIES_835[name]()
# --------------------------------------------------------------------------- #
# Catch-all exception handler
# --------------------------------------------------------------------------- #
#
# Without this, any exception that escapes a route handler is rendered by
# Uvicorn as a bare ``500 Internal Server Error`` text/plain response with
# NO CORS headers. Browsers reading such a response report it as a CORS
# error (``Origin ... is not allowed by Access-Control-Allow-Origin``)
# because they cannot read the body without the CORS allow-origin header
# — even though the actual failure was on the server. We catch everything
# here, log it, and return a JSON error with the request's Origin echoed
# back so the browser can surface the real message.
@app.exception_handler(Exception)
async def _unhandled_exception_handler(request: Request, exc: Exception) -> JSONResponse:
log.exception(
"Unhandled exception in %s %s", request.method, request.url.path
)
headers: dict[str, str] = {}
origin = request.headers.get("origin", "")
if origin:
headers["Access-Control-Allow-Origin"] = origin
headers["Vary"] = "Origin"
return JSONResponse(
status_code=500,
content={"error": "Internal server error", "detail": str(exc)},
headers=headers,
)
@app.post("/api/parse-837") @app.post("/api/parse-837")
async def parse_837( async def parse_837(
request: Request, request: Request,
@@ -345,7 +389,30 @@ async def parse_837(
parsed_at=utcnow(), parsed_at=utcnow(),
result=result, result=result,
) )
store.add(rec, event_bus=request.app.state.event_bus) try:
store.add(rec, event_bus=request.app.state.event_bus)
except IntegrityError as exc:
# ``(batch_id, patient_control_number)`` is UNIQUE — fires when a
# single batch file contains the same CLM01 control number twice,
# or when the same claim id has already been ingested in a prior
# batch. Surface as 409 with the batch id so the caller can look
# it up; do NOT 500 (a 500 without CORS headers is misreported by
# browsers as a CORS error and hides the real cause).
log.warning("Duplicate claim while persisting batch %s: %s", rec.id, exc)
return JSONResponse(
status_code=409,
content={
"error": "Duplicate claim",
"detail": (
"This file (or one previously ingested with the same "
"claim control number) collides with an existing "
"record. Inspect the file for duplicate CLM01 "
"control numbers, or remove the existing batch "
"before retrying."
),
"batch_id": rec.id,
},
)
if _client_wants_json(request): if _client_wants_json(request):
body = json.loads(result.model_dump_json()) body = json.loads(result.model_dump_json())
@@ -516,7 +583,23 @@ async def parse_835_endpoint(
parsed_at=utcnow(), parsed_at=utcnow(),
result=result, result=result,
) )
store.add(rec, event_bus=request.app.state.event_bus) try:
store.add(rec, event_bus=request.app.state.event_bus)
except IntegrityError as exc:
log.warning("Duplicate remittance while persisting batch %s: %s", rec.id, exc)
return JSONResponse(
status_code=409,
content={
"error": "Duplicate remittance",
"detail": (
"This 835 file (or one previously ingested with the "
"same payer claim control number) collides with an "
"existing record. Remove the existing remittance "
"before retrying."
),
"batch_id": rec.id,
},
)
if _client_wants_json(request): if _client_wants_json(request):
body = json.loads(result.model_dump_json()) body = json.loads(result.model_dump_json())
+12 -1
View File
@@ -1668,7 +1668,16 @@ class CycloneStore:
return list(by_npi.values()) return list(by_npi.values())
def recent_activity(self, *, limit: int = 200) -> list[dict]: def recent_activity(self, *, limit: int = 200) -> list[dict]:
"""Return recent activity events from the DB, newest first.""" """Return recent activity events from the DB, newest first.
SP21 Task 2.5: each row also carries ``claimId`` and
``remittanceId`` (read from the ORM columns) so the Dashboard's
Recent-activity card can route clicks to the right entity
drawer via ``src/lib/event-routing.ts``. Both are nullable
strings; the wire shape uses camelCase keys to match the
existing ``npi`` / ``amount`` fields and the frontend
``Activity`` interface.
"""
with db.SessionLocal()() as s: with db.SessionLocal()() as s:
rows = ( rows = (
s.query(ActivityEvent) s.query(ActivityEvent)
@@ -1684,6 +1693,8 @@ class CycloneStore:
"timestamp": r.ts.isoformat().replace("+00:00", "Z"), "timestamp": r.ts.isoformat().replace("+00:00", "Z"),
"npi": (r.payload_json or {}).get("npi"), "npi": (r.payload_json or {}).get("npi"),
"amount": (r.payload_json or {}).get("amount"), "amount": (r.payload_json or {}).get("amount"),
"claimId": r.claim_id,
"remittanceId": r.remittance_id,
} }
for r in rows for r in rows
] ]
+48
View File
@@ -160,3 +160,51 @@ def test_cors_headers_present(client: TestClient):
) )
assert resp.headers.get("access-control-allow-origin") == "http://localhost:5173" assert resp.headers.get("access-control-allow-origin") == "http://localhost:5173"
assert "POST" in resp.headers.get("access-control-allow-methods", "").upper() assert "POST" in resp.headers.get("access-control-allow-methods", "").upper()
def test_cors_headers_present_for_loopback_ip(client: TestClient):
# ``http://127.0.0.1:5173`` is a distinct origin from
# ``http://localhost:5173`` per the CORS spec, even though both resolve
# to the same Vite dev server. Both must be allow-listed or tabs opened
# via the IP form silently break.
resp = client.options(
"/api/parse-837",
headers={
"Origin": "http://127.0.0.1:5173",
"Access-Control-Request-Method": "POST",
"Access-Control-Request-Headers": "content-type",
},
)
assert resp.headers.get("access-control-allow-origin") == "http://127.0.0.1:5173"
def test_cors_extra_origins_via_env(client: TestClient, monkeypatch):
# LAN / staging hosts opt in via CYCLONE_ALLOWED_ORIGINS. The env var
# is a comma-separated list; the middleware must reflect each entry.
# The allow-list is built at module import, so we re-execute the
# module under the env var and build a TestClient against the
# reloaded app.
monkeypatch.setenv(
"CYCLONE_ALLOWED_ORIGINS", "http://192.168.1.42:5173,https://staging.example.com"
)
import importlib
from cyclone import api as api_module
from fastapi.testclient import TestClient as _TC
importlib.reload(api_module)
try:
with _TC(api_module.app) as tc:
for origin in ("http://192.168.1.42:5173", "https://staging.example.com"):
resp = tc.options(
"/api/parse-837",
headers={
"Origin": origin,
"Access-Control-Request-Method": "POST",
"Access-Control-Request-Headers": "content-type",
},
)
assert resp.headers.get("access-control-allow-origin") == origin
finally:
monkeypatch.delenv("CYCLONE_ALLOWED_ORIGINS", raising=False)
# Reload once more so the module-level allow-list returns to its
# default for any test that imports `cyclone.api` after this one.
importlib.reload(api_module)
@@ -12,6 +12,32 @@
--- ---
## As-built deviations
The implementation shipped with 10 deviations from this plan, all fixed
inline during TDD execution. They are catalogued here so a re-run of
the plan (or a reviewer of the implementation) knows what was
adjusted and why.
| # | Bug | Where | Fix |
|---|---|---|---|
| 1a | `AckTimeoutError.__init__(self, ack_kind, timeout_s: int)` — the `int` annotation broke tests asserting `timeout_s == pytest.approx(0.2, abs=0.1)`. | `src/cyclone_pipeline/exceptions.py` | Widened to `timeout_s: float`; added `self.phase = f"wait_{ack_kind}"` so `report.py` can render the right remediation hint. |
| 1b | `wait_for` raised `AckTimeoutError(label, int(timeout_s))` — round-tripping `float → int → float` lost sub-second precision and broke the same `pytest.approx` assertion. | `src/cyclone_pipeline/waiters.py` | Pass `timeout_s` through unchanged. |
| 2 | Markdown table assertion `assert "\| 1. Pre-flight" in text or "\| 1." in text` didn't match the actual table format `\| 1 \| preflight \|`. | `tests/test_report.py::test_markdown_contains_phase_table` | Tightened assertion to `\| 1 \| preflight`. |
| 3 | Markdown report had no "Remediation" section — operators had to read phase detail to figure out next steps when an ACK timed out. | `src/cyclone_pipeline/report.py::write_report_md` | Added a new `## Remediation` section after `expected_835_by` when `report.result` is `soft_fail` or `hard_fail`. Text mentions "in flight" and "Gainwell directly" so it's greppable. |
| 4 | 835 expected-by text didn't say *when* — just "CO Medicaid payment cycle". | `src/cyclone_pipeline/report.py::write_report_md` | Added "typically the following Monday" so operators can plan a check-835 run. |
| 5 | Test imported `HealthSnapshot as _Ignored` from `cyclone_pipeline.exceptions` — it lives in `state.py`. | `tests/test_pipeline.py` | Removed the bogus import. |
| 6 | Plan tests instantiated `CyclonePipeline(cfg, ...)` and called phases directly — but `__aexit__` is required to set `self._client` (and to close the browser on phase 2). | `tests/test_pipeline.py` (all phase tests) | Wrapped every `p = CyclonePipeline(...)` call in `async with CyclonePipeline(...) as p:`. |
| 7 | Plan did `from playwright.async_api import async_playwright` and `from cyclone_pipeline.browser import UploadPage` *inside* `phase2_upload` for "lazy loading" — but tests patch `cyclone_pipeline.pipeline.async_playwright` and `cyclone_pipeline.pipeline.UploadPage` (module-level), so the patches had no effect. | `src/cyclone_pipeline/pipeline.py` | Moved both imports to module level. |
| 8 | Plan had `phases=list(self.run_state.completed_phases)``PhaseRecord` (in `state.py`) and `PhaseResult` (in `report.py`) are distinct pydantic v2 models, so passing one where the other is expected fails (no auto-coercion). | `src/cyclone_pipeline/pipeline.py::phase7_scan_and_report` | Added `_phase_records_to_results()` helper that goes through `.model_dump()`; phase 7 now uses it. |
| 9 | Resume test stubbed phases 5/6/7 with `AsyncMock(return_value=PhaseResult(...))``resume()` only appends to `completed_phases` via its own logic; the mocks returned a result but didn't mutate state, so `len(report.phases) >= 4` failed (got 3 from the seeded phases 1/2/3). | `tests/test_pipeline.py::test_resume_skips_completed_phases` | Replaced with a `_make_stub(n, name)` factory that appends the result to `p.run_state.completed_phases`. Phase 4 also updated. |
| 10 | CLI `runner.invoke(main, ["status", "--run-dir", ...])` failed with click complaining that `--run-dir` appeared after the subcommand. | `src/cyclone_pipeline/cli.py` | Added `context_settings={"allow_interspersed_args": True}` to the `@click.group()` decorator. |
**Other as-built adjustments (not bugs):**
- Tasks 1421 were committed as one combined commit `616e3be` instead of 8 separate commits — the plan's per-task commit cadence was dropped in favour of fewer, larger commits once the test-fix-verify cycle accelerated.
---
## File structure ## File structure
``` ```
@@ -393,9 +419,10 @@ class AckTimeoutError(CyclonePipelineError):
"""An expected inbound ACK did not arrive within the configured """An expected inbound ACK did not arrive within the configured
timeout window. Soft-fail — the submission is in flight.""" timeout window. Soft-fail — the submission is in flight."""
def __init__(self, ack_kind: str, timeout_s: int): def __init__(self, ack_kind: str, timeout_s: float):
self.ack_kind = ack_kind # "ta1" | "999" | "277ca" | "835" self.ack_kind = ack_kind # "ta1" | "999" | "277ca" | "835"
self.timeout_s = timeout_s self.timeout_s = timeout_s
self.phase = f"wait_{ack_kind}"
super().__init__( super().__init__(
f"No {ack_kind} ACK arrived within {timeout_s}s; " f"No {ack_kind} ACK arrived within {timeout_s}s; "
f"submission is in flight — check Gainwell directly." f"submission is in flight — check Gainwell directly."
@@ -1984,7 +2011,7 @@ async def wait_for(
if result is not None: if result is not None:
return result return result
if time.monotonic() >= deadline: if time.monotonic() >= deadline:
raise AckTimeoutError(label, int(timeout_s)) raise AckTimeoutError(label, timeout_s)
await asyncio.sleep(poll_interval_s) await asyncio.sleep(poll_interval_s)
``` ```
@@ -2084,7 +2111,7 @@ def test_markdown_contains_phase_table(sample_report, tmp_path):
assert "# Cyclone pipeline run" in text assert "# Cyclone pipeline run" in text
assert "PASS" in text assert "PASS" in text
assert "Phase summary" in text assert "Phase summary" in text
assert "| 1. Pre-flight" in text or "| 1." in text assert "| 1 | preflight" in text
assert "check-835" in text assert "check-835" in text
assert "Monday" in text assert "Monday" in text
assert "01-preflight.png" in text assert "01-preflight.png" in text
@@ -2186,12 +2213,29 @@ def write_report_md(report: RunReport, path: Path) -> None:
lines.append("") lines.append("")
lines.append( lines.append(
f"- **835 expected by {report.expected_835_by}** " f"- **835 expected by {report.expected_835_by}** "
f"(CO Medicaid payment cycle)." f"(typically the following Monday; CO Medicaid payment cycle)."
) )
cmd = report.next_steps.get("check_835_cmd") cmd = report.next_steps.get("check_835_cmd")
if cmd: if cmd:
lines.append(f" - Re-run: `{cmd}`") lines.append(f" - Re-run: `{cmd}`")
lines.append("") lines.append("")
# Remediation section — only when the run is not a clean pass.
if report.result in ("soft_fail", "hard_fail"):
lines.append("## Remediation")
lines.append("")
timed_out = [p for p in report.phases if p.status == "timeout"]
if timed_out:
names = ", ".join(p.name for p in timed_out)
lines.append(
f"- ACK timeout(s) in: {names}. Submission is in flight "
f"— check Gainwell directly for the inbound 999."
)
if report.result == "hard_fail":
lines.append(
"- Hard failure: review the run logs and any screenshots "
f"in the `screenshots/` directory before retrying."
)
lines.append("")
lines.append("## Artifacts") lines.append("## Artifacts")
lines.append("") lines.append("")
for s in report.screenshots: for s in report.screenshots:
@@ -2433,7 +2477,7 @@ from pathlib import Path
from cyclone_pipeline.pipeline import CyclonePipeline, PipelineConfig from cyclone_pipeline.pipeline import CyclonePipeline, PipelineConfig
from cyclone_pipeline.state import RunState from cyclone_pipeline.state import RunState
from cyclone_pipeline.exceptions import ( from cyclone_pipeline.exceptions import (
BrowserNotReachableError, HealthSnapshot as _Ignored, # noqa BrowserNotReachableError,
) )
@@ -2474,9 +2518,9 @@ async def test_phase1_preflight_passes_when_backend_healthy(tmp_path: Path):
run_dir=tmp_path / "runs", run_dir=tmp_path / "runs",
headless=True, headless=True,
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-001" p._run_id = "test-run-001"
result = await p.phase1_preflight() result = await p.phase1_preflight()
assert result.status == "ok" assert result.status == "ok"
assert "scheduler_state" in result.detail assert "scheduler_state" in result.detail
@@ -2511,10 +2555,10 @@ async def test_phase1_preflight_fails_fast_if_browser_down(tmp_path: Path):
run_dir=tmp_path / "runs", run_dir=tmp_path / "runs",
headless=True, headless=True,
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-001" p._run_id = "test-run-001"
with pytest.raises(BrowserNotReachableError): with pytest.raises(BrowserNotReachableError):
await p.phase1_preflight() await p.phase1_preflight()
``` ```
- [ ] **Step 2: Run test to verify it fails** - [ ] **Step 2: Run test to verify it fails**
@@ -2547,12 +2591,14 @@ import uuid
from dataclasses import dataclass, field from dataclasses import dataclass, field
from datetime import datetime, timezone from datetime import datetime, timezone
from pathlib import Path from pathlib import Path
from typing import Any from typing import Any, Sequence
import httpx import httpx
import structlog import structlog
from playwright.async_api import async_playwright
from cyclone_pipeline.api_client import CycloneClient from cyclone_pipeline.api_client import CycloneClient
from cyclone_pipeline.browser import UploadPage
from cyclone_pipeline.exceptions import ( from cyclone_pipeline.exceptions import (
BrowserNotReachableError, CyclonePipelineError, UploadError, BrowserNotReachableError, CyclonePipelineError, UploadError,
ParseError, SubmitError, AckTimeoutError, IdempotencyError, ParseError, SubmitError, AckTimeoutError, IdempotencyError,
@@ -2560,7 +2606,7 @@ from cyclone_pipeline.exceptions import (
from cyclone_pipeline.logging_setup import get_logger from cyclone_pipeline.logging_setup import get_logger
from cyclone_pipeline.report import PhaseResult, RunReport from cyclone_pipeline.report import PhaseResult, RunReport
from cyclone_pipeline.screenshots import ScreenshotWriter from cyclone_pipeline.screenshots import ScreenshotWriter
from cyclone_pipeline.state import RunState from cyclone_pipeline.state import PhaseRecord, RunState
log = get_logger("cyclone_pipeline.pipeline") log = get_logger("cyclone_pipeline.pipeline")
@@ -2706,39 +2752,39 @@ async def test_phase2_upload_retries_on_failure(tmp_path: Path):
run_dir=tmp_path / "runs", run_dir=tmp_path / "runs",
headless=True, headless=True,
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-002" p._run_id = "test-run-002"
fake_page = AsyncMock() fake_page = AsyncMock()
fake_page.goto = AsyncMock() fake_page.goto = AsyncMock()
fake_upload = AsyncMock() fake_upload = AsyncMock()
# First two attempts raise, third succeeds # First two attempts raise, third succeeds
fake_upload.attach_file = AsyncMock( fake_upload.attach_file = AsyncMock(
side_effect=[UploadError("flaky"), UploadError("flaky"), None] side_effect=[UploadError("flaky"), UploadError("flaky"), None]
)
fake_upload.click_parse = AsyncMock()
fake_upload.wait_for_progress_complete = AsyncMock()
with patch(
"cyclone_pipeline.pipeline.async_playwright"
) as mock_pw:
mock_browser = AsyncMock()
mock_pw.return_value.__aenter__.return_value.chromium.launch = AsyncMock(
return_value=mock_browser
) )
mock_browser.new_page = AsyncMock(return_value=fake_page) fake_upload.click_parse = AsyncMock()
fake_upload.wait_for_progress_complete = AsyncMock()
# Stub the screenshot writer with patch(
p._writer = ScreenshotWriter(tmp_path, "test-run-002") "cyclone_pipeline.pipeline.async_playwright"
) as mock_pw:
mock_browser = AsyncMock()
mock_pw.return_value.__aenter__.return_value.chromium.launch = AsyncMock(
return_value=mock_browser
)
mock_browser.new_page = AsyncMock(return_value=fake_page)
# Replace UploadPage class with a stub # Stub the screenshot writer
with patch("cyclone_pipeline.pipeline.UploadPage") as UP: p._writer = ScreenshotWriter(tmp_path, "test-run-002")
UP.return_value = fake_upload
UP.return_value.goto = AsyncMock() # Replace UploadPage class with a stub
result = await p.phase2_upload(max_attempts=3) with patch("cyclone_pipeline.pipeline.UploadPage") as UP:
assert result.status == "ok" UP.return_value = fake_upload
assert result.attempts == 3 UP.return_value.goto = AsyncMock()
assert fake_upload.attach_file.call_count == 3 result = await p.phase2_upload(max_attempts=3)
assert result.status == "ok"
assert result.attempts == 3
assert fake_upload.attach_file.call_count == 3
``` ```
- [ ] **Step 2: Run test to verify it fails** - [ ] **Step 2: Run test to verify it fails**
@@ -2763,9 +2809,6 @@ Append to `cyclone_pipeline/pipeline.py`:
last_exc: Exception | None = None last_exc: Exception | None = None
for attempt in range(1, max_attempts + 1): for attempt in range(1, max_attempts + 1):
try: try:
from playwright.async_api import async_playwright
from cyclone_pipeline.browser import UploadPage
async with async_playwright() as pw: async with async_playwright() as pw:
browser = await pw.chromium.launch( browser = await pw.chromium.launch(
headless=self.cfg.headless headless=self.cfg.headless
@@ -2868,9 +2911,9 @@ async def test_phase3_verify_parse_collects_new_claim_ids(tmp_path: Path):
browser_base="http://127.0.0.1:5173", browser_base="http://127.0.0.1:5173",
run_dir=tmp_path / "runs", run_dir=tmp_path / "runs",
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-003" p._run_id = "test-run-003"
result = await p.phase3_verify_parse() result = await p.phase3_verify_parse()
assert result.status == "ok" assert result.status == "ok"
assert p.run_state.pending_data["claim_ids"] == ["CLM-1", "CLM-2"] assert p.run_state.pending_data["claim_ids"] == ["CLM-1", "CLM-2"]
@@ -2887,10 +2930,10 @@ async def test_phase3_verify_parse_fails_on_zero_claims(tmp_path: Path):
browser_base="http://127.0.0.1:5173", browser_base="http://127.0.0.1:5173",
run_dir=tmp_path / "runs", run_dir=tmp_path / "runs",
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-003b" p._run_id = "test-run-003b"
with pytest.raises(ParseError): with pytest.raises(ParseError):
await p.phase3_verify_parse(timeout_s=0.2) await p.phase3_verify_parse(timeout_s=0.2)
``` ```
- [ ] **Step 2: Run test to verify it fails** - [ ] **Step 2: Run test to verify it fails**
@@ -2995,10 +3038,10 @@ async def test_phase4_submit_stores_submission_data(tmp_path: Path):
browser_base="http://127.0.0.1:5173", browser_base="http://127.0.0.1:5173",
run_dir=tmp_path / "runs", run_dir=tmp_path / "runs",
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-004" p._run_id = "test-run-004"
p.run_state.pending_data["claim_ids"] = ["CLM-1", "CLM-2"] p.run_state.pending_data["claim_ids"] = ["CLM-1", "CLM-2"]
result = await p.phase4_submit() result = await p.phase4_submit()
assert result.status == "ok" assert result.status == "ok"
assert p.run_state.pending_data["submission_id"] == "SUB-42" assert p.run_state.pending_data["submission_id"] == "SUB-42"
assert p.run_state.pending_data["submission_filename"].endswith(".txt") assert p.run_state.pending_data["submission_filename"].endswith(".txt")
@@ -3019,10 +3062,10 @@ async def test_phase4_submit_propagates_idempotency_error(tmp_path: Path):
browser_base="http://127.0.0.1:5173", browser_base="http://127.0.0.1:5173",
run_dir=tmp_path / "runs", run_dir=tmp_path / "runs",
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-004b" p._run_id = "test-run-004b"
with pytest.raises(IdempotencyError): with pytest.raises(IdempotencyError):
await p.phase4_submit() await p.phase4_submit()
``` ```
- [ ] **Step 2: Run test to verify it fails** - [ ] **Step 2: Run test to verify it fails**
@@ -3128,13 +3171,13 @@ async def test_phase5_wait_ta1_returns_matching_ack(tmp_path: Path):
ta1_timeout_s=2.0, ta1_timeout_s=2.0,
poll_interval_s=0.05, poll_interval_s=0.05,
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-005" p._run_id = "test-run-005"
p.run_state.pending_data["submission_filename"] = ( p.run_state.pending_data["submission_filename"] = (
"11525703-837P-…-1of1.txt" "11525703-837P-…-1of1.txt"
) )
p.run_state.pending_data["claim_ids"] = ["CLM-1"] p.run_state.pending_data["claim_ids"] = ["CLM-1"]
result = await p.phase5_wait_ta1() result = await p.phase5_wait_ta1()
assert result.status == "ok" assert result.status == "ok"
assert result.detail["ta1_id"] == "TA1-42" assert result.detail["ta1_id"] == "TA1-42"
@@ -3152,11 +3195,11 @@ async def test_phase5_wait_ta1_timeout_returns_status_timeout(tmp_path: Path):
ta1_timeout_s=0.2, ta1_timeout_s=0.2,
poll_interval_s=0.05, poll_interval_s=0.05,
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-005b" p._run_id = "test-run-005b"
p.run_state.pending_data["submission_filename"] = "x.txt" p.run_state.pending_data["submission_filename"] = "x.txt"
p.run_state.pending_data["claim_ids"] = ["CLM-1"] p.run_state.pending_data["claim_ids"] = ["CLM-1"]
result = await p.phase5_wait_ta1() result = await p.phase5_wait_ta1()
assert result.status == "timeout" assert result.status == "timeout"
# Pipeline continues; this is soft-fail. # Pipeline continues; this is soft-fail.
``` ```
@@ -3261,11 +3304,11 @@ async def test_phase6_wait_999_returns_matching_ack(tmp_path: Path):
ack_999_timeout_s=2.0, ack_999_timeout_s=2.0,
poll_interval_s=0.05, poll_interval_s=0.05,
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-006" p._run_id = "test-run-006"
p.run_state.pending_data["submission_filename"] = "x.txt" p.run_state.pending_data["submission_filename"] = "x.txt"
p.run_state.pending_data["claim_ids"] = ["CLM-1"] p.run_state.pending_data["claim_ids"] = ["CLM-1"]
result = await p.phase6_wait_999() result = await p.phase6_wait_999()
assert result.status == "ok" assert result.status == "ok"
assert result.detail["ack_999_id"] == "999-43" assert result.detail["ack_999_id"] == "999-43"
@@ -3288,12 +3331,12 @@ async def test_phase6_wait_999_rejected_is_hard_fail(tmp_path: Path):
ack_999_timeout_s=2.0, ack_999_timeout_s=2.0,
poll_interval_s=0.05, poll_interval_s=0.05,
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-006b" p._run_id = "test-run-006b"
p.run_state.pending_data["submission_filename"] = "x.txt" p.run_state.pending_data["submission_filename"] = "x.txt"
p.run_state.pending_data["claim_ids"] = ["CLM-1"] p.run_state.pending_data["claim_ids"] = ["CLM-1"]
with pytest.raises(CyclonePipelineError) as exc_info: with pytest.raises(CyclonePipelineError) as exc_info:
await p.phase6_wait_999() await p.phase6_wait_999()
assert "rejected" in str(exc_info.value).lower() assert "rejected" in str(exc_info.value).lower()
``` ```
@@ -3405,15 +3448,15 @@ async def test_phase7_scan_html_and_write_reports(tmp_path: Path):
browser_base="http://127.0.0.1:5173", browser_base="http://127.0.0.1:5173",
run_dir=tmp_path / "runs", run_dir=tmp_path / "runs",
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "test-run-007" p._run_id = "test-run-007"
# Seed a couple of completed phases to make the report non-empty # Seed a couple of completed phases to make the report non-empty
from cyclone_pipeline.report import PhaseResult from cyclone_pipeline.report import PhaseResult
p.run_state.completed_phases = [ p.run_state.completed_phases = [
PhaseResult(n=1, name="preflight", status="ok", duration_s=0.4), PhaseResult(n=1, name="preflight", status="ok", duration_s=0.4),
PhaseResult(n=2, name="upload", status="ok", duration_s=2.0), PhaseResult(n=2, name="upload", status="ok", duration_s=2.0),
] ]
result = await p.phase7_scan_and_report() result = await p.phase7_scan_and_report()
assert result.status == "warn" assert result.status == "warn"
# The two report files were written # The two report files were written
run_dir = tmp_path / "runs" / "test-run-007" run_dir = tmp_path / "runs" / "test-run-007"
@@ -3562,7 +3605,9 @@ Append to `cyclone_pipeline/pipeline.py`:
duration_s=sum( duration_s=sum(
p.duration_s for p in self.run_state.completed_phases p.duration_s for p in self.run_state.completed_phases
), ),
phases=list(self.run_state.completed_phases), phases=self._phase_records_to_results(
self.run_state.completed_phases
),
expected_835_by=expected_835, expected_835_by=expected_835,
next_steps={ next_steps={
"check_835_cmd": ( "check_835_cmd": (
@@ -3647,6 +3692,18 @@ Append to `cyclone_pipeline/pipeline.py`:
# --- helpers --------------------------------------------------------------- # --- helpers ---------------------------------------------------------------
def _phase_records_to_results(
records: Sequence[PhaseRecord],
) -> list[PhaseResult]:
"""Convert PhaseRecord (state.py) → PhaseResult (report.py).
Both models have the same fields, but pydantic v2 doesn't
auto-coerce between distinct model classes, so we go via
`model_dump()`. Called when building the final RunReport.
"""
return [PhaseResult(**r.model_dump()) for r in records]
def _next_monday_iso() -> str: def _next_monday_iso() -> str:
"""Return YYYY-MM-DD of the next expected 835 arrival. """Return YYYY-MM-DD of the next expected 835 arrival.
Computed from today in Mountain Time. If today is Monday before Computed from today in Mountain Time. If today is Monday before
@@ -3705,62 +3762,65 @@ async def test_resume_skips_completed_phases(tmp_path: Path):
browser_base="http://127.0.0.1:5173", browser_base="http://127.0.0.1:5173",
run_dir=tmp_path / "runs", run_dir=tmp_path / "runs",
) )
p = CyclonePipeline(cfg, input_path=tmp_path / "x.edi") async with CyclonePipeline(cfg, input_path=tmp_path / "x.edi") as p:
p._run_id = "resume-run-001" p._run_id = "resume-run-001"
run_dir = tmp_path / "runs" / "resume-run-001" run_dir = tmp_path / "runs" / "resume-run-001"
run_dir.mkdir(parents=True, exist_ok=True) run_dir.mkdir(parents=True, exist_ok=True)
# Write a state file with phases 1, 2, 3 done # Write a state file with phases 1, 2, 3 done
from cyclone_pipeline.report import PhaseResult from cyclone_pipeline.report import PhaseResult
p.run_state.completed_phases = [ p.run_state.completed_phases = [
PhaseResult(n=1, name="preflight", status="ok", duration_s=0.4), PhaseResult(n=1, name="preflight", status="ok", duration_s=0.4),
PhaseResult(n=2, name="upload", status="ok", duration_s=2.0), PhaseResult(n=2, name="upload", status="ok", duration_s=2.0),
PhaseResult(n=3, name="verify_parse", status="ok", duration_s=0.8, PhaseResult(n=3, name="verify_parse", status="ok", duration_s=0.8,
detail={"claim_ids": ["CLM-1"]}), detail={"claim_ids": ["CLM-1"]}),
] ]
p.run_state.write(run_dir / "run.state.json") p.run_state.write(run_dir / "run.state.json")
p.run_state.pending_data["claim_ids"] = ["CLM-1"] p.run_state.pending_data["claim_ids"] = ["CLM-1"]
# Stub out phase 4 — just confirm it gets called # Stub out phase 4 — just confirm it gets called
called = {"phase4": False} called = {"phase4": False}
async def fake_phase4(): async def fake_phase4():
called["phase4"] = True called["phase4"] = True
return PhaseResult(n=4, name="submit", status="ok", duration_s=1.0) result = PhaseResult(n=4, name="submit", status="ok", duration_s=1.0)
p.phase4_submit = fake_phase4 # type: ignore[assignment] p.run_state.completed_phases.append(result)
# Stub out phases 5, 6, 7 to short-circuit return result
p.phase5_wait_ta1 = AsyncMock(return_value=PhaseResult( # type: ignore[assignment] p.phase4_submit = fake_phase4 # type: ignore[assignment]
n=5, name="wait_ta1", status="ok", duration_s=0.1
))
p.phase6_wait_999 = AsyncMock(return_value=PhaseResult( # type: ignore[assignment]
n=6, name="wait_999", status="ok", duration_s=0.1
))
p.phase7_scan_and_report = AsyncMock(return_value=PhaseResult( # type: ignore[assignment]
n=7, name="scan_and_report", status="ok", duration_s=0.1
))
# Mock the API responses needed for phases 4-7 def _make_stub(n: int, name: str):
respx.post("http://127.0.0.1:8000/api/clearhouse/submit").mock( """Stub factory: appends the result to completed_phases so
return_value=Response(200, json={ resume() sees them in the final report."""
"submission_id": "SUB-42", async def stub():
"filename": "x.txt", "claim_count": 1, result = PhaseResult(n=n, name=name, status="ok", duration_s=0.1)
}) p.run_state.completed_phases.append(result)
) return result
respx.get("http://127.0.0.1:8000/api/ta1-acks").mock( return stub
return_value=Response(200, json=[{ p.phase5_wait_ta1 = _make_stub(5, "wait_ta1") # type: ignore[assignment]
"id": "TA1-1", "isa13": "1", "accepted": True, p.phase6_wait_999 = _make_stub(6, "wait_999") # type: ignore[assignment]
"received_at": "2026-06-21T15:30:00Z", p.phase7_scan_and_report = _make_stub(7, "scan_and_report") # type: ignore[assignment]
}])
) # Mock the API responses needed for phases 4-7
respx.get("http://127.0.0.1:8000/api/acks").mock( respx.post("http://127.0.0.1:8000/api/clearhouse/submit").mock(
return_value=Response(200, json=[{ return_value=Response(200, json={
"id": "999-1", "status": "A", "submission_id": "SUB-42",
"original_filename": "x.txt", "filename": "x.txt", "claim_count": 1,
"received_at": "2026-06-21T15:30:00Z", })
}]) )
) respx.get("http://127.0.0.1:8000/api/ta1-acks").mock(
respx.get("http://127.0.0.1:8000/api/admin/scheduler/processed-files").mock( return_value=Response(200, json=[{
return_value=Response(200, json=[]) "id": "TA1-1", "isa13": "1", "accepted": True,
) "received_at": "2026-06-21T15:30:00Z",
}])
)
respx.get("http://127.0.0.1:8000/api/acks").mock(
return_value=Response(200, json=[{
"id": "999-1", "status": "A",
"original_filename": "x.txt",
"received_at": "2026-06-21T15:30:00Z",
}])
)
respx.get("http://127.0.0.1:8000/api/admin/scheduler/processed-files").mock(
return_value=Response(200, json=[])
)
async with p:
report = await p.resume("resume-run-001") report = await p.resume("resume-run-001")
assert called["phase4"] is True assert called["phase4"] is True
assert len(report.phases) >= 4 assert len(report.phases) >= 4
@@ -4111,7 +4171,7 @@ def _run_dir_default() -> Path:
return Path.cwd() / "runs" return Path.cwd() / "runs"
@click.group() @click.group(context_settings={"allow_interspersed_args": True})
@click.option( @click.option(
"--api-base", default="http://127.0.0.1:8000", "--api-base", default="http://127.0.0.1:8000",
envvar="CYCLONE_API_BASE", envvar="CYCLONE_API_BASE",
@@ -0,0 +1,343 @@
# Drop `UNIQUE(batch_id, patient_control_number)` on Claims + Robust 409 UX
**Date:** 2026-06-21
**Branch:** `main`
**Status:** Draft (brainstorming approved, awaiting writing-plans)
**Scope:** Backend schema + minimal frontend error handling for collision 409.
---
## 1. Why this exists
Today, every multi-claim 837P file in `docs/prodfiles/837p-from-axiscare/` and
`docs/prodfiles/FromHPE/` returns **HTTP 409** on upload. The cause:
* The `claims` table has `UNIQUE(batch_id, patient_control_number)` declared
inline in `CREATE TABLE` (auto-index `sqlite_autoindex_claims_2`).
* `store._claim_837_row` populates `patient_control_number` from
`claim.subscriber.member_id` (the subscriber's insurance member id),
not from the CLM01 segment value.
* A real 837P submission routinely contains many `CLM*` segments per
subscriber (a member seeing multiple providers on the same day). All
those rows share the same `member_id` → same `patient_control_number`.
Within one batch, the constraint fires on claim #2.
Migration `0003_drop_claims_remits_unique_constraints.sql` already exists
with the right intent but is **buggy**: it does
`DROP INDEX IF EXISTS uq_claims_batch_pcn`, but the constraint is inline,
not a named index — so the `DROP INDEX` is a no-op and the constraint
survives.
The 409 error message ("duplicate CLM01 control numbers") is also
misleading because the column stores `member_id`, not CLM01.
This SP fixes both: drops the constraint properly via SQLite table
recreation, and gives the upload page a structured error panel for the
collision case so the operator can find the existing batch in one click.
---
## 2. Operator surface
| Surface | Change |
|---|---|
| DB | New migration `0013_drop_claims_unique_constraint.sql`; idempotent. |
| Python | `store.find_existing_batch_for_claim(claim_id)` new helper. |
| API | `POST /api/parse-837` and `/api/parse-835` 409 responses gain `existing_batch_id`. |
| UI | `/upload` page renders an inline error panel for 409 with a link to the existing batch. |
| Tests | New migration test, store helper test, API test, component test. |
No CLI / settings changes.
---
## 3. Schema migration
`backend/src/cyclone/migrations/0013_drop_claims_unique_constraint.sql`:
```sql
-- version: 13
-- Drop the inline UNIQUE(batch_id, patient_control_number) on claims.
-- Migration 0003 attempted DROP INDEX IF EXISTS uq_claims_batch_pcn but
-- the constraint is inline in CREATE TABLE, so the drop was a no-op.
-- The only way to remove an inline UNIQUE in SQLite is table recreation.
--
-- X12 837P allows any number of CLM segments per 2000B subscriber loop;
-- claim identity is provided by the primary key (claims.id = CLM01).
-- The remittances table had a parallel constraint already removed in 0003
-- (because that one WAS a named index), so this migration only touches
-- claims.
PRAGMA foreign_keys=OFF;
BEGIN;
CREATE TABLE claims_new (
id TEXT PRIMARY KEY,
batch_id TEXT NOT NULL REFERENCES batches(id) ON DELETE CASCADE,
patient_control_number TEXT NOT NULL,
service_date_from DATE,
service_date_to DATE,
charge_amount NUMERIC(12, 2) NOT NULL DEFAULT 0,
provider_npi TEXT,
payer_id TEXT,
state TEXT NOT NULL DEFAULT 'submitted',
state_before_reversal TEXT,
matched_remittance_id TEXT REFERENCES remittances(id),
raw_json TEXT,
rejection_reason TEXT,
rejected_at TIMESTAMP,
resubmit_count INTEGER NOT NULL DEFAULT 0,
state_changed_at TIMESTAMP,
payer_rejected_at TEXT,
payer_rejected_reason TEXT,
payer_rejected_status_code TEXT,
payer_rejected_by_277ca_id TEXT,
payer_rejected_acknowledged_at TEXT,
payer_rejected_acknowledged_actor TEXT
-- NO UNIQUE (batch_id, patient_control_number) — removed.
);
INSERT INTO claims_new SELECT * FROM claims;
DROP TABLE claims;
ALTER TABLE claims_new RENAME TO claims;
-- Recreate secondary indexes (same names, same columns as initial schema
-- plus later migrations).
CREATE INDEX ix_claims_state ON claims(state);
CREATE INDEX ix_claims_patient_control_number ON claims(patient_control_number);
CREATE INDEX ix_claims_service_date_from ON claims(service_date_from);
CREATE INDEX ix_claims_state_changed_at ON claims(state, state_changed_at);
CREATE INDEX idx_claims_payer_rejected_at ON claims(payer_rejected_at);
CREATE INDEX idx_claims_payer_rejected_unack
ON claims(payer_rejected_at)
WHERE payer_rejected_acknowledged_at IS NULL;
COMMIT;
PRAGMA foreign_keys=ON;
```
**Note on the `db.py` ORM model:** `backend/src/cyclone/db.py` declares
the `Claim` ORM model with `UNIQUE(batch_id, patient_control_number)` in
`__table_args__`. After this migration the DB no longer enforces that
constraint, so the ORM declaration becomes aspirational. We leave it in
place as documentation (and as a guard if the DB ever gets rebuilt from
ORM on a fresh schema). No code reads through it; the dedup happens via
PK on `claims.id` in `store.add`.
---
## 4. Store helper
New function in `backend/src/cyclone/store.py`:
```python
def find_existing_batch_for_claim(claim_id: str) -> str | None:
"""Return the batch_id of the first batch containing this CLM01, or None."""
from cyclone import db
from cyclone.db import Claim
with db.SessionLocal()() as s:
row = s.execute(
select(Claim.batch_id).where(Claim.id == claim_id).limit(1)
).first()
return row[0] if row else None
def find_existing_batch_for_remit(payer_claim_control_number: str) -> str | None:
"""Return the batch_id of the first batch containing this CLP01, or None."""
from cyclone import db
from cyclone.db import Remittance
with db.SessionLocal()() as s:
row = s.execute(
select(Remittance.batch_id)
.where(Remittance.id == payer_claim_control_number)
.limit(1)
).first()
return row[0] if row else None
```
Both pure reads; no transaction management needed.
---
## 5. API change
`backend/src/cyclone/api.py`:
### 837 path (line 394-415)
```python
except IntegrityError as exc:
existing_batch_id = store.find_existing_batch_for_claim(...)
body = {
"error": "Duplicate claim",
"detail": "...",
"batch_id": rec.id,
}
if existing_batch_id:
body["existing_batch_id"] = existing_batch_id
log.warning("Duplicate claim while persisting batch %s: %s", rec.id, exc)
return JSONResponse(status_code=409, content=body)
```
The `...` argument is the first `claim.claim_id` from `result.claims`
where the collision occurred. We pick the first one because the DB raises
on the second insert; iterating through the parser's claim list to find
which CLM01 already existed is cheap.
### 835 path (line 588-602)
Same pattern with `find_existing_batch_for_remit` and the existing remit's
`payer_claim_control_number`.
---
## 6. Frontend change
### `src/lib/api.ts`
`ApiError` carries an optional `existingBatchId`:
```typescript
export class ApiError extends Error {
constructor(
public status: number,
message: string,
public existingBatchId: string | null = null,
) {
super(message);
}
}
```
`readErrorBody()` parses JSON and, when status ≥ 400, attempts to extract
`existing_batch_id` and pass it through. `parse837`/`parse835` throw
`new ApiError(res.status, detail, existingBatchId)`.
### `src/pages/Upload.tsx`
New local state:
```typescript
type UploadError = {
kind: "duplicate";
existingBatchId: string | null;
filename: string;
};
const [uploadError, setUploadError] = useState<UploadError | null>(null);
```
On mutation error:
```typescript
} catch (err) {
if (err instanceof ApiError && err.status === 409) {
setUploadError({
kind: "duplicate",
existingBatchId: err.existingBatchId,
filename: file.name,
});
toast.error("Duplicate claim — file not ingested");
} else {
toast.error(err instanceof Error ? err.message : "Failed to parse file");
}
}
```
Inline error panel JSX (renders above streaming results when
`uploadError` is set):
```tsx
{uploadError ? (
<div className="error-panel">
<Badge variant="destructive">409</Badge>
<div className="error-title">Duplicate claim — file not ingested</div>
<div className="error-detail">
{filename} collides with an existing record.
{existingBatchId
? " Open the existing batch to compare, or pick a different file."
: " Pick a different file."}
</div>
<div className="error-actions">
{existingBatchId ? (
<Button onClick={() => navigate(`/batches/${existingBatchId}`)}>
Open existing batch →
</Button>
) : null}
<Button variant="ghost" onClick={() => { pickFile(null); }}>
Pick a different file
</Button>
</div>
</div>
) : null}
```
Styling matches the existing paper-toned surface (slate/parchment) per
the hybrid dark/paper treatment used elsewhere in the app.
---
## 7. Files changed
* `backend/src/cyclone/migrations/0013_drop_claims_unique_constraint.sql` — new
* `backend/src/cyclone/store.py``find_existing_batch_for_claim`,
`find_existing_batch_for_remit`
* `backend/src/cyclone/api.py` — both 409 handlers add
`existing_batch_id` lookup
* `src/lib/api.ts``ApiError.existingBatchId`
* `src/pages/Upload.tsx` — error state + inline panel
* `src/pages/Upload.test.tsx` — new test file
* `backend/tests/test_api_parse_persists.py` — new test cases
* `backend/tests/test_db_migrate.py` — new migration test
* `backend/tests/test_store.py` — new helper tests
No new dependencies. No config changes.
---
## 8. Out of scope
* A "Replace existing batch" destructive action — requires
`DELETE /api/batches/{id}` and reconciliation cascade handling; deferred.
* General 4xx error UI for other statuses (empty file, parse error,
validation errors). Those already surface in toasts and the streaming
view; a future SP can generalize the inline panel pattern.
* Renaming `patient_control_number` to `subscriber_member_id` to match
what it actually stores. Out of scope for this fix; tracked separately
if it becomes a source of confusion.
---
## 9. Risk
* **Migration irreversibility**: SQLite has no `DROP CONSTRAINT`; the
recreation is destructive to schema (but not to data — `INSERT INTO
claims_new SELECT * FROM claims` preserves every row). If the
migration fails mid-way, the transaction rolls back. The
`PRAGMA foreign_keys=OFF` block is required because SQLite otherwise
can't drop and rename a table that other tables reference.
* **Loss of uniqueness**: after the migration, two claims in one batch
*can* share a `patient_control_number`. This is the intended behavior.
Claim identity is still unique via `claims.id` (CLM01, PK) and the
existing dedup check in `store.add` (`s.get(Claim, claim.claim_id)`).
* **`existing_batch_id` race**: the helper runs after the failed
`store.add` transaction has rolled back. Between rollback and helper
call, another writer could delete the colliding claim. Result: 409
fires with no `existing_batch_id`; UI shows panel without link.
Acceptable — the panel still explains the collision and offers
"Pick a different file."
---
## 10. Test plan
| Test | Asserts |
|---|---|
| `test_db_migrate.py::test_drop_claims_unique_constraint` | After running migrations from v12, `user_version=13`, no `*claims*unique*` index exists, two rows with same `(batch_id, patient_control_number)` insert cleanly. |
| `test_db_migrate.py::test_migration_idempotent` | Running migrations on a v13 DB is a no-op. |
| `test_store.py::test_find_existing_batch_for_claim` | Helper returns None for unknown, returns batch_id for known, deterministic on duplicates. |
| `test_api_parse_persists.py::test_409_response_includes_existing_batch_id` | Upload duplicate; assert body has `existing_batch_id` pointing to the right batch. |
| `test_api_parse_persists.py::test_multi_claim_batch_with_duplicate_member_id_succeeds` | Upload a file with duplicate `member_id` claims; assert 200, all claims persisted. |
| `Upload.test.tsx::test_error_panel_renders_on_409_with_link` | Mock `useParse` to throw `ApiError(409, ..., existingBatchId)`; assert panel visible, link present. |
| `Upload.test.tsx::test_error_panel_renders_on_409_without_link` | Mock 409 with `existingBatchId: null`; assert panel visible, no link. |
| `Upload.test.tsx::test_no_panel_on_non_409` | Mock 400; assert panel absent, only toast. |
| `Upload.test.tsx::test_pick_different_clears_error` | Click button; assert `pickFile(null)` called and `errorState` cleared. |
+101 -2
View File
@@ -1,11 +1,15 @@
// @vitest-environment happy-dom // @vitest-environment happy-dom
(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true; (globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
import { describe, expect, it } from "vitest"; import { afterEach, describe, expect, it, vi } from "vitest";
import { render, screen } from "@testing-library/react"; import { cleanup, fireEvent, render, screen } from "@testing-library/react";
import { ActivityFeed } from "./ActivityFeed"; import { ActivityFeed } from "./ActivityFeed";
import type { Activity } from "@/types"; import type { Activity } from "@/types";
// happy-dom keeps `document.body` between tests; without cleanup,
// `screen.getByRole("button")` finds buttons from earlier renders.
afterEach(() => cleanup());
const baseActivity: Activity = { const baseActivity: Activity = {
id: "a-1", id: "a-1",
kind: "claim_submitted", kind: "claim_submitted",
@@ -47,4 +51,99 @@ describe("ActivityFeed", () => {
expect(() => render(<ActivityFeed items={[unknown]} />)).not.toThrow(); expect(() => render(<ActivityFeed items={[unknown]} />)).not.toThrow();
expect(screen.getByText("future_kind event arrived")).toBeTruthy(); expect(screen.getByText("future_kind event arrived")).toBeTruthy();
}); });
// -------------------------------------------------------------------
// SP21 Task 2.5: optional `onItemClick` prop makes each row a
// drillable target. Default behavior (no handler) must stay unchanged.
// -------------------------------------------------------------------
it("does not attach row-level click attrs when onItemClick is omitted", () => {
render(<ActivityFeed items={[baseActivity]} />);
const li = screen.getByRole("listitem");
expect(li.getAttribute("role")).not.toBe("button");
expect(li.getAttribute("tabindex")).toBeNull();
expect(li.classList.contains("drillable")).toBe(false);
});
it("attaches role/tabIndex/drillable class when onItemClick is provided", () => {
render(
<ActivityFeed
items={[baseActivity]}
onItemClick={() => {}}
/>,
);
const li = screen.getByRole("button", { name: /View claim submitted/ });
expect(li.tagName).toBe("LI");
expect(li.getAttribute("tabindex")).toBe("0");
expect(li.classList.contains("drillable")).toBe(true);
});
it("calls onItemClick with the event on click", () => {
const onItemClick = vi.fn();
render(
<ActivityFeed
items={[baseActivity]}
onItemClick={onItemClick}
/>,
);
const li = screen.getByRole("button");
fireEvent.click(li);
expect(onItemClick).toHaveBeenCalledTimes(1);
expect(onItemClick).toHaveBeenCalledWith(baseActivity);
});
it("calls onItemClick on Enter keydown", () => {
const onItemClick = vi.fn();
render(
<ActivityFeed
items={[baseActivity]}
onItemClick={onItemClick}
/>,
);
const li = screen.getByRole("button");
fireEvent.keyDown(li, { key: "Enter" });
expect(onItemClick).toHaveBeenCalledTimes(1);
expect(onItemClick).toHaveBeenCalledWith(baseActivity);
});
it("calls onItemClick on Space keydown", () => {
const onItemClick = vi.fn();
render(
<ActivityFeed
items={[baseActivity]}
onItemClick={onItemClick}
/>,
);
fireEvent.keyDown(screen.getByRole("button"), { key: " " });
expect(onItemClick).toHaveBeenCalledTimes(1);
});
it("does not call onItemClick for unrelated keys", () => {
const onItemClick = vi.fn();
render(
<ActivityFeed
items={[baseActivity]}
onItemClick={onItemClick}
/>,
);
fireEvent.keyDown(screen.getByRole("button"), { key: "a" });
expect(onItemClick).not.toHaveBeenCalled();
});
// Regression for the Task 2.4 event-bubbling pattern: clicks on a
// drillable row must not bubble to a parent row click. Without
// stopPropagation a Dashboard parent handler could fire alongside
// the row click and corrupt history.
it("stops click propagation so a parent row handler does not also fire", () => {
const onItemClick = vi.fn();
const parentClick = vi.fn();
render(
<ul onClick={parentClick}>
<ActivityFeed items={[baseActivity]} onItemClick={onItemClick} />
</ul>,
);
fireEvent.click(screen.getByRole("button"));
expect(onItemClick).toHaveBeenCalledTimes(1);
expect(parentClick).not.toHaveBeenCalled();
});
}); });
+43 -4
View File
@@ -1,3 +1,4 @@
import type { KeyboardEvent, MouseEvent } from "react";
import { import {
Banknote, Banknote,
CheckCircle2, CheckCircle2,
@@ -63,9 +64,22 @@ const FALLBACK_KIND: { icon: LucideIcon; tone: string; tint: string } = {
export function ActivityFeed({ export function ActivityFeed({
items, items,
emptyMessage = "No activity yet.", emptyMessage = "No activity yet.",
onItemClick,
}: { }: {
items: Activity[]; items: Activity[];
emptyMessage?: string; emptyMessage?: string;
/**
* Optional click handler for SP21 Universal Drill-Down (Task 2.5).
* When provided, each row becomes a clickable target: the row's
* outer `<li>` gets `role="button"`, `tabIndex`, the `drillable`
* hover affordance (chevron + tint), and an Enter/Space keybinding.
*
* `e.stopPropagation()` is called before invoking the handler so the
* click doesn't bubble to a hypothetical parent row click same
* fix that landed on `DrillableCell` in Task 2.4. When omitted, the
* feed renders exactly as before (no extra DOM, no extra attrs).
*/
onItemClick?: (event: Activity) => void;
}) { }) {
if (items.length === 0) { if (items.length === 0) {
return ( return (
@@ -79,11 +93,36 @@ export function ActivityFeed({
{items.map((a) => { {items.map((a) => {
const cfg = kindConfig[a.kind] ?? FALLBACK_KIND; const cfg = kindConfig[a.kind] ?? FALLBACK_KIND;
const Icon = cfg.icon; const Icon = cfg.icon;
// SP21 Task 2.5: when a click handler is wired, the row
// becomes a keyboard-focusable button-like element with the
// drillable hover affordance. We attach the handler to the
// <li> directly (matching the Dashboard's existing patterns
// for "Top providers" / "Recent denials" rows) so the click
// target covers the full row width including padding.
const rowProps = onItemClick
? {
role: "button" as const,
tabIndex: 0,
"aria-label": `View ${a.kind.replace(/_/g, " ")}: ${a.message}`,
className:
"drillable flex items-start gap-3 py-3 first:pt-0 last:pb-0 rounded-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-1",
onClick: (e: MouseEvent<HTMLLIElement>) => {
e.stopPropagation();
onItemClick(a);
},
onKeyDown: (e: KeyboardEvent<HTMLLIElement>) => {
if (e.key === "Enter" || e.key === " ") {
e.preventDefault();
e.stopPropagation();
onItemClick(a);
}
},
}
: {
className: "flex items-start gap-3 py-3 first:pt-0 last:pb-0",
};
return ( return (
<li <li key={a.id} {...rowProps}>
key={a.id}
className="flex items-start gap-3 py-3 first:pt-0 last:pb-0"
>
<div <div
className={cn( className={cn(
"mt-0.5 h-7 w-7 shrink-0 rounded-md ring-1 ring-inset ring-border/40 flex items-center justify-center", "mt-0.5 h-7 w-7 shrink-0 rounded-md ring-1 ring-inset ring-border/40 flex items-center justify-center",
+245 -35
View File
@@ -1,4 +1,10 @@
import { Plus, Minus, Equal, ArrowRight, type LucideIcon } from "lucide-react"; import {
ArrowRight,
Equal,
Minus,
Plus,
type LucideIcon,
} from "lucide-react";
import { Badge } from "@/components/ui/badge"; import { Badge } from "@/components/ui/badge";
import { Skeleton } from "@/components/ui/skeleton"; import { Skeleton } from "@/components/ui/skeleton";
import { import {
@@ -9,19 +15,20 @@ import {
TableHeader, TableHeader,
TableRow, TableRow,
} from "@/components/ui/table"; } from "@/components/ui/table";
import { KpiCard } from "@/components/KpiCard";
import { fmt } from "@/lib/format"; import { fmt } from "@/lib/format";
import { cn } from "@/lib/utils"; import { cn } from "@/lib/utils";
import type { import type {
BatchClaimDiffSummary,
BatchDiff, BatchDiff,
BatchDiffChangedRow, BatchDiffChangedRow,
BatchDiffSideMeta, BatchDiffSideMeta,
BatchDiffSummary, BatchDiffSummary,
BatchClaimDiffSummary,
} from "@/types"; } from "@/types";
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Side meta header — small panel identifying which batch is on the left / right. // Side meta header — small panel identifying which batch is on the
// left / right. Paper-toned to sit inside the cream "paper plane" of
// the BatchDiff page. data-testid pinned by BatchDiff.test.tsx.
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
function SideMeta({ function SideMeta({
@@ -39,10 +46,19 @@ function SideMeta({
: "text-amber-300 border-amber-400/30 bg-amber-400/10"; : "text-amber-300 border-amber-400/30 bg-amber-400/10";
return ( return (
<div <div
className="surface rounded-xl p-4 flex flex-col gap-2" className="rounded-xl p-4 flex flex-col gap-2 border"
data-testid={`batch-diff-side-${label.toLowerCase()}`} data-testid={`batch-diff-side-${label.toLowerCase()}`}
style={{
backgroundColor: "hsl(36 22% 98%)",
borderColor: "hsl(30 14% 14% / 0.10)",
boxShadow:
"inset 0 1px 0 0 hsl(0 0% 100% / 0.45), 0 1px 0 0 hsl(30 14% 22% / 0.06)",
}}
> >
<div className="text-[10.5px] font-semibold uppercase tracking-[0.18em] text-muted-foreground"> <div
className="text-[10.5px] font-semibold uppercase tracking-[0.18em]"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
{label} {label}
</div> </div>
<div className="flex items-center gap-2"> <div className="flex items-center gap-2">
@@ -54,12 +70,23 @@ function SideMeta({
> >
{side.kind} {side.kind}
</span> </span>
<span className="display num text-[13px]">{side.id}</span> <span
className="display num text-[13px]"
style={{ color: "hsl(var(--surface-ink))" }}
>
{side.id}
</span>
</div> </div>
<div className="font-mono text-[12px] text-muted-foreground truncate"> <div
className="font-mono text-[12px] truncate"
style={{ color: "hsl(var(--surface-ink-2))" }}
>
{side.inputFilename} {side.inputFilename}
</div> </div>
<div className="flex items-center justify-between text-xs text-muted-foreground"> <div
className="flex items-center justify-between text-xs"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
<span>Parsed {side.parsedAt ? fmt.dateShort(side.parsedAt) : "—"}</span> <span>Parsed {side.parsedAt ? fmt.dateShort(side.parsedAt) : "—"}</span>
<span className="font-mono num"> <span className="font-mono num">
{fmt.num(side.claimCount)} claim{side.claimCount === 1 ? "" : "s"} {fmt.num(side.claimCount)} claim{side.claimCount === 1 ? "" : "s"}
@@ -70,40 +97,125 @@ function SideMeta({
} }
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Summary cards — the four-count tile row. // Summary cards — the four-count tile row. Paper-toned via
// DiffKpiTile so the counts sit naturally on the cream paper plane.
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
function SummaryCards({ summary }: { summary: BatchDiffSummary }) { function SummaryCards({ summary }: { summary: BatchDiffSummary }) {
return ( return (
<div className="grid grid-cols-2 md:grid-cols-4 gap-3" data-testid="batch-diff-summary"> <div
<KpiCard className="grid grid-cols-2 md:grid-cols-4 gap-3"
data-testid="batch-diff-summary"
>
<DiffKpiTile
label="Added in B" label="Added in B"
value={fmt.num(summary.addedCount)} value={fmt.num(summary.addedCount)}
icon={Plus} icon={Plus}
hint="In B, not in A" hint="In B, not in A"
tone="success"
/> />
<KpiCard <DiffKpiTile
label="Removed from A" label="Removed from A"
value={fmt.num(summary.removedCount)} value={fmt.num(summary.removedCount)}
icon={Minus} icon={Minus}
hint="In A, not in B" hint="In A, not in B"
tone="destructive"
/> />
<KpiCard <DiffKpiTile
label="Changed" label="Changed"
value={fmt.num(summary.changedCount)} value={fmt.num(summary.changedCount)}
icon={Equal} icon={Equal}
hint="Deltas in either side" hint="Deltas in either side"
tone="amber"
/> />
<KpiCard <DiffKpiTile
label="Unchanged" label="Unchanged"
value={fmt.num(summary.unchangedCount)} value={fmt.num(summary.unchangedCount)}
icon={Equal} icon={Equal}
hint="Identical across A & B" hint="Identical across A & B"
tone="ink"
/> />
</div> </div>
); );
} }
// ---------------------------------------------------------------------------
// DiffKpiTile — paper-toned metric tile for the diff summary row.
// Mirrors AckKpiTile / BatchesKpiTile from the other hybrid pages.
// ---------------------------------------------------------------------------
function DiffKpiTile({
label,
value,
icon: Icon,
hint,
tone,
}: {
label: string;
value: string;
icon: LucideIcon;
hint: string;
tone: "success" | "destructive" | "amber" | "ink";
}) {
const accentMap = {
success: "hsl(152 64% 38%)",
destructive: "hsl(358 70% 42%)",
amber: "hsl(36 92% 50%)",
ink: "hsl(var(--surface-ink))",
} as const;
const tintMap = {
success: "hsl(152 50% 88%)",
destructive: "hsl(358 70% 92%)",
amber: "hsl(36 82% 92%)",
ink: "hsl(36 22% 90%)",
} as const;
const accent = accentMap[tone];
const tint = tintMap[tone];
return (
<div
className="relative rounded-xl p-4 overflow-hidden border"
title={hint}
style={{
backgroundColor: "hsl(var(--surface))",
boxShadow:
"inset 0 1px 0 0 hsl(0 0% 100% / 0.45), 0 1px 0 0 hsl(30 14% 22% / 0.06), inset 3px 0 0 0 hsl(0 0% 100% / 0.4)",
borderColor: "hsl(30 14% 14% / 0.10)",
}}
>
<div
aria-hidden
className="absolute left-0 top-4 bottom-4 w-[3px] rounded-r-sm"
style={{ backgroundColor: accent, opacity: 0.85 }}
/>
<div className="flex items-center justify-between mb-2">
<div
className="mono text-[10px] uppercase tracking-[0.18em] font-semibold"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
{label}
</div>
<div
className="h-5 w-5 rounded-md flex items-center justify-center"
style={{ backgroundColor: tint, color: accent }}
>
<Icon className="h-3 w-3" strokeWidth={1.75} />
</div>
</div>
<div
className="display tabular-nums tracking-[-0.04em]"
style={{
color: "hsl(var(--surface-ink))",
fontSize: "clamp(26px, 2.8vw, 36px)",
lineHeight: 1,
fontWeight: 400,
}}
>
{value}
</div>
</div>
);
}
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Row indicator — `+` / `-` / `~` gutter on the left of every row. // Row indicator — `+` / `-` / `~` gutter on the left of every row.
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
@@ -152,7 +264,10 @@ function RowIndicator({
function ClaimIdCell({ id }: { id: string }) { function ClaimIdCell({ id }: { id: string }) {
return ( return (
<span className="font-mono text-[12px] tracking-tight" data-testid="diff-claim-id"> <span
className="font-mono text-[12px] tracking-tight"
data-testid="diff-claim-id"
>
{id} {id}
</span> </span>
); );
@@ -160,14 +275,31 @@ function ClaimIdCell({ id }: { id: string }) {
function PatientCell({ name }: { name: string }) { function PatientCell({ name }: { name: string }) {
if (!name) { if (!name) {
return <span className="text-muted-foreground/60 text-[12px]"></span>; return (
<span
className="text-[12px]"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
</span>
);
} }
return <span className="text-[13px]">{name}</span>; return (
<span
className="text-[13px]"
style={{ color: "hsl(var(--surface-ink))" }}
>
{name}
</span>
);
} }
function ChargeCell({ value }: { value: number }) { function ChargeCell({ value }: { value: number }) {
return ( return (
<span className="display num text-[13px] tabular-nums"> <span
className="display num text-[13px] tabular-nums"
style={{ color: "hsl(var(--surface-ink))" }}
>
{fmt.usdPrecise(value)} {fmt.usdPrecise(value)}
</span> </span>
); );
@@ -175,19 +307,44 @@ function ChargeCell({ value }: { value: number }) {
function DateCell({ value }: { value: string | null }) { function DateCell({ value }: { value: string | null }) {
if (!value) { if (!value) {
return <span className="text-muted-foreground/60 text-[12px]"></span>; return (
<span
className="text-[12px]"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
</span>
);
} }
return <span className="num text-[12.5px]">{value}</span>; return (
<span
className="num text-[12.5px]"
style={{ color: "hsl(var(--surface-ink-2))" }}
>
{value}
</span>
);
} }
function StatusCell({ value }: { value: string }) { function StatusCell({ value }: { value: string }) {
if (!value) { if (!value) {
return <span className="text-muted-foreground/60 text-[12px]"></span>; return (
<span
className="text-[12px]"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
</span>
);
} }
return ( return (
<Badge <Badge
variant="outline" variant="outline"
className="font-mono uppercase tracking-wider text-[10px]" className="font-mono uppercase tracking-wider text-[10px]"
style={{
color: "hsl(var(--surface-ink))",
borderColor: "hsl(30 14% 14% / 0.20)",
}}
> >
{value} {value}
</Badge> </Badge>
@@ -196,17 +353,28 @@ function StatusCell({ value }: { value: string }) {
function CptCell({ codes }: { codes: string[] }) { function CptCell({ codes }: { codes: string[] }) {
if (!codes || codes.length === 0) { if (!codes || codes.length === 0) {
return <span className="text-muted-foreground/60 text-[12px]"></span>; return (
<span
className="text-[12px]"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
</span>
);
} }
return ( return (
<span className="font-mono text-[11.5px] tracking-tight"> <span
className="font-mono text-[11.5px] tracking-tight"
style={{ color: "hsl(var(--surface-ink-2))" }}
>
{codes.join(", ")} {codes.join(", ")}
</span> </span>
); );
} }
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Section tables — one per bucket (added / removed / changed). // Section tables — one per bucket (added / removed / changed). Uses
// `tone="paper"` so the table chrome matches the cream paper plane.
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
type Side = "a" | "b"; type Side = "a" | "b";
@@ -386,25 +554,53 @@ function SectionTable({
<section className="space-y-3" data-testid={testid}> <section className="space-y-3" data-testid={testid}>
<header className="flex items-baseline justify-between"> <header className="flex items-baseline justify-between">
<div> <div>
<div className="text-[10.5px] font-semibold uppercase tracking-[0.18em] text-muted-foreground mb-0.5"> <div
className="text-[10.5px] font-semibold uppercase tracking-[0.18em] mb-0.5"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
{eyebrow} {eyebrow}
</div> </div>
<h2 className="text-[15px] font-semibold tracking-tight">{title}</h2> <h3
className="display leading-[0.98] tracking-[-0.03em]"
style={{
color: "hsl(var(--surface-ink))",
fontSize: "clamp(20px, 2.2vw, 26px)",
fontWeight: 400,
}}
>
{title}
</h3>
</div> </div>
<span className="font-mono num text-[12.5px] text-muted-foreground"> <span
className="font-mono num text-[12.5px]"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
{fmt.num(count)} {fmt.num(count)}
</span> </span>
</header> </header>
{count === 0 ? ( {count === 0 ? (
<div <div
className="surface rounded-xl border border-dashed border-border/60 p-6 text-center text-[12.5px] text-muted-foreground" className="rounded-xl border p-6 text-center text-[12.5px]"
data-testid={`${testid}-empty`} data-testid={`${testid}-empty`}
style={{
borderColor: "hsl(30 14% 14% / 0.16)",
borderStyle: "dashed",
backgroundColor: "hsl(36 22% 96%)",
color: "hsl(var(--surface-ink-3))",
}}
> >
{emptyMessage} {emptyMessage}
</div> </div>
) : ( ) : (
<div className="surface rounded-xl overflow-hidden"> <div
<Table> className="rounded-xl border overflow-hidden"
style={{
borderColor: "hsl(30 14% 14% / 0.10)",
backgroundColor: "hsl(36 22% 98%)",
boxShadow: "inset 0 1px 0 0 hsl(0 0% 100% / 0.5)",
}}
>
<Table tone="paper">
<TableHeader> <TableHeader>
<TableRow> <TableRow>
<TableHead className="w-10" aria-label="Diff indicator" /> <TableHead className="w-10" aria-label="Diff indicator" />
@@ -425,7 +621,8 @@ function SectionTable({
} }
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Skeleton — used by the page while the diff is loading. // Skeleton — used by the page while the diff is loading. Paper-toned
// (cream blocks) to match the paper plane chrome.
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
export function BatchDiffViewSkeleton() { export function BatchDiffViewSkeleton() {
@@ -462,11 +659,24 @@ export function BatchDiffEmpty({ data }: { data: BatchDiff }) {
<SideMeta side={data.b} label="B (right)" /> <SideMeta side={data.b} label="B (right)" />
</div> </div>
<SummaryCards summary={data.summary} /> <SummaryCards summary={data.summary} />
<div className="surface rounded-xl border border-dashed border-border/60 p-10 text-center"> <div
<div className="text-[10.5px] font-semibold uppercase tracking-[0.18em] text-muted-foreground mb-1.5"> className="rounded-xl border p-10 text-center"
style={{
borderColor: "hsl(30 14% 14% / 0.16)",
borderStyle: "dashed",
backgroundColor: "hsl(36 22% 96%)",
}}
>
<div
className="text-[10.5px] font-semibold uppercase tracking-[0.18em] mb-1.5"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
Diff · no deltas Diff · no deltas
</div> </div>
<div className="text-[13.5px] text-muted-foreground"> <div
className="text-[13.5px]"
style={{ color: "hsl(var(--surface-ink-2))" }}
>
These two batches are identical no claims added, removed, or These two batches are identical no claims added, removed, or
changed between A and B. changed between A and B.
</div> </div>
+63 -10
View File
@@ -20,6 +20,11 @@ import type { BatchSummary } from "@/lib/api";
* *
* Voice mirrors `AckCodeBadge` in `src/pages/Acks.tsx` (uppercase, * Voice mirrors `AckCodeBadge` in `src/pages/Acks.tsx` (uppercase,
* wide tracking, hairline border, low-opacity fill). * wide tracking, hairline border, low-opacity fill).
*
* The literal class names `text-sky-300` and `text-amber-300` are
* pinned by `Batches.test.tsx` as a contract the test asserts the
* badge's text color is one of these two strings. Don't replace them
* with arbitrary HSL values or the test will fail.
*/ */
function KindBadge({ kind }: { kind: BatchSummary["kind"] }) { function KindBadge({ kind }: { kind: BatchSummary["kind"] }) {
const color = const color =
@@ -42,7 +47,8 @@ function KindBadge({ kind }: { kind: BatchSummary["kind"] }) {
/** /**
* Skeleton rows for the batches table. Mirrors the row count used in * Skeleton rows for the batches table. Mirrors the row count used in
* `Acks.tsx` (5 placeholders) so the loading density matches the rest * `Acks.tsx` (5 placeholders) so the loading density matches the rest
* of the app. * of the app. `data-testid="batches-skeleton"` is pinned by
* `Batches.test.tsx`.
*/ */
export function BatchesListSkeleton() { export function BatchesListSkeleton() {
return ( return (
@@ -63,6 +69,13 @@ type BatchesListProps = {
*/ */
openId: string | null; openId: string | null;
onOpen: (id: string) => void; onOpen: (id: string) => void;
/**
* When `paper`, the table sits inside a cream "paper plane" section
* and uses the paper-toned color scheme: warm hover, hairline border
* in surface-line, surface-ink text. When `dark` (default), the
* original dark-mode chrome is used.
*/
tone?: "dark" | "paper";
}; };
/** /**
@@ -71,15 +84,26 @@ type BatchesListProps = {
* so the numbers tick up from 0 on first render (gives the page a * so the numbers tick up from 0 on first render (gives the page a
* little life on load; consistent with the Dashboard KPI cards). * little life on load; consistent with the Dashboard KPI cards).
*/ */
export function BatchesList({ items, openId, onOpen }: BatchesListProps) { export function BatchesList({
items,
openId,
onOpen,
tone = "dark",
}: BatchesListProps) {
const isPaper = tone === "paper";
return ( return (
<Table data-testid="batches-table"> <Table data-testid="batches-table" tone={tone}>
<TableHeader> <TableHeader>
<TableRow> <TableRow>
<TableHead>Kind</TableHead> <TableHead>Kind</TableHead>
<TableHead>Batch</TableHead> <TableHead>Batch</TableHead>
<TableHead>Input file</TableHead> <TableHead>Input file</TableHead>
<TableHead className="text-right">Claims</TableHead> <TableHead
className="text-right"
style={isPaper ? { color: "hsl(var(--surface-ink-2))" } : undefined}
>
Claims
</TableHead>
<TableHead>Parsed</TableHead> <TableHead>Parsed</TableHead>
<TableHead className="w-6" aria-label="Open" /> <TableHead className="w-6" aria-label="Open" />
</TableRow> </TableRow>
@@ -93,28 +117,57 @@ export function BatchesList({ items, openId, onOpen }: BatchesListProps) {
data-open={openId === b.id ? "true" : undefined} data-open={openId === b.id ? "true" : undefined}
className={cn( className={cn(
"animate-row-flash cursor-pointer", "animate-row-flash cursor-pointer",
openId === b.id && "bg-muted/40", isPaper && openId === b.id &&
"!bg-[hsl(212_85%_95%)] ring-1 ring-inset ring-[hsl(212_100%_45%_/_0.30)]",
!isPaper && openId === b.id && "bg-muted/40",
)} )}
> >
<TableCell> <TableCell>
<KindBadge kind={b.kind} /> <KindBadge kind={b.kind} />
</TableCell> </TableCell>
<TableCell className="display num text-[13px]"> <TableCell
className="display num text-[13px]"
style={isPaper ? { color: "hsl(var(--surface-ink))" } : undefined}
>
{b.id} {b.id}
</TableCell> </TableCell>
<TableCell className="font-mono text-[12px] text-muted-foreground truncate max-w-[280px]"> <TableCell
className={cn(
"font-mono text-[12px] truncate max-w-[280px]",
isPaper
? "text-[hsl(var(--surface-ink-2))]"
: "text-muted-foreground",
)}
>
{b.inputFilename} {b.inputFilename}
</TableCell> </TableCell>
<TableCell className="text-right display num text-[13px]"> <TableCell
className="text-right display num text-[13px]"
style={isPaper ? { color: "hsl(var(--surface-ink))" } : undefined}
>
<AnimatedNumber <AnimatedNumber
value={b.claimCount} value={b.claimCount}
format={(n) => fmt.num(Math.round(n))} format={(n) => fmt.num(Math.round(n))}
/> />
</TableCell> </TableCell>
<TableCell className="text-muted-foreground num text-[12.5px]"> <TableCell
className={cn(
"num text-[12.5px]",
isPaper
? "text-[hsl(var(--surface-ink-3))]"
: "text-muted-foreground",
)}
>
{b.parsedAt ? fmt.dateShort(b.parsedAt) : "—"} {b.parsedAt ? fmt.dateShort(b.parsedAt) : "—"}
</TableCell> </TableCell>
<TableCell className="text-muted-foreground text-right"> <TableCell
className={cn(
"text-right",
isPaper
? "text-[hsl(var(--surface-ink-3))]"
: "text-muted-foreground",
)}
>
<span aria-hidden></span> <span aria-hidden></span>
</TableCell> </TableCell>
</TableRow> </TableRow>
@@ -0,0 +1,196 @@
// @vitest-environment happy-dom
// ProviderDrawer wires `useProviderDetail` (TanStack Query) and renders
// a Radix Dialog portal — both need an act-aware, DOM-backed environment
// or React logs warnings and the portal can't mount.
(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
import { afterEach, describe, it, expect, vi } from "vitest";
import { cleanup, fireEvent, render } from "@testing-library/react";
import { ApiError } from "@/lib/api";
import { ProviderDrawer } from "@/components/ProviderDrawer";
import type { Provider } from "@/types";
// Mock the hook BEFORE the import above is resolved (vitest hoists
// `vi.mock` to the top of the file regardless of where it appears
// syntactically). Mocking the hook directly — rather than mocking
// `api.getProvider` — lets each test pin the hook's exact return shape
// without standing up a real `QueryClient`.
//
// `vi.hoisted` is required because `vi.mock` is hoisted ABOVE top-level
// `const` declarations — referencing a top-level `vi.fn()` directly from
// the factory would hit "Cannot access before initialization" at runtime.
const { useProviderDetail } = vi.hoisted(() => ({
useProviderDetail: vi.fn(),
}));
vi.mock("@/hooks/useProviderDetail", () => ({
useProviderDetail,
}));
/**
* Minimal valid `Provider` fixture every required key present so the
* component typechecks. The fields are what `ProviderOverview` reads,
* so the success-path render exercises every prop.
*/
const SAMPLE_PROVIDER: Provider = {
npi: "1881068062",
name: "Montrose Memorial",
taxId: "721587149",
address: "123 Main St",
city: "Montrose",
state: "CO",
zip: "81401",
phone: "(970) 555-1234",
claimCount: 184,
outstandingAr: 12450,
};
/**
* Configure the mocked hook's return value for a single test. The
* `refetch` default is a fresh `vi.fn()` tests that need to assert
* on it can override via `overrides.refetch`.
*/
function mockDetail(
overrides: Partial<{
data: Provider | null;
isLoading: boolean;
isError: boolean;
error: Error | null;
refetch: () => void;
}> = {}
) {
useProviderDetail.mockReturnValue({
data: null,
isLoading: false,
isError: false,
error: null,
refetch: vi.fn(),
...overrides,
});
}
// happy-dom keeps `document.body` between tests; without cleanup,
// `screen.getByText(...)` would find nodes from earlier renders.
afterEach(() => {
cleanup();
vi.clearAllMocks();
});
describe("ProviderDrawer", () => {
it("test_renders_nothing_when_npi_is_null", () => {
mockDetail({ data: null });
render(<ProviderDrawer npi={null} onClose={() => {}} />);
// No provider content should be in the document when the drawer
// is closed — Radix's Dialog gates the portal on `open`.
expect(document.body.textContent).not.toContain("Montrose Memorial");
});
it("test_calls_useProviderDetail_with_npi", () => {
mockDetail({ data: SAMPLE_PROVIDER });
render(<ProviderDrawer npi="1881068062" onClose={() => {}} />);
expect(useProviderDetail).toHaveBeenCalledWith("1881068062");
});
it("test_renders_provider_overview_on_success", () => {
mockDetail({ data: SAMPLE_PROVIDER });
render(<ProviderDrawer npi="1881068062" onClose={() => {}} />);
// ProviderOverview renders NPI + Tax ID as Field values; the
// drawer header shows the provider name as the title.
expect(document.body.textContent).toContain("Montrose Memorial");
expect(document.body.textContent).toContain("1881068062");
expect(document.body.textContent).toContain("721587149");
});
it("test_renders_skeleton_while_loading", () => {
mockDetail({ isLoading: true });
render(<ProviderDrawer npi="1881068062" onClose={() => {}} />);
// The `Skeleton` primitive sets `aria-busy="true"` — a stable hook
// for the loading state that doesn't require a custom testid.
expect(document.querySelectorAll('[aria-busy="true"]').length).toBeGreaterThan(0);
// And the provider name should NOT have leaked in yet.
expect(document.body.textContent).not.toContain("Montrose Memorial");
});
it("test_renders_not_found_error_on_404", () => {
mockDetail({ isError: true, error: new ApiError(404, "Provider ghost not found") });
render(<ProviderDrawer npi="ghost" onClose={() => {}} />);
const errEl = document.querySelector('[data-testid="provider-drawer-error-not_found"]');
expect(errEl).not.toBeNull();
// Body should mention "doesn't exist" — the not_found COPY key.
expect(errEl?.textContent).toContain("doesn't exist");
// And the retry button should NOT be present (not_found has no
// retry affordance — retrying a 404 won't help).
expect(document.querySelector('[data-testid="error-retry"]')).toBeNull();
});
it("test_renders_network_error_with_retry", () => {
mockDetail({ isError: true, error: new Error("network down") });
render(<ProviderDrawer npi="123" onClose={() => {}} />);
const errEl = document.querySelector('[data-testid="provider-drawer-error-network"]');
expect(errEl).not.toBeNull();
expect(errEl?.textContent).toContain("Couldn't reach the server");
// Network variant shows a Retry button.
const retryBtn = document.querySelector(
'[data-testid="error-retry"]'
) as HTMLButtonElement | null;
expect(retryBtn).not.toBeNull();
});
it("test_renders_not_found_branch_in_demo_mode_for_unknown_npi", () => {
// Demo-mode fallback: when `api.isConfigured` is false, the hook
// reads from the in-memory zustand store instead of fetching. If the
// queried NPI isn't in the providers list, the hook returns
// `isError: true` with an `ApiError(404, "Provider not found")`.
// The drawer's `errorKind` computation must route this to the
// `not_found` branch — NOT the generic `network` branch, which
// would mislead the user into thinking the server is down when
// there is simply no backend configured (or the NPI is just not
// in the local store). Regression guard for the `new Error` →
// `new ApiError(404, ...)` fix on the demo-mode fallback branch.
mockDetail({
isError: true,
error: new ApiError(404, "Provider not found"),
});
render(<ProviderDrawer npi="ghost-npi" onClose={() => {}} />);
// The not_found branch renders — with the "doesn't exist" copy.
const notFoundEl = document.querySelector(
'[data-testid="provider-drawer-error-not_found"]'
);
expect(notFoundEl).not.toBeNull();
expect(notFoundEl?.textContent).toContain("doesn't exist");
// And — the whole point of this test — the network branch MUST NOT
// be present. A plain `Error` from the demo-mode fallback would
// have landed here and shown "Couldn't reach the server", which
// is wrong for a known-local-miss.
expect(
document.querySelector('[data-testid="provider-drawer-error-network"]')
).toBeNull();
expect(document.body.textContent).not.toContain("Couldn't reach the server");
// not_found has no retry affordance — same invariant as the 404
// test above, restated here so this test is self-contained as a
// regression guard.
expect(document.querySelector('[data-testid="error-retry"]')).toBeNull();
});
it("test_close_button_calls_onClose", () => {
const onClose = vi.fn<() => void>();
mockDetail({ isError: true, error: new Error("network down") });
render(<ProviderDrawer npi="123" onClose={onClose} />);
const closeBtn = document.querySelector(
'[data-testid="error-close"]'
) as HTMLButtonElement | null;
expect(closeBtn).not.toBeNull();
fireEvent.click(closeBtn!);
expect(onClose).toHaveBeenCalledTimes(1);
});
});
@@ -0,0 +1,87 @@
import { Dialog, DialogContent } from "@/components/ui/dialog";
import { ApiError } from "@/lib/api";
import { DrillDrawerHeader } from "@/components/drill/DrillDrawerHeader";
import { Skeleton } from "@/components/ui/skeleton";
import { useProviderDetail } from "@/hooks/useProviderDetail";
import { ProviderOverview } from "./ProviderOverview";
import { ProviderDrawerError } from "./ProviderDrawerError";
interface Props {
npi: string | null;
onClose: () => void;
}
/**
* Provider drill-down drawer (SP21 Task 2.2).
*
* Side-panel shell that consumes ``useProviderDetail(npi)`` and renders
* the Overview tab content (Phase 2 ships only this tab; Phase 3 adds
* Claims/Activity tabs once ``recent_claims`` and ``recent_activity``
* rendering lands).
*
* Layout mirrors the ClaimDrawer / RemitDrawer pattern: Radix Dialog
* repositioned to the right edge as a fixed-height side panel, with
* the shared ``DrillDrawerHeader`` on top and a scrollable body below.
* The DialogContent is the flex parent; the header and body stack
* naturally inside it without an explicit `calc(100% - 64px)` height
* that would couple to DrillDrawerHeader's padding/font sizes.
*
* Error branching mirrors the peer drawers:
* - `ApiError(404)` "not_found" (no retry, the provider is gone)
* - anything else "network" (retry available)
* - demo mode + unknown NPI ApiError(404), routes to the same
* "not_found" branch (the hook raises `ApiError(404, "Provider not
* found")` in this case, matching the real backend 404 path).
*/
export function ProviderDrawer({ npi, onClose }: Props) {
const { data, isLoading, isError, error, refetch } = useProviderDetail(npi);
const errorKind: "not_found" | "network" | null = isError
? error instanceof ApiError && error.status === 404
? "not_found"
: "network"
: null;
return (
<Dialog open={npi !== null} onOpenChange={(o) => { if (!o) onClose(); }}>
<DialogContent
className="fixed right-0 top-0 flex h-full w-full max-w-2xl flex-col translate-x-0 translate-y-0 rounded-none border-l border-border bg-card p-0"
aria-describedby={undefined}
>
{errorKind ? (
<ProviderDrawerError
kind={errorKind}
onRetry={() => {
void refetch();
}}
onClose={onClose}
/>
) : isLoading || !data ? (
<div className="flex h-full flex-col overflow-y-auto">
<DrillDrawerHeader
eyebrow="Provider"
title="Loading…"
onClose={onClose}
/>
<div className="space-y-2 p-6">
<Skeleton variant="row" />
<Skeleton variant="row" />
<Skeleton variant="row" />
</div>
</div>
) : (
<div className="flex h-full flex-col overflow-y-auto">
<DrillDrawerHeader
eyebrow="Provider"
title={data.name}
onClose={onClose}
/>
<div className="p-6">
<ProviderOverview provider={data} />
</div>
</div>
)}
</DialogContent>
</Dialog>
);
}
@@ -0,0 +1,70 @@
import { AlertCircle, WifiOff } from "lucide-react";
import { Button } from "@/components/ui/button";
type ProviderDrawerErrorProps = {
kind: "not_found" | "network";
onRetry?: () => void;
onClose: () => void;
};
const COPY = {
not_found: {
eyebrow: "NOT FOUND",
message: "This provider doesn't exist or has been removed.",
},
network: {
eyebrow: "CONNECTION",
message: "Couldn't reach the server. Check your connection and try again.",
},
} as const;
/**
* Error state for the provider drill-down drawer (SP21 Task 2.2).
*
* Two shapes `not_found` (the NPI in the URL doesn't resolve on the
* server, e.g. a stale deep link) and `network` (the request failed).
* The not_found variant has no retry affordance (retrying won't help),
* the network variant does when `onRetry` is supplied.
*
* Visual twin of `RemitDrawerError` / `ClaimDrawerError` so the drawer
* family feels like one component family same icon size, same eyebrow
* color, same button spacing.
*/
export function ProviderDrawerError({
kind,
onRetry,
onClose,
}: ProviderDrawerErrorProps) {
const { eyebrow, message } = COPY[kind];
const Icon = kind === "network" ? WifiOff : AlertCircle;
return (
<div
className="flex flex-col items-start gap-4 p-6 bg-[color:var(--m-surface)] text-[color:var(--m-ink-primary)]"
role="alert"
data-testid={`provider-drawer-error-${kind}`}
>
<div className="flex items-center gap-2">
<Icon
className="h-5 w-5 text-[color:var(--m-error)]"
strokeWidth={1.75}
aria-hidden
/>
<span className="eyebrow text-[color:var(--m-error)]">
{eyebrow}
</span>
</div>
<p className="text-sm text-[color:var(--m-ink-secondary)] max-w-sm">{message}</p>
<div className="flex items-center gap-2">
{kind === "network" && onRetry ? (
<Button variant="outline" size="sm" onClick={onRetry} data-testid="error-retry">
Retry
</Button>
) : null}
<Button variant="ghost" size="sm" onClick={onClose} data-testid="error-close">
Close
</Button>
</div>
</div>
);
}
@@ -0,0 +1,43 @@
import type { Provider } from "@/types";
import { fmt } from "@/lib/format";
/**
* Overview tab content for the provider drill-down drawer (SP21
* Task 2.2). Renders the base provider fields in a two-column grid:
*
* - Identity: NPI, Tax ID, address, phone
* - Activity: claim count, outstanding AR
*
* Subsequent tasks (Phase 3) will hang ``recent_claims`` and
* ``recent_activity`` off this surface; for now we only render the
* base fields the drawer needs to present "who is this provider and
* what's their activity shape" at a glance.
*/
export function ProviderOverview({ provider }: { provider: Provider }) {
return (
<div className="space-y-4">
<div className="grid grid-cols-2 gap-3">
<Field label="NPI" value={provider.npi} mono />
<Field label="Tax ID" value={provider.taxId} mono />
<Field
label="Address"
value={`${provider.address}, ${provider.city}, ${provider.state} ${provider.zip}`}
/>
<Field label="Phone" value={provider.phone} mono />
</div>
<div className="grid grid-cols-2 gap-3 pt-3 border-t border-border/30">
<Field label="Claims" value={fmt.num(provider.claimCount)} mono />
<Field label="Outstanding AR" value={fmt.usd(provider.outstandingAr)} mono />
</div>
</div>
);
}
function Field({ label, value, mono }: { label: string; value: string; mono?: boolean }) {
return (
<div>
<div className="eyebrow">{label}</div>
<div className={`text-[13px] mt-1 ${mono ? "display mono" : ""}`}>{value}</div>
</div>
);
}
+3
View File
@@ -0,0 +1,3 @@
// Barrel export for the ProviderDrawer module (SP21 Task 2.2).
export { ProviderDrawer } from "./ProviderDrawer";
@@ -0,0 +1,37 @@
import { X } from "lucide-react";
interface Props {
eyebrow: string;
title: string;
onClose: () => void;
}
/**
* Shared side-panel header used by every SP21 drill-down drawer
* (provider, future ones). Renders an uppercase eyebrow above a
* larger title, with a close button on the right.
*
* Visual style mirrors the eyebrow + title pattern used elsewhere in
* the app (see ``.eyebrow`` in ``src/index.css`` and the
* ``DrillDrawerHeader`` usage in ``ClaimDrawerHeader``).
*/
export function DrillDrawerHeader({ eyebrow, title, onClose }: Props) {
return (
<div className="flex items-center justify-between border-b border-border/30 px-6 py-4">
<div>
<div className="text-[10.5px] font-semibold uppercase tracking-[0.18em] text-muted-foreground">
{eyebrow}
</div>
<h2 className="text-[18px] font-semibold tracking-tight mt-0.5">{title}</h2>
</div>
<button
type="button"
onClick={onClose}
aria-label="Close drawer"
className="rounded-md p-1 text-muted-foreground hover:bg-muted/60 hover:text-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring"
>
<X className="h-4 w-4" aria-hidden />
</button>
</div>
);
}
@@ -34,4 +34,27 @@ describe("DrillableCell", () => {
expect(btn.disabled).toBe(true); expect(btn.disabled).toBe(true);
expect(btn.classList.contains("drillable")).toBe(false); expect(btn.classList.contains("drillable")).toBe(false);
}); });
// ---------------------------------------------------------------------
// Regression for Task 2.4 — event bubbling.
//
// DrillableCell renders a <button>, and <button> clicks bubble up the
// DOM by default. Claims wraps each row in a <TableRow onClick={...}>
// so a click on the provider cell used to (1) navigate to /providers
// and then (2) bubble to the row and re-fire buildUrl() on the now-
// /providers URL, appending a phantom ?claim=… param. We fix it at
// the DrillableCell level so future tables that adopt the component
// are correct by default.
// ---------------------------------------------------------------------
it("test_click_does_not_bubble_to_parent", () => {
const parentClick = vi.fn();
const { container } = render(
<div onClick={parentClick}>
<DrillableCell onClick={() => {}}>Click me</DrillableCell>
</div>,
);
const btn = container.querySelector("button")!;
fireEvent.click(btn);
expect(parentClick).not.toHaveBeenCalled();
});
}); });
+18 -3
View File
@@ -1,9 +1,15 @@
import type { ReactNode } from "react"; import type { MouseEvent, ReactNode } from "react";
import { cn } from "@/lib/utils"; import { cn } from "@/lib/utils";
interface Props { interface Props {
children: ReactNode; children: ReactNode;
onClick: () => void; /**
* Click handler. Receives the underlying React mouse event so we can
* call `e.stopPropagation()` before invoking the caller's logic see
* the JSDoc on the component for why this matters when a DrillableCell
* is nested inside a row-level click handler.
*/
onClick: (e: MouseEvent<HTMLButtonElement>) => void;
disabled?: boolean; disabled?: boolean;
/** Optional aria-label; defaults to the visible text content. */ /** Optional aria-label; defaults to the visible text content. */
ariaLabel?: string; ariaLabel?: string;
@@ -18,12 +24,21 @@ interface Props {
* Renders as a <button> (disabled when `disabled`) so it gets keyboard * Renders as a <button> (disabled when `disabled`) so it gets keyboard
* activation (Enter/Space) and the standard disabled-button semantics. * activation (Enter/Space) and the standard disabled-button semantics.
* The `drillable` affordance class is omitted when disabled. * The `drillable` affordance class is omitted when disabled.
*
* Calls `e.stopPropagation()` on the button click before invoking the
* caller's handler. This prevents the click from bubbling to a
* row-level `onClick` (e.g. Claims' `<TableRow onClick={() => open(c.id)}>`),
* which would otherwise re-fire `buildUrl()` on the now-navigated URL
* and corrupt history. Precedent: `src/components/inbox/Lane.tsx:41`.
*/ */
export function DrillableCell({ children, onClick, disabled, ariaLabel }: Props) { export function DrillableCell({ children, onClick, disabled, ariaLabel }: Props) {
return ( return (
<button <button
type="button" type="button"
onClick={onClick} onClick={(e) => {
e.stopPropagation();
onClick(e);
}}
disabled={disabled} disabled={disabled}
aria-label={ariaLabel} aria-label={ariaLabel}
className={cn( className={cn(
+109 -68
View File
@@ -1,87 +1,128 @@
import * as React from "react"; import * as React from "react";
import { cn } from "@/lib/utils"; import { cn } from "@/lib/utils";
const Table = React.forwardRef<HTMLTableElement, React.HTMLAttributes<HTMLTableElement>>( // ---------------------------------------------------------------------------
({ className, ...props }, ref) => ( // Table
<div className="relative w-full overflow-auto"> //
<table // Shared table primitive used by Claims, Remittances, Batches, Acks, etc.
ref={ref} //
className={cn("w-full caption-bottom text-sm", className)} // `tone="paper"` swaps the dark-mode row chrome (muted/20 header, muted/30
{...props} // hover) for paper-toned chrome (cream surface, soft hairline border,
/> // tinted hover). Paper-toned tables sit inside the cream "paper plane"
// sections of the hybrid Magazine Spread layout. The default `tone="dark"`
// is unchanged from the original look so existing callers keep their
// behavior. Pages pass the tone prop once on `<Table>` and the children
// inherit the matching colors via the data-tone attribute — no need to
// rewrite every TableHead/TableRow/TableCell.
// ---------------------------------------------------------------------------
type Tone = "dark" | "paper";
type TableProps = React.HTMLAttributes<HTMLTableElement> & {
tone?: Tone;
};
const Table = React.forwardRef<HTMLTableElement, TableProps>(
({ className, tone = "dark", ...props }, ref) => (
<div
className={cn("relative w-full overflow-auto", className)}
data-tone={tone}
>
<table ref={ref} className="w-full caption-bottom text-sm" {...props} />
</div> </div>
) )
); );
Table.displayName = "Table"; Table.displayName = "Table";
const TableHeader = React.forwardRef< type TableSectionProps = React.HTMLAttributes<HTMLTableSectionElement>;
HTMLTableSectionElement,
React.HTMLAttributes<HTMLTableSectionElement> const TableHeader = React.forwardRef<HTMLTableSectionElement, TableSectionProps>(
>(({ className, ...props }, ref) => ( ({ className, ...props }, ref) => {
<thead // Paper-tone: cream-papered header band, soft border, no dark muted fill.
ref={ref} return (
className={cn( <thead
"[&_tr]:border-b [&_tr]:border-border/60 [&_tr]:bg-muted/20", ref={ref}
className className={cn(
)} "[&_tr]:border-b [&_tr]:border-border/60 [&_tr]:bg-muted/20",
{...props} // When the parent <Table> is paper-toned, swap to cream chrome.
/> "[[data-tone=paper]_&]:bg-[hsl(36_22%_92%)]",
)); "[[data-tone=paper]_&]:[&_tr]:bg-[hsl(36_22%_92%)]",
"[[data-tone=paper]_&]:[&_tr]:border-[hsl(30_14%_14%_/_0.10)]",
className
)}
{...props}
/>
);
}
);
TableHeader.displayName = "TableHeader"; TableHeader.displayName = "TableHeader";
const TableBody = React.forwardRef< const TableBody = React.forwardRef<HTMLTableSectionElement, TableSectionProps>(
HTMLTableSectionElement, ({ className, ...props }, ref) => (
React.HTMLAttributes<HTMLTableSectionElement> <tbody
>(({ className, ...props }, ref) => ( ref={ref}
<tbody className={cn("[&_tr:last-child]:border-0", className)}
ref={ref} {...props}
className={cn("[&_tr:last-child]:border-0", className)} />
{...props} )
/> );
));
TableBody.displayName = "TableBody"; TableBody.displayName = "TableBody";
const TableRow = React.forwardRef< type TableRowProps = React.HTMLAttributes<HTMLTableRowElement>;
HTMLTableRowElement,
React.HTMLAttributes<HTMLTableRowElement> const TableRow = React.forwardRef<HTMLTableRowElement, TableRowProps>(
>(({ className, ...props }, ref) => ( ({ className, ...props }, ref) => (
<tr <tr
ref={ref} ref={ref}
className={cn( className={cn(
"border-b border-border/40 transition-colors hover:bg-muted/30 focus-within:bg-muted/40 data-[state=selected]:bg-muted/50", "border-b border-border/40 transition-colors hover:bg-muted/30 focus-within:bg-muted/40 data-[state=selected]:bg-muted/50",
className // Paper-tone: warm cream hover, soft hairline between rows.
)} "[[data-tone=paper]_&]:border-[hsl(30_14%_14%_/_0.08)]",
{...props} "[[data-tone=paper]_&]:hover:bg-[hsl(36_22%_94%)]",
/> "[[data-tone=paper]_&]:focus-within:bg-[hsl(36_22%_94%)]",
)); "[[data-tone=paper]_&]:data-[state=selected]:bg-[hsl(212_85%_95%)]",
className
)}
{...props}
/>
)
);
TableRow.displayName = "TableRow"; TableRow.displayName = "TableRow";
const TableHead = React.forwardRef< type TableHeadProps = React.ThHTMLAttributes<HTMLTableCellElement>;
HTMLTableCellElement,
React.ThHTMLAttributes<HTMLTableCellElement> const TableHead = React.forwardRef<HTMLTableCellElement, TableHeadProps>(
>(({ className, scope = "col", ...props }, ref) => ( ({ className, scope = "col", ...props }, ref) => (
<th <th
ref={ref} ref={ref}
scope={scope} scope={scope}
className={cn( className={cn(
"h-9 px-4 text-left align-middle text-[10.5px] font-semibold uppercase tracking-[0.14em] text-muted-foreground/80 [&:has([role=checkbox])]:pr-0", "h-9 px-4 text-left align-middle text-[10.5px] font-semibold uppercase tracking-[0.14em] text-muted-foreground/80 [&:has([role=checkbox])]:pr-0",
className // Paper-tone: surface-ink-2 (warm dark) instead of cool muted-foreground.
)} "[[data-tone=paper]_&]:text-[hsl(var(--surface-ink-2))]",
{...props} className
/> )}
)); {...props}
/>
)
);
TableHead.displayName = "TableHead"; TableHead.displayName = "TableHead";
const TableCell = React.forwardRef< const TableCell = React.forwardRef<HTMLTableCellElement, TableHeadProps>(
HTMLTableCellElement, ({ className, ...props }, ref) => (
React.TdHTMLAttributes<HTMLTableCellElement> <td
>(({ className, ...props }, ref) => ( ref={ref}
<td className={cn(
ref={ref} "px-4 py-3 align-middle [&:has([role=checkbox])]:pr-0",
className={cn("px-4 py-3 align-middle [&:has([role=checkbox])]:pr-0", className)} // Paper-tone: warm foreground (surface-ink) for the primary text.
{...props} "[[data-tone=paper]_&]:text-[hsl(var(--surface-ink))]",
/> className
)); )}
{...props}
/>
)
);
TableCell.displayName = "TableCell"; TableCell.displayName = "TableCell";
export { Table, TableHeader, TableBody, TableRow, TableHead, TableCell }; export { Table, TableHeader, TableBody, TableRow, TableHead, TableCell };
export type { Tone as TableTone };
+6
View File
@@ -164,6 +164,12 @@ function buildActivity(claims: Claim[]): Activity[] {
timestamp: c.submissionDate, timestamp: c.submissionDate,
npi: c.providerNpi, npi: c.providerNpi,
amount: c.billedAmount, amount: c.billedAmount,
// SP21 Task 2.5: mirror the backend `recent_activity()` wire
// shape so the Dashboard routing helper can find the claim id.
// Sample-data remits are never a 1:1 Activity row, so the
// remittance id is always null here.
claimId: c.id,
remittanceId: null,
}; };
}); });
return events.sort( return events.sort(
+87
View File
@@ -0,0 +1,87 @@
import { useQuery } from "@tanstack/react-query";
import { useSyncExternalStore } from "react";
import { api, ApiError } from "@/lib/api";
import { useAppStore } from "@/store";
import type { Provider } from "@/types";
/**
* Per-provider detail drawer query (SP21 Task 2.2).
*
* Twin of `useClaimDetail` same return shape, same retry semantics,
* same demo-mode fallback story. Returns `{ data, isLoading, isError,
* error, refetch }`:
* - `npi === null` (drawer closed): the query is disabled and the
* hook short-circuits to the empty drawer state so a closed drawer
* doesn't burn a network request or a TanStack cache slot.
* - `npi` is set AND a backend is configured: fetches
* `GET /api/config/providers/{npi}` via `api.getProvider`. Cached
* 60 s provider directory rows change infrequently, but we still
* want the drawer to refresh when a user reopens it across a long
* session.
* - On 404: the hook's retry predicate short-circuits (no retries) so
* the drawer's not-found state appears immediately rather than
* being masked by three back-to-back retry attempts.
* - `!api.isConfigured` (demo mode): no fetch is issued. The hook
* reads from the in-memory zustand store (`useAppStore.providers`).
* An unknown NPI surfaces as `isError: true` so the drawer's
* error branch handles it instead of spinning on a missing fetch.
*/
export function useProviderDetail(npi: string | null): {
data: Provider | null;
isLoading: boolean;
isError: boolean;
error: Error | null;
refetch: () => void;
} {
const fallback = useSyncExternalStore(
(cb) => useAppStore.subscribe(cb),
() => useAppStore.getState().providers,
() => useAppStore.getState().providers
);
const q = useQuery<Provider>({
queryKey: ["provider-detail", npi],
queryFn: () => api.getProvider(npi as string),
enabled: npi !== null && api.isConfigured,
staleTime: 60 * 1000,
retry: (failureCount, error) => {
if (error instanceof ApiError && error.status === 404) return false;
return failureCount < 3;
},
});
if (!api.isConfigured) {
const provider =
npi === null ? null : fallback.find((p) => p.npi === npi) ?? null;
return {
data: provider,
isLoading: false,
isError: provider === null && npi !== null,
error:
provider === null && npi !== null
? new ApiError(404, "Provider not found")
: null,
refetch: () => {},
};
}
if (npi === null) {
return {
data: null,
isLoading: false,
isError: false,
error: null,
refetch: () => {},
};
}
return {
data: q.data ?? null,
isLoading: q.isLoading,
isError: q.isError,
error: q.error,
refetch: () => {
void q.refetch();
},
};
}
+217
View File
@@ -0,0 +1,217 @@
// @vitest-environment happy-dom
// Mirror the IS_REACT_ACT_ENVIRONMENT setup from useDrawerUrlState.test.ts
// so React doesn't log act() warnings about the createRoot render/unmount
// and the popstate-driven state updates.
(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
import React, { act } from "react";
import { createRoot, type Root } from "react-dom/client";
import { describe, expect, it, vi, beforeEach, afterEach } from "vitest";
import { useProviderDrawerUrlState } from "./useProviderDrawerUrlState";
/**
* Minimal renderHook shim same pattern as the other hook tests.
*/
function renderHook<TResult>(setup: () => TResult): {
result: { current: TResult | undefined };
unmount: () => void;
} {
const result: { current: TResult | undefined } = { current: undefined };
const container = document.createElement("div");
document.body.appendChild(container);
function Probe() {
result.current = setup();
return null;
}
const root: Root = createRoot(container);
act(() => {
root.render(React.createElement(Probe));
});
return {
result,
unmount: () => {
act(() => root.unmount());
container.remove();
},
};
}
/**
* Point happy-dom's URL at a known value. happy-dom v20 doesn't expose a
* writable `window.location.search`, but `window.happyDOM.setURL` updates
* the URL the window reports without triggering a navigation exactly
* what we want for mounting the hook at `/providers?provider=NPI` etc.
*/
function setLocation(url: string): void {
(window as unknown as { happyDOM: { setURL: (u: string) => void } }).happyDOM.setURL(url);
}
describe("useProviderDrawerUrlState", () => {
type PushState = (state: unknown, unused: string, url?: string | URL | null) => void;
let pushStateMock: ReturnType<typeof vi.fn<PushState>>;
let replaceStateMock: ReturnType<typeof vi.fn<PushState>>;
beforeEach(() => {
pushStateMock = vi.fn();
replaceStateMock = vi.fn();
vi.stubGlobal("history", {
pushState: pushStateMock,
replaceState: replaceStateMock,
state: null,
});
});
afterEach(() => {
vi.unstubAllGlobals();
setLocation("http://localhost/");
});
it("reads the ?provider= param from window.location.search on mount", () => {
setLocation("http://localhost/providers?provider=1881068062");
const { result, unmount } = renderHook(() => useProviderDrawerUrlState());
expect(result.current?.providerNpi).toBe("1881068062");
expect(typeof result.current?.open).toBe("function");
expect(typeof result.current?.close).toBe("function");
expect(typeof result.current?.setProviderNpi).toBe("function");
unmount();
});
it("returns null providerNpi when no ?provider= param is set", () => {
setLocation("http://localhost/providers");
const { result, unmount } = renderHook(() => useProviderDrawerUrlState());
expect(result.current?.providerNpi).toBeNull();
unmount();
});
it("returns null providerNpi when ?provider= is present but empty", () => {
setLocation("http://localhost/providers?provider=");
const { result, unmount } = renderHook(() => useProviderDrawerUrlState());
expect(result.current?.providerNpi).toBeNull();
unmount();
});
it("open(npi) pushes a new history entry containing ?provider=npi", () => {
setLocation("http://localhost/providers");
const { result, unmount } = renderHook(() => useProviderDrawerUrlState());
act(() => {
result.current?.open("1881068062");
});
expect(pushStateMock).toHaveBeenCalledTimes(1);
expect(replaceStateMock).not.toHaveBeenCalled();
const urlArg = pushStateMock.mock.calls[0][2] as string;
expect(urlArg).toContain("?provider=1881068062");
unmount();
});
it("setProviderNpi(npi) replaces the current history entry (no new entry) and does NOT pushState", () => {
setLocation("http://localhost/providers?provider=1881068062");
const { result, unmount } = renderHook(() => useProviderDrawerUrlState());
act(() => {
result.current?.setProviderNpi("1881068063");
});
expect(replaceStateMock).toHaveBeenCalledTimes(1);
expect(pushStateMock).not.toHaveBeenCalled();
const urlArg = replaceStateMock.mock.calls[0][2] as string;
expect(urlArg).toContain("?provider=1881068063");
unmount();
});
it("open() and close() preserve other query params (only ?provider= is touched)", () => {
setLocation("http://localhost/providers?sort=name&provider=1881068062");
const { result, unmount } = renderHook(() => useProviderDrawerUrlState());
act(() => {
result.current?.open("1881068063");
});
const openUrl = pushStateMock.mock.calls[0][2] as string;
expect(openUrl).toContain("sort=name");
expect(openUrl).toMatch(/[?&]provider=1881068063/);
act(() => {
result.current?.close();
});
const closeUrl = pushStateMock.mock.calls[1][2] as string;
expect(closeUrl).toContain("sort=name");
expect(closeUrl).not.toContain("provider=");
unmount();
});
it("close() pushes a new history entry with the ?provider= param stripped", () => {
setLocation("http://localhost/providers?provider=1881068062");
const { result, unmount } = renderHook(() => useProviderDrawerUrlState());
act(() => {
result.current?.close();
});
expect(pushStateMock).toHaveBeenCalledTimes(1);
expect(replaceStateMock).not.toHaveBeenCalled();
const urlArg = pushStateMock.mock.calls[0][2] as string;
expect(urlArg).not.toContain("?provider=");
expect(result.current?.providerNpi).toBeNull();
unmount();
});
it("updates providerNpi in response to popstate (browser back/forward)", async () => {
setLocation("http://localhost/providers?provider=1881068062");
const { result, unmount } = renderHook(() => useProviderDrawerUrlState());
expect(result.current?.providerNpi).toBe("1881068062");
setLocation("http://localhost/providers?provider=1881068063");
await act(async () => {
window.dispatchEvent(new PopStateEvent("popstate"));
await Promise.resolve();
});
expect(result.current?.providerNpi).toBe("1881068063");
unmount();
});
it("does not collide with the existing ?claim= or ?remit= params (orthogonal keys)", () => {
// The providers drawer is independent of the claims and remits
// drawers — all three can be open simultaneously in the future, and
// the hooks must not stomp each other's URL state. Opening a
// provider must leave ?claim= and ?remit= intact.
setLocation("http://localhost/?claim=CLM-1&remit=REM-1");
const { result, unmount } = renderHook(() => useProviderDrawerUrlState());
act(() => {
result.current?.open("1881068062");
});
const openUrl = pushStateMock.mock.calls[0][2] as string;
expect(openUrl).toContain("claim=CLM-1");
expect(openUrl).toContain("remit=REM-1");
expect(openUrl).toMatch(/[?&]provider=1881068062/);
unmount();
});
});
+102
View File
@@ -0,0 +1,102 @@
import { useCallback, useEffect, useState } from "react";
/**
* Read the current `?provider=…` query param off `window.location.search`.
* Returns `null` when the param is absent or empty.
*
* `URLSearchParams` is the standard, locale-free way to parse query
* strings in the browser. Using it (rather than hand-rolled string
* slicing) means we correctly handle multiple params and percent-encoded
* characters in NPIs without surprises.
*
* Param name is `?provider=` chosen to mirror the existing
* `?provider=NPI` drilldown convention used by the dashboard's
* "Top providers" row (so deep links survive across the app) and to
* stay alphabetically parallel with `?claim=` and `?remit=` (one-word
* tokens, no collision with the existing `MatchedProviderCard`).
*/
function readProviderNpi(): string | null {
const params = new URLSearchParams(window.location.search);
const value = params.get("provider");
return value === "" ? null : value;
}
/**
* Build the URL we want to push/replace into history.
*
* - `providerNpi === null` drop the `?provider=` param, preserving
* any other params (e.g. `?page=2&provider=…` keeps `page=2`).
* - `providerNpi !== null` set the param to the new NPI, also
* preserving any other params.
*
* We return `pathname + search + hash` (a relative URL) rather than the
* full href `history.pushState` accepts a relative URL and rewriting
* only the relative form keeps the document's origin stable.
*/
function buildUrl(providerNpi: string | null): string {
const url = new URL(window.location.href);
if (providerNpi === null) {
url.searchParams.delete("provider");
} else {
url.searchParams.set("provider", providerNpi);
}
return url.pathname + url.search + url.hash;
}
/**
* Per-provider detail drawer URL state (ProviderDrawer).
*
* Mirrors `useRemitDrawerUrlState` but for the providers drawer reads
* `?provider=` from the URL on mount and keeps the value in sync with
* history as the drawer is opened, navigated (j/k), and closed.
*
* - `providerNpi`: the NPI parsed from the URL (or `null` when the
* param is absent). React state so consumers re-render on changes.
* - `open(npi)`: pushes a NEW history entry with `?provider={npi}`
* so the browser Back button returns to the previous page (e.g. the
* providers list) and not just to the previously-open provider.
* - `setProviderNpi(npi)`: REPLACES the current history entry used
* by the j/k nav handler so j/k moves through the list without
* polluting history with one entry per keystroke.
* - `close()`: pushes a NEW entry that strips the param, so Back from
* the closed drawer returns to whatever page the user was on before
* opening the drawer.
*
* The hook subscribes to `popstate` so that browser Back/Forward
* (which fire popstate rather than our own pushState) propagate into
* the React state. Without this, hitting Back would change the URL but
* leave the drawer open on the stale NPI.
*/
export function useProviderDrawerUrlState(): {
providerNpi: string | null;
open: (npi: string) => void;
close: () => void;
setProviderNpi: (npi: string) => void;
} {
const [providerNpi, setProviderNpiState] = useState<string | null>(() => readProviderNpi());
const open = useCallback((npi: string) => {
window.history.pushState(null, "", buildUrl(npi));
setProviderNpiState(npi);
}, []);
const setProviderNpi = useCallback((npi: string) => {
window.history.replaceState(null, "", buildUrl(npi));
setProviderNpiState(npi);
}, []);
const close = useCallback(() => {
window.history.pushState(null, "", buildUrl(null));
setProviderNpiState(null);
}, []);
useEffect(() => {
const onPopState = () => {
setProviderNpiState(readProviderNpi());
};
window.addEventListener("popstate", onPopState);
return () => window.removeEventListener("popstate", onPopState);
}, []);
return { providerNpi, open, close, setProviderNpi };
}
+31 -1
View File
@@ -16,7 +16,8 @@
* - `parse835(...)` mirrors the 837 shape for `/api/parse-835`. * - `parse835(...)` mirrors the 837 shape for `/api/parse-835`.
* - `health()` GETs `/api/health` and returns `{ status, version }`. * - `health()` GETs `/api/health` and returns `{ status, version }`.
* - `listBatches / getBatch / listClaims / listRemittances / listProviders * - `listBatches / getBatch / listClaims / listRemittances / listProviders
* / listActivity` are plain JSON GETs against the persistence surface. * / getProvider / listActivity` are plain JSON GETs against the
* persistence surface.
* - `listUnmatched / matchRemit / unmatchClaim` hit the reconciliation * - `listUnmatched / matchRemit / unmatchClaim` hit the reconciliation
* surface. POSTs throw `ApiError` so callers can branch on `.status`. * surface. POSTs throw `ApiError` so callers can branch on `.status`.
*/ */
@@ -36,6 +37,7 @@ import type {
Payer, Payer,
Payer835, Payer835,
Payee835, Payee835,
Provider,
ReassociationTrace, ReassociationTrace,
UnmatchedClaim, UnmatchedClaim,
UnmatchedResponse, UnmatchedResponse,
@@ -586,6 +588,33 @@ async function listProviders<T = unknown>(
return (await res.json()) as PaginatedResponse<T>; return (await res.json()) as PaginatedResponse<T>;
} }
/**
* Fetch one configured provider by NPI, used by the provider drill-down
* drawer (SP21 Task 2.2 / 1.6).
*
* Drives ``GET /api/config/providers/{npi}``. Note the ``/api/config/``
* prefix this is the config-side route namespace, distinct from the
* persistence-side ``/api/providers`` used by ``listProviders``. The
* response is the full ``Provider`` shape (including the optional
* ``recent_claims`` and ``recent_activity`` arrays populated by Task
* 1.6 when the backend can serve them).
*
* Throws ``ApiError`` on non-2xx including 404, which the drawer may
* want to branch on for a "provider no longer configured" state.
*/
async function getProvider(npi: string): Promise<Provider> {
if (!isConfigured) throw notConfiguredError();
const res = await fetch(
joinUrl(`/api/config/providers/${encodeURIComponent(npi)}`),
{ headers: { Accept: "application/json" } }
);
if (!res.ok) {
const detail = await readErrorBody(res);
throw new ApiError(res.status, detail || res.statusText);
}
return (await res.json()) as Provider;
}
/** /**
* Aggregate stats for one payer, used by the peek modal on Dashboard / * Aggregate stats for one payer, used by the peek modal on Dashboard /
* Claims tables (SP21 universal drill-down). Drives * Claims tables (SP21 universal drill-down). Drives
@@ -773,6 +802,7 @@ export const api = {
listRemittances, listRemittances,
getRemittance, getRemittance,
listProviders, listProviders,
getProvider,
getPayerSummary, getPayerSummary,
listActivity, listActivity,
listUnmatched, listUnmatched,
+86
View File
@@ -0,0 +1,86 @@
import { describe, expect, it } from "vitest";
import { eventKindToUrl, type RoutableEvent } from "./event-routing";
// A minimal event factory keeps the assertions short and keeps the
// focus on what the helper actually inspects (kind + the relevant
// entity-id field for that kind).
function evt(overrides: Partial<RoutableEvent> & { kind: RoutableEvent["kind"] }): RoutableEvent {
return {
claimId: null,
remittanceId: null,
npi: undefined,
...overrides,
};
}
describe("eventKindToUrl", () => {
// ----- claim_* → /claims?claim=ID -------------------------------
it("routes claim_submitted to /claims?claim=ID", () => {
expect(
eventKindToUrl(evt({ kind: "claim_submitted", claimId: "CLM-1" })),
).toBe("/claims?claim=CLM-1");
});
it("routes claim_paid to /claims?claim=ID", () => {
expect(
eventKindToUrl(evt({ kind: "claim_paid", claimId: "CLM-2" })),
).toBe("/claims?claim=CLM-2");
});
it("routes claim_denied to /claims?claim=ID", () => {
expect(
eventKindToUrl(evt({ kind: "claim_denied", claimId: "CLM-3" })),
).toBe("/claims?claim=CLM-3");
});
it("routes claim_accepted to /claims?claim=ID", () => {
expect(
eventKindToUrl(evt({ kind: "claim_accepted", claimId: "CLM-4" })),
).toBe("/claims?claim=CLM-4");
});
it("percent-encodes the claim id when it contains special chars", () => {
expect(
eventKindToUrl(evt({ kind: "claim_paid", claimId: "CLM/1+2" })),
).toBe("/claims?claim=CLM%2F1%2B2");
});
it("returns null for claim_* when claimId is missing", () => {
expect(
eventKindToUrl(evt({ kind: "claim_paid", claimId: null })),
).toBeNull();
expect(
eventKindToUrl(evt({ kind: "claim_paid", claimId: undefined })),
).toBeNull();
});
// ----- remit_received → null (Phase 4) --------------------------
it("returns null for remit_received (Phase 4 drawer not built yet)", () => {
expect(
eventKindToUrl(evt({ kind: "remit_received", remittanceId: "REM-1" })),
).toBeNull();
});
// ----- provider_added → /providers?provider=NPI -----------------
it("routes provider_added to /providers?provider=NPI", () => {
expect(
eventKindToUrl(evt({ kind: "provider_added", npi: "1730187395" })),
).toBe("/providers?provider=1730187395");
});
it("returns null for provider_added when npi is missing", () => {
expect(eventKindToUrl(evt({ kind: "provider_added", npi: undefined }))).toBeNull();
});
// ----- default branch ------------------------------------------
it("returns null for unhandled kinds (manual_match)", () => {
expect(eventKindToUrl(evt({ kind: "manual_match" }))).toBeNull();
});
it("returns null for unknown kinds (defensive default)", () => {
// Cast through unknown so the type-checker doesn't widen the
// literal away from the exhaustive union.
const unknown = { kind: "future_kind" } as unknown as RoutableEvent;
expect(eventKindToUrl(unknown)).toBeNull();
});
});
+55
View File
@@ -0,0 +1,55 @@
import type { Activity } from "@/types";
/**
* The minimum an activity event must carry to be routable. Centralizing
* this here means callers can pass an `Activity` (full feed row) or a
* narrower shape (e.g. a future "activity event" peek payload) both
* satisfy the kind + entity-id fields the helper inspects.
*
* - `claimId` / `remittanceId` come from the backend `ActivityEvent`
* ORM columns (SP21 Task 2.5). `claimId` is set on `claim_*` events;
* `remittanceId` is set on `remit_received`.
* - `npi` is the existing `Activity.npi` field. For `provider_added`
* events the provider NPI IS the entity id (the URL target).
*/
export type RoutableEvent = Pick<
Activity,
"kind" | "claimId" | "remittanceId" | "npi"
>;
/**
* Maps an activity event to the URL the operator should land on when
* clicking the event. Used by:
*
* - Dashboard "Recent activity" card (this PR, Task 2.5).
* - `/activity` log page (Task 2.5 wired here; full integration is
* a later task).
*
* Returns `null` for kinds that don't have a drill target yet, or
* when the entity id field is missing on the event. Callers are
* expected to surface a "coming soon" toast in that case so the click
* still gives feedback.
*/
export function eventKindToUrl(event: RoutableEvent): string | null {
switch (event.kind) {
case "claim_submitted":
case "claim_paid":
case "claim_denied":
case "claim_accepted": {
if (!event.claimId) return null;
return `/claims?claim=${encodeURIComponent(event.claimId)}`;
}
case "remit_received":
// Phase 4 — the `RemitDrawer` isn't built yet; the helper stays
// honest and returns null so the caller's "coming soon" toast
// fires. When the drawer lands, the route becomes
// `/remittances?remit=${encodeURIComponent(event.remittanceId ?? "")}`.
return null;
case "provider_added": {
if (!event.npi) return null;
return `/providers?provider=${encodeURIComponent(event.npi)}`;
}
default:
return null;
}
}
+621 -101
View File
@@ -1,6 +1,11 @@
import { useCallback, useMemo } from "react"; import { useCallback, useMemo } from "react";
import { useSearchParams } from "react-router-dom"; import { useSearchParams } from "react-router-dom";
import { GitCompareArrows, CircleDashed, AlertCircle } from "lucide-react"; import {
AlertCircle,
ArrowRight,
CircleDashed,
GitCompareArrows,
} from "lucide-react";
import { ApiError } from "@/lib/api"; import { ApiError } from "@/lib/api";
import { Button } from "@/components/ui/button"; import { Button } from "@/components/ui/button";
import { import {
@@ -12,7 +17,10 @@ import {
} from "@/components/ui/select"; } from "@/components/ui/select";
import { EmptyState } from "@/components/ui/empty-state"; import { EmptyState } from "@/components/ui/empty-state";
import { ErrorState } from "@/components/ui/error-state"; import { ErrorState } from "@/components/ui/error-state";
import { BatchDiffView, BatchDiffViewSkeleton } from "@/components/BatchDiffView"; import {
BatchDiffView,
BatchDiffViewSkeleton,
} from "@/components/BatchDiffView";
import { useBatches } from "@/hooks/useBatches"; import { useBatches } from "@/hooks/useBatches";
import { useBatchDiff } from "@/hooks/useBatchDiff"; import { useBatchDiff } from "@/hooks/useBatchDiff";
import type { BatchSummary as ApiBatchSummary } from "@/lib/api"; import type { BatchSummary as ApiBatchSummary } from "@/lib/api";
@@ -38,9 +46,11 @@ function readIdsFromParams(params: URLSearchParams): {
} }
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Batch picker — one Select dropdown for each side. Keeps the same // Kind badge — small inline label so the operator can spot which batch
// kind-colored badge inline so the operator can spot which batch is // is which at a glance. Identical contract to the one in
// which at a glance. // `BatchesList.tsx`; duplicated here because each lives inside a
// different page surface (the picker is part of this page, the row
// badge belongs to Batches).
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
function KindBadge({ kind }: { kind: ApiBatchSummary["kind"] }) { function KindBadge({ kind }: { kind: ApiBatchSummary["kind"] }) {
@@ -63,6 +73,7 @@ function KindBadge({ kind }: { kind: ApiBatchSummary["kind"] }) {
function BatchPicker({ function BatchPicker({
label, label,
side,
value, value,
onChange, onChange,
items, items,
@@ -70,6 +81,7 @@ function BatchPicker({
testid, testid,
}: { }: {
label: string; label: string;
side: "A" | "B";
value: string | null; value: string | null;
onChange: (id: string) => void; onChange: (id: string) => void;
items: ApiBatchSummary[]; items: ApiBatchSummary[];
@@ -85,10 +97,54 @@ function BatchPicker({
[items, excludeId], [items, excludeId],
); );
const selected = items.find((it) => it.id === value); const selected = items.find((it) => it.id === value);
const accent = side === "A" ? "hsl(212 100% 45%)" : "hsl(36 92% 50%)";
const tint = side === "A" ? "hsl(212 85% 95%)" : "hsl(36 82% 92%)";
return ( return (
<div className="space-y-1.5" data-testid={testid}> <div
<div className="text-[10.5px] font-semibold uppercase tracking-[0.18em] text-muted-foreground"> className="rounded-xl border p-4 space-y-2"
{label} data-testid={testid}
style={{
backgroundColor: "hsl(36 22% 98%)",
borderColor: "hsl(30 14% 14% / 0.10)",
boxShadow:
"inset 0 1px 0 0 hsl(0 0% 100% / 0.45), 0 1px 0 0 hsl(30 14% 22% / 0.06)",
}}
>
<div
aria-hidden
className="absolute left-0 top-4 bottom-4 w-[3px] rounded-r-sm"
style={{ backgroundColor: accent, opacity: 0.85 }}
/>
<div className="flex items-center justify-between">
<div className="flex items-center gap-2.5">
<div
aria-hidden
className="h-5 w-5 rounded-md flex items-center justify-center mono font-semibold"
style={{ backgroundColor: tint, color: accent, fontSize: 11 }}
>
{side}
</div>
<span
className="mono text-[10.5px] uppercase tracking-[0.18em] font-semibold"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
{label}
</span>
</div>
{selected ? (
<span
className="display tabular-nums text-[12.5px]"
style={{ color: "hsl(var(--surface-ink-2))" }}
>
{selected.claimCount}{" "}
<span
className="mono not-italic uppercase tracking-[0.14em] text-[10px]"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
claims
</span>
</span>
) : null}
</div> </div>
<Select value={value ?? ""} onValueChange={(v) => onChange(v)}> <Select value={value ?? ""} onValueChange={(v) => onChange(v)}>
<SelectTrigger> <SelectTrigger>
@@ -96,7 +152,10 @@ function BatchPicker({
<span className="flex items-center gap-2 truncate"> <span className="flex items-center gap-2 truncate">
<KindBadge kind={selected.kind} /> <KindBadge kind={selected.kind} />
<span className="font-mono num text-[12.5px]">{selected.id}</span> <span className="font-mono num text-[12.5px]">{selected.id}</span>
<span className="text-muted-foreground text-[12px] truncate"> <span
className="text-[12px] truncate"
style={{ color: "hsl(var(--surface-ink-2))" }}
>
· {selected.inputFilename} · {selected.inputFilename}
</span> </span>
</span> </span>
@@ -157,6 +216,50 @@ function NotFoundState({
); );
} }
// ---------------------------------------------------------------------------
// Section header — § N + small italic vertical-rl label. Reused by
// both the picks and diff sections so the folio is uniform.
// ---------------------------------------------------------------------------
function Folio({ section, label, topClass = "top-7" }: {
section: string;
label: string;
topClass?: string;
}) {
return (
<div
aria-hidden
className={cn(
"absolute left-7 lg:left-12 flex flex-col items-center gap-1",
topClass,
)}
>
<span
className="mono text-[10px] uppercase tracking-[0.18em] font-semibold"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
{section}
</span>
<div
className="w-px h-10"
style={{ backgroundColor: "hsl(30 14% 14% / 0.18)" }}
/>
<span
className="display italic"
style={{
color: "hsl(var(--surface-ink-2))",
fontSize: 11,
writingMode: "vertical-rl",
transform: "rotate(180deg)",
letterSpacing: "0.16em",
}}
>
{label}
</span>
</div>
);
}
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Page // Page
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
@@ -193,8 +296,13 @@ export function BatchDiff() {
); );
const reset = useCallback(() => updateIds({ a: null, b: null }), [updateIds]); const reset = useCallback(() => updateIds({ a: null, b: null }), [updateIds]);
const { data: batches, isLoading: loadingBatches, isError: batchesError, error: batchesErrorMsg, refetch: refetchBatches } = const {
useBatches(100); data: batches,
isLoading: loadingBatches,
isError: batchesError,
error: batchesErrorMsg,
refetch: refetchBatches,
} = useBatches(100);
// Only fire the diff once both pickers have a value. The hook also // Only fire the diff once both pickers have a value. The hook also
// gates on this internally (defense-in-depth), so a half-picked URL // gates on this internally (defense-in-depth), so a half-picked URL
@@ -209,112 +317,524 @@ export function BatchDiff() {
: "network" : "network"
: null; : null;
// -----------------------------------------------------------------
// Stagger choreography
// -----------------------------------------------------------------
const heroDelay = 0;
const foldDelay = 220;
const titleDelay = 320;
const picksDelay = 460;
const diffDelay = 600;
// --- render ------------------------------------------------------- // --- render -------------------------------------------------------
return ( return (
<div className="space-y-6 md:space-y-8 animate-fade-in" data-testid="batch-diff-page"> <div
<header> className="space-y-0 animate-fade-in"
<div className="text-[10.5px] font-semibold uppercase tracking-[0.18em] text-muted-foreground mb-2 flex items-center gap-2"> data-testid="batch-diff-page"
<span className="inline-block h-px w-6 bg-border" /> >
Diff {/* =================================================================
HERO DARK EDITORIAL HEADER
================================================================= */}
<section
className="relative pt-6 pb-8 lg:pt-9 lg:pb-10"
style={{ animationDelay: `${heroDelay}ms` }}
>
{/* Ghost "DIFF" watermark — a print-shop stamp behind the title. */}
<div
aria-hidden="true"
className="pointer-events-none select-none absolute inset-x-0 top-[58%] -translate-y-1/2 whitespace-nowrap display text-center"
style={{
fontSize: "clamp(160px, 20vw, 300px)",
letterSpacing: "-0.05em",
opacity: 0.05,
lineHeight: 1,
color: "hsl(var(--surface-ink))",
}}
>
DIFF
</div> </div>
<h1 className="text-[22px] sm:text-[26px] font-semibold tracking-tight">
Batch diff
</h1>
<p className="text-muted-foreground mt-1.5 text-[14px]">
Pick two parsed batches typically a submitted 837P and its
corrected follow-up and see what was added, removed, or changed
between them.
</p>
</header>
<div className="surface rounded-xl p-4 grid grid-cols-1 md:grid-cols-2 gap-3 md:gap-4"> <div className="relative z-10 grid grid-cols-1 lg:grid-cols-[1fr,auto] gap-8 items-end mb-7">
<BatchPicker <div className="min-w-0 max-w-3xl">
label="A · left" <div className="flex items-center gap-3 mb-5">
value={a} <div className="h-px w-14 bg-foreground/25" />
onChange={setA} <span className="mono text-[12px] uppercase tracking-[0.22em] text-muted-foreground">
items={batches ?? []} Diff · Sheet 01
excludeId={b} </span>
testid="diff-picker-a" <span
className="mono text-[12px] uppercase tracking-[0.22em] text-muted-foreground/60 hidden sm:inline"
aria-hidden
>
· A vs B
</span>
</div>
<h1 className="display text-[48px] sm:text-[64px] lg:text-[80px] leading-[0.92] text-foreground tracking-[-0.04em]">
Compare{" "}
<span className="italic text-muted-foreground/85">batches.</span>
</h1>
</div>
<div className="flex flex-col items-start lg:items-end gap-3">
<div className="inline-flex items-center gap-2 rounded-full border border-border/60 bg-card/60 px-3.5 py-2 text-[11.5px] mono uppercase tracking-[0.14em] text-muted-foreground backdrop-blur">
<GitCompareArrows
className="h-3.5 w-3.5"
strokeWidth={1.75}
style={{ color: "hsl(var(--accent))" }}
/>
837P · 835 · first vs second
</div>
<kbd
className="mono text-[10.5px] uppercase tracking-[0.18em] text-muted-foreground/70"
>
Pick a batch for each side
</kbd>
</div>
</div>
<div className="relative z-10 max-w-2xl">
<p className="text-[14px] text-muted-foreground leading-relaxed">
Pick two parsed batches typically a submitted 837P and its
corrected follow-up and see what was added, removed, or changed
between them.
</p>
</div>
</section>
{/* =================================================================
FOLD TORN PAGE
================================================================= */}
<div
aria-hidden
className="relative h-14"
style={{ animationDelay: `${foldDelay}ms` }}
>
<div
className="absolute inset-x-0 top-0 h-1/2"
style={{
background:
"linear-gradient(to bottom, hsl(0 0% 0% / 0.55), transparent)",
}}
/> />
<BatchPicker <div
label="B · right" className="absolute inset-x-0 bottom-0 h-1/2"
value={b} style={{
onChange={setB} background:
items={batches ?? []} "linear-gradient(to top, hsl(30 14% 14% / 0.18), transparent)",
excludeId={a} }}
testid="diff-picker-b"
/> />
<div
className="absolute inset-x-0 top-1/2 -translate-y-1/2 h-px"
style={{
background:
"linear-gradient(to right, transparent, hsl(30 14% 14% / 0.5) 12%, hsl(30 14% 14% / 0.7) 50%, hsl(30 14% 14% / 0.5) 88%, transparent)",
}}
/>
<div
className="absolute inset-x-0 top-1/2 -translate-y-1/2 flex justify-between px-2"
style={{ pointerEvents: "none" }}
>
{Array.from({ length: 48 }, (_, i) => (
<span
key={i}
className="block h-[3px] w-[3px] rounded-full"
style={{ backgroundColor: "hsl(30 14% 14% / 0.22)" }}
/>
))}
</div>
<div className="relative z-10 mx-auto h-full flex items-center justify-center gap-3 bg-background px-4 w-fit">
<span
className="display italic"
style={{ color: "hsl(var(--muted-foreground))", fontSize: 15 }}
>
</span>
<span
className="mono uppercase tracking-[0.24em]"
style={{
color: "hsl(var(--muted-foreground))",
fontSize: 11,
fontWeight: 500,
}}
>
A B
</span>
<span
className="display italic"
style={{ color: "hsl(var(--muted-foreground))", fontSize: 15 }}
>
</span>
</div>
</div> </div>
{batchesError ? ( {/* =================================================================
<ErrorState PAPER PLANE
message="Couldn't load batches from the backend." ================================================================= */}
detail={ <div
batchesErrorMsg instanceof Error className="relative max-w-[1280px] mx-auto"
? batchesErrorMsg.message style={{
: String(batchesErrorMsg) animationDelay: `${titleDelay}ms`,
} backgroundColor: "hsl(var(--surface))",
onRetry={() => refetchBatches()} boxShadow:
"inset 0 1px 0 0 hsl(0 0% 100% / 0.5), 0 1px 0 0 hsl(30 14% 22% / 0.06), 0 30px 80px -24px hsl(0 0% 0% / 0.45)",
}}
>
{/* Paper grain */}
<div
aria-hidden
className="pointer-events-none absolute inset-0 opacity-[0.04]"
style={{
backgroundImage:
"url(\"data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='160' height='160'><filter id='n'><feTurbulence type='fractalNoise' baseFrequency='0.9' numOctaves='2' stitchTiles='stitch'/><feColorMatrix values='0 0 0 0 0.1 0 0 0 0 0.08 0 0 0 0 0.05 0 0 0 0.9 0'/></filter><rect width='100%' height='100%' filter='url(%23n)'/></svg>\")",
backgroundSize: "160px 160px",
mixBlendMode: "multiply",
}}
/> />
) : null}
{!ready ? ( {/* Title block */}
<div className="surface rounded-xl"> <div
<EmptyState className="relative px-8 lg:px-14 pt-12 pb-9 border-b animate-fade-in-up"
icon={<GitCompareArrows className="h-4 w-4" strokeWidth={1.5} />} style={{
eyebrow="Batch diff · awaiting picks" animationDelay: `${titleDelay}ms`,
message="Choose one batch for A and one for B to compute the diff." borderColor: "hsl(30 14% 14% / 0.12)",
}}
>
<div
aria-hidden
className="absolute left-7 lg:left-12 top-0 bottom-0 w-px"
style={{ backgroundColor: "hsl(30 14% 14% / 0.14)" }}
/> />
<div className="flex items-end justify-between gap-8 flex-wrap">
<div>
<div
className="mono text-[12px] uppercase tracking-[0.24em] mb-4 font-medium"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
Sheet 01 · Compare two batches
</div>
<h2
className="display leading-[0.92] tracking-[-0.04em]"
style={{
color: "hsl(var(--surface-ink))",
fontSize: "clamp(48px, 7vw, 96px)",
fontWeight: 400,
}}
>
Compare them.
</h2>
<div
className="mt-4 display italic"
style={{
color: "hsl(var(--surface-ink-2))",
fontSize: "clamp(15px, 1.3vw, 18px)",
lineHeight: 1.4,
maxWidth: "32ch",
}}
>
Two picks, three buckets. What the second batch added, what
the first batch dropped, and which claims moved between them.
</div>
</div>
<div className="text-right shrink-0">
<div
className="mono text-[11px] uppercase tracking-[0.24em] mb-1.5 font-medium"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
On the wire
</div>
<div
className="flex items-center justify-end gap-2 tabular-nums"
style={{
color: "hsl(var(--surface-ink))",
fontSize: 26,
lineHeight: 1.1,
}}
>
<span
className="display"
style={{ color: a ? "hsl(212 100% 45%)" : "hsl(var(--surface-ink-3))" }}
>
{a ? "A" : "—"}
</span>
<ArrowRight
className="h-4 w-4 mt-0.5"
strokeWidth={1.5}
style={{ color: "hsl(var(--surface-ink-3))" }}
/>
<span
className="display"
style={{ color: b ? "hsl(36 92% 50%)" : "hsl(var(--surface-ink-3))" }}
>
{b ? "B" : "—"}
</span>
</div>
<div
className="mono text-[11px] mt-1"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
{ready ? "ready to diff" : "two picks needed"}
</div>
</div>
</div>
</div> </div>
) : loadingBatches ? (
<BatchDiffViewSkeleton />
) : errKind === "not_found" ? (
<NotFoundState a={a as string} b={b as string} onReset={reset} />
) : diff.isError ? (
<ErrorState
message="Couldn't compute the diff between these two batches."
detail={
diff.error instanceof Error
? diff.error.message
: String(diff.error)
}
onRetry={() => diff.refetch()}
/>
) : diff.isLoading || !diff.data ? (
<BatchDiffViewSkeleton />
) : (
<BatchDiffView data={diff.data} />
)}
{/* Action footer always visible so the operator can clear or {/* § 01 The picks */}
force-refresh without scrolling back to the picker. */} <section
{ready ? ( aria-label="The picks"
<div className="flex items-center justify-end gap-2 pt-2"> className="relative px-8 lg:px-14 py-7 animate-fade-in-up"
{diff.isFetching ? ( style={{ animationDelay: `${picksDelay}ms` }}
<span className="text-[12px] text-muted-foreground inline-flex items-center gap-1.5"> >
<CircleDashed className="h-3 w-3 animate-spin" strokeWidth={1.75} /> <Folio section="§ 01" label="The picks" />
Refreshing <div
</span> className="pt-6 border-t"
) : null} style={{
<Button borderTopStyle: "double",
variant="outline" borderTopWidth: 3,
size="sm" borderColor: "hsl(30 14% 14% / 0.12)",
onClick={() => diff.refetch()} }}
data-testid="diff-refresh-button"
> >
Refresh <div className="flex items-end justify-between gap-6 flex-wrap mb-5">
</Button> <div>
<Button <div
variant="ghost" className="mono text-[11.5px] uppercase tracking-[0.24em] font-semibold mb-2"
size="sm" style={{ color: "hsl(var(--surface-ink-3))" }}
onClick={reset} >
data-testid="diff-clear-button" The picks
</div>
<h3
className="display leading-[0.98] tracking-[-0.03em]"
style={{
color: "hsl(var(--surface-ink))",
fontSize: "clamp(24px, 2.6vw, 32px)",
fontWeight: 400,
}}
>
One on each <span className="italic">side.</span>
</h3>
</div>
<div
className="text-[12.5px] display italic"
style={{ color: "hsl(var(--surface-ink-2))", maxWidth: 380 }}
>
A is the "before" B is the "after". A picked batch can't
be picked again on the other side.
</div>
</div>
<div className="relative grid grid-cols-1 md:grid-cols-2 gap-4">
<BatchPicker
label="A · left"
side="A"
value={a}
onChange={setA}
items={batches ?? []}
excludeId={b}
testid="diff-picker-a"
/>
<BatchPicker
label="B · right"
side="B"
value={b}
onChange={setB}
items={batches ?? []}
excludeId={a}
testid="diff-picker-b"
/>
</div>
</div>
</section>
{/* § 02 The diff */}
<section
aria-label="The diff"
className="relative px-8 lg:px-14 pb-8 lg:pb-10 animate-fade-in-up"
style={{ animationDelay: `${diffDelay}ms` }}
>
<Folio section="§ 02" label="The diff" topClass="top-9" />
<div
className="pt-6 border-t"
style={{
borderTopStyle: "double",
borderTopWidth: 3,
borderColor: "hsl(30 14% 14% / 0.12)",
}}
> >
<AlertCircle className="h-3.5 w-3.5 mr-1" strokeWidth={1.75} /> <div className="flex items-end justify-between gap-6 flex-wrap mb-5">
Clear picks <div>
</Button> <div
className="mono text-[11.5px] uppercase tracking-[0.24em] font-semibold mb-2"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
The diff
</div>
<h3
className="display leading-[0.98] tracking-[-0.03em]"
style={{
color: "hsl(var(--surface-ink))",
fontSize: "clamp(24px, 2.6vw, 32px)",
fontWeight: 400,
}}
>
What <span className="italic">moved.</span>
</h3>
</div>
{ready ? (
<div
className="text-[12.5px] display italic"
style={{
color: "hsl(var(--surface-ink-2))",
maxWidth: 380,
}}
>
Three buckets added in B, removed from A, changed in
place. Unchanged claims are summarized but not listed.
</div>
) : null}
</div>
{batchesError ? (
<div
className="rounded-md border p-5"
style={{
borderColor: "hsl(30 14% 14% / 0.16)",
backgroundColor: "hsl(36 22% 96%)",
}}
>
<ErrorState
message="Couldn't load batches from the backend."
detail={
batchesErrorMsg instanceof Error
? batchesErrorMsg.message
: String(batchesErrorMsg)
}
onRetry={() => refetchBatches()}
/>
</div>
) : !ready ? (
<div
className="rounded-md border p-12 text-center"
style={{
borderColor: "hsl(30 14% 14% / 0.16)",
borderStyle: "dashed",
backgroundColor: "hsl(36 22% 96%)",
}}
data-testid="batch-diff-awaiting"
>
<EmptyState
icon={
<GitCompareArrows
className="h-4 w-4"
strokeWidth={1.5}
/>
}
eyebrow="Batch diff · awaiting picks"
message="Choose one batch for A and one for B to compute the diff."
/>
</div>
) : loadingBatches ? (
<BatchDiffViewSkeleton />
) : errKind === "not_found" ? (
<NotFoundState a={a as string} b={b as string} onReset={reset} />
) : diff.isError ? (
<div
className="rounded-md border p-5"
style={{
borderColor: "hsl(30 14% 14% / 0.16)",
backgroundColor: "hsl(36 22% 96%)",
}}
>
<ErrorState
message="Couldn't compute the diff between these two batches."
detail={
diff.error instanceof Error
? diff.error.message
: String(diff.error)
}
onRetry={() => diff.refetch()}
/>
</div>
) : diff.isLoading || !diff.data ? (
<BatchDiffViewSkeleton />
) : (
<BatchDiffView data={diff.data} />
)}
</div>
</section>
{/* Action footer always visible when ready so the operator can
clear or force-refresh without scrolling back to the picker. */}
{ready ? (
<div
className="relative px-8 lg:px-14 py-5 border-t flex items-center justify-between gap-3 flex-wrap"
style={{
borderColor: "hsl(30 14% 14% / 0.12)",
}}
>
<div
className="text-[12.5px] display italic"
style={{ color: "hsl(var(--surface-ink-2))" }}
>
{diff.isFetching ? (
<span className="inline-flex items-center gap-1.5">
<CircleDashed
className="h-3 w-3 animate-spin"
strokeWidth={1.75}
/>
Refreshing
</span>
) : (
<>
Comparing{" "}
<span
className="display mono not-italic"
style={{ color: "hsl(var(--surface-ink))" }}
>
{a}
</span>{" "}
with{" "}
<span
className="display mono not-italic"
style={{ color: "hsl(var(--surface-ink))" }}
>
{b}
</span>
.
</>
)}
</div>
<div className="flex items-center gap-2 flex-wrap">
<Button
variant="outline"
size="sm"
onClick={() => diff.refetch()}
data-testid="diff-refresh-button"
>
Refresh
</Button>
<Button
variant="ghost"
size="sm"
onClick={reset}
data-testid="diff-clear-button"
>
<AlertCircle className="h-3.5 w-3.5 mr-1" strokeWidth={1.75} />
Clear picks
</Button>
</div>
</div>
) : null}
{/* Footer */}
<div
className="relative px-8 lg:px-14 py-5 border-t flex items-center justify-between mono text-[10.5px] uppercase tracking-[0.18em]"
style={{
borderColor: "hsl(30 14% 14% / 0.12)",
color: "hsl(var(--surface-ink-3))",
}}
>
<span>End of sheet 01</span>
<span>Cyclone · Batch diff</span>
<span>{ready ? "A vs B" : "awaiting picks"}</span>
</div> </div>
) : null} </div>
</div> </div>
); );
} }
+558 -23
View File
@@ -1,9 +1,10 @@
import { useCallback, useEffect, useMemo, useState } from "react"; import { useCallback, useEffect, useMemo, useState } from "react";
import { useQuery } from "@tanstack/react-query"; import { useQuery } from "@tanstack/react-query";
import { Files, GitBranch, Layers, Receipt } from "lucide-react";
import { Dialog, DialogContent } from "@/components/ui/dialog"; import { Dialog, DialogContent } from "@/components/ui/dialog";
import { EmptyState } from "@/components/ui/empty-state"; import { EmptyState } from "@/components/ui/empty-state";
import { ErrorState } from "@/components/ui/error-state"; import { ErrorState } from "@/components/ui/error-state";
import { PageHeader } from "@/components/PageHeader"; import { Skeleton } from "@/components/ui/skeleton";
import { BatchesList, BatchesListSkeleton } from "@/components/BatchesList"; import { BatchesList, BatchesListSkeleton } from "@/components/BatchesList";
import { import {
BatchDetailContent, BatchDetailContent,
@@ -118,6 +119,14 @@ function useBatchDetail(id: string | null): {
const HELP_NOOP = () => {}; const HELP_NOOP = () => {};
/**
* Batches page hybrid Magazine Spread treatment.
*
* Dark editorial hero torn-page fold cream paper plane with the
* batch register (KPI strip + tabular list). Click a row to open the
* detail drawer (rendered above the page, dimmed via the body
* opacity).
*/
export function Batches() { export function Batches() {
const { data, isLoading, isError, error, refetch } = useBatches(100); const { data, isLoading, isError, error, refetch } = useBatches(100);
const items: BatchSummary[] = data ?? []; const items: BatchSummary[] = data ?? [];
@@ -156,6 +165,28 @@ export function Batches() {
const dimBackground = batchId !== null; const dimBackground = batchId !== null;
const errKind = batchErrorKind(detailError); const errKind = batchErrorKind(detailError);
// -----------------------------------------------------------------
// Aggregate metrics for the § 01 KPI strip
// -----------------------------------------------------------------
const totals = items.reduce(
(acc, b) => ({
count: acc.count + 1,
p837: acc.p837 + (b.kind === "837p" ? 1 : 0),
p835: acc.p835 + (b.kind === "835" ? 1 : 0),
claims: acc.claims + b.claimCount,
}),
{ count: 0, p837: 0, p835: 0, claims: 0 },
);
// -----------------------------------------------------------------
// Stagger choreography (matches Acks / Reconciliation / Upload)
// -----------------------------------------------------------------
const heroDelay = 0;
const foldDelay = 220;
const titleDelay = 320;
const kpiDelay = 460;
const tableDelay = 600;
return ( return (
<> <>
<Dialog <Dialog
@@ -188,37 +219,541 @@ export function Batches() {
<div <div
data-testid="batches-page-body" data-testid="batches-page-body"
className={cn( className={cn(
"space-y-6 lg:space-y-8 animate-fade-in transition-opacity", "space-y-0 animate-fade-in transition-opacity",
dimBackground && "pointer-events-none opacity-60", dimBackground && "pointer-events-none opacity-60",
)} )}
> >
<PageHeader {/* =================================================================
eyebrow="Batches" HERO DARK EDITORIAL HEADER
title={<>Parsed <span className="display italic text-muted-foreground">batches</span></>} ================================================================= */}
subtitle="Every 837P and 835 file the backend has ingested. Click a row for envelope, summary, and a peek at the contained claims." <section
/> className="relative pt-6 pb-8 lg:pt-9 lg:pb-10"
style={{ animationDelay: `${heroDelay}ms` }}
>
{/* Ghost "PARSED" watermark — a print-shop stamp behind the title. */}
<div
aria-hidden="true"
className="pointer-events-none select-none absolute inset-x-0 top-[58%] -translate-y-1/2 whitespace-nowrap display text-center"
style={{
fontSize: "clamp(160px, 20vw, 300px)",
letterSpacing: "-0.05em",
opacity: 0.05,
lineHeight: 1,
color: "hsl(var(--surface-ink))",
}}
>
PARSED
</div>
{isError ? ( <div className="relative z-10 grid grid-cols-1 lg:grid-cols-[1fr,auto] gap-8 items-end mb-7">
<ErrorState <div className="min-w-0 max-w-3xl">
message="Couldn't load batches from the backend." <div className="flex items-center gap-3 mb-5">
detail={error instanceof Error ? error.message : String(error)} <div className="h-px w-14 bg-foreground/25" />
onRetry={() => refetch()} <span className="mono text-[12px] uppercase tracking-[0.22em] text-muted-foreground">
Batches · Register
</span>
<span
className="mono text-[12px] uppercase tracking-[0.22em] text-muted-foreground/60 hidden sm:inline"
aria-hidden
>
· {totals.count} on file
</span>
</div>
<h1 className="display text-[48px] sm:text-[64px] lg:text-[80px] leading-[0.92] text-foreground tracking-[-0.04em]">
Parsed{" "}
<span className="italic text-muted-foreground/85">batches.</span>
</h1>
</div>
<div className="flex flex-col items-start lg:items-end gap-3">
<div className="inline-flex items-center gap-2 rounded-full border border-border/60 bg-card/60 px-3.5 py-2 text-[11.5px] mono uppercase tracking-[0.14em] text-muted-foreground backdrop-blur">
<Files
className="h-3.5 w-3.5"
strokeWidth={1.75}
style={{ color: "hsl(var(--accent))" }}
/>
837P · 835 · envelope & summary
</div>
<kbd
className="mono text-[10.5px] uppercase tracking-[0.18em] text-muted-foreground/70"
>
Tap a row to open the drawer
</kbd>
</div>
</div>
<div className="relative z-10 max-w-2xl">
<p className="text-[14px] text-muted-foreground leading-relaxed">
Every 837P and 835 file the backend has ingested. Click a row
for envelope, summary, and a peek at the contained claims.
</p>
</div>
</section>
{/* =================================================================
FOLD TORN PAGE
================================================================= */}
<div
aria-hidden
className="relative h-14"
style={{ animationDelay: `${foldDelay}ms` }}
>
<div
className="absolute inset-x-0 top-0 h-1/2"
style={{
background:
"linear-gradient(to bottom, hsl(0 0% 0% / 0.55), transparent)",
}}
/> />
) : null} <div
className="absolute inset-x-0 bottom-0 h-1/2"
style={{
background:
"linear-gradient(to top, hsl(30 14% 14% / 0.18), transparent)",
}}
/>
<div
className="absolute inset-x-0 top-1/2 -translate-y-1/2 h-px"
style={{
background:
"linear-gradient(to right, transparent, hsl(30 14% 14% / 0.5) 12%, hsl(30 14% 14% / 0.7) 50%, hsl(30 14% 14% / 0.5) 88%, transparent)",
}}
/>
<div
className="absolute inset-x-0 top-1/2 -translate-y-1/2 flex justify-between px-2"
style={{ pointerEvents: "none" }}
>
{Array.from({ length: 48 }, (_, i) => (
<span
key={i}
className="block h-[3px] w-[3px] rounded-full"
style={{ backgroundColor: "hsl(30 14% 14% / 0.22)" }}
/>
))}
</div>
<div className="relative z-10 mx-auto h-full flex items-center justify-center gap-3 bg-background px-4 w-fit">
<span
className="display italic"
style={{ color: "hsl(var(--muted-foreground))", fontSize: 15 }}
>
</span>
<span
className="mono uppercase tracking-[0.24em]"
style={{
color: "hsl(var(--muted-foreground))",
fontSize: 11,
fontWeight: 500,
}}
>
The register
</span>
<span
className="display italic"
style={{ color: "hsl(var(--muted-foreground))", fontSize: 15 }}
>
</span>
</div>
</div>
<div className="surface rounded-xl overflow-hidden"> {/* =================================================================
{isLoading ? ( PAPER PLANE
<BatchesListSkeleton /> ================================================================= */}
) : items.length === 0 ? ( <div
<EmptyState className="relative max-w-[1280px] mx-auto"
eyebrow="Batches · awaiting first ingest" style={{
message="Upload an 837P or 835 file on the Upload page to populate this list." animationDelay: `${titleDelay}ms`,
backgroundColor: "hsl(var(--surface))",
boxShadow:
"inset 0 1px 0 0 hsl(0 0% 100% / 0.5), 0 1px 0 0 hsl(30 14% 22% / 0.06), 0 30px 80px -24px hsl(0 0% 0% / 0.45)",
}}
>
{/* Paper grain */}
<div
aria-hidden
className="pointer-events-none absolute inset-0 opacity-[0.04]"
style={{
backgroundImage:
"url(\"data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='160' height='160'><filter id='n'><feTurbulence type='fractalNoise' baseFrequency='0.9' numOctaves='2' stitchTiles='stitch'/><feColorMatrix values='0 0 0 0 0.1 0 0 0 0 0.08 0 0 0 0 0.05 0 0 0 0.9 0'/></filter><rect width='100%' height='100%' filter='url(%23n)'/></svg>\")",
backgroundSize: "160px 160px",
mixBlendMode: "multiply",
}}
/>
{/* Title block */}
<div
className="relative px-8 lg:px-14 pt-12 pb-9 border-b animate-fade-in-up"
style={{
animationDelay: `${titleDelay}ms`,
borderColor: "hsl(30 14% 14% / 0.12)",
}}
>
<div
aria-hidden
className="absolute left-7 lg:left-12 top-0 bottom-0 w-px"
style={{ backgroundColor: "hsl(30 14% 14% / 0.14)" }}
/> />
) : ( <div className="flex items-end justify-between gap-8 flex-wrap">
<BatchesList items={items} openId={batchId} onOpen={open} /> <div>
)} <div
className="mono text-[12px] uppercase tracking-[0.24em] mb-4 font-medium"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
Register · Parsed batches
</div>
<h2
className="display leading-[0.92] tracking-[-0.04em]"
style={{
color: "hsl(var(--surface-ink))",
fontSize: "clamp(48px, 7vw, 96px)",
fontWeight: 400,
}}
>
The register.
</h2>
<div
className="mt-4 display italic"
style={{
color: "hsl(var(--surface-ink-2))",
fontSize: "clamp(15px, 1.3vw, 18px)",
lineHeight: 1.4,
maxWidth: "32ch",
}}
>
One row per ingested file the kind, the input filename,
how many claims it carried, and the day it was parsed.
</div>
</div>
<div className="text-right shrink-0">
<div
className="mono text-[11px] uppercase tracking-[0.24em] mb-1.5 font-medium"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
On file
</div>
<div
className="display tabular-nums"
style={{
color: "hsl(var(--surface-ink))",
fontSize: 26,
lineHeight: 1.1,
}}
>
{totals.count}
</div>
<div
className="mono text-[11px] mt-1"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
batch{totals.count === 1 ? "" : "es"} · {totals.claims}{" "}
claim{totals.claims === 1 ? "" : "s"}
</div>
</div>
</div>
</div>
{/* KPI strip — § 01 Vital signs */}
<section
aria-label="Batch register metrics"
className="relative px-8 lg:px-14 py-7 animate-fade-in-up"
style={{ animationDelay: `${kpiDelay}ms` }}
>
<div
aria-hidden
className="absolute left-7 lg:left-12 top-7 flex flex-col items-center gap-1"
>
<span
className="mono text-[10px] uppercase tracking-[0.18em] font-semibold"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
§ 01
</span>
<div
className="w-px h-10"
style={{ backgroundColor: "hsl(30 14% 14% / 0.18)" }}
/>
<span
className="display italic"
style={{
color: "hsl(var(--surface-ink-2))",
fontSize: 11,
writingMode: "vertical-rl",
transform: "rotate(180deg)",
letterSpacing: "0.16em",
}}
>
Vital signs
</span>
</div>
<div className="grid grid-cols-2 md:grid-cols-4 gap-4">
<BatchesKpiTile
label="On file"
value={totals.count}
icon={<Layers className="h-3 w-3" strokeWidth={1.75} />}
tone="ink"
/>
<BatchesKpiTile
label="837P"
value={totals.p837}
icon={<GitBranch className="h-3 w-3" strokeWidth={1.75} />}
tone="blue"
/>
<BatchesKpiTile
label="835"
value={totals.p835}
icon={<Receipt className="h-3 w-3" strokeWidth={1.75} />}
tone="amber"
/>
<BatchesKpiTile
label="Claims"
value={totals.claims}
tone="success"
/>
</div>
</section>
{/* Table — § 02 The register */}
<section
aria-label="Batch register"
className="relative px-8 lg:px-14 pb-8 lg:pb-10 animate-fade-in-up"
style={{ animationDelay: `${tableDelay}ms` }}
>
<div
aria-hidden
className="absolute left-7 lg:left-12 top-9 flex flex-col items-center gap-1"
>
<span
className="mono text-[10px] uppercase tracking-[0.18em] font-semibold"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
§ 02
</span>
<div
className="w-px h-12"
style={{ backgroundColor: "hsl(30 14% 14% / 0.18)" }}
/>
<span
className="display italic"
style={{
color: "hsl(var(--surface-ink-2))",
fontSize: 11,
writingMode: "vertical-rl",
transform: "rotate(180deg)",
letterSpacing: "0.16em",
}}
>
The register
</span>
</div>
<div
className="pt-6 border-t"
style={{
borderTopStyle: "double",
borderTopWidth: 3,
borderColor: "hsl(30 14% 14% / 0.12)",
}}
>
<div className="flex items-end justify-between gap-6 flex-wrap mb-5">
<div>
<div
className="mono text-[11.5px] uppercase tracking-[0.24em] font-semibold mb-2"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
The register
</div>
<h3
className="display leading-[0.98] tracking-[-0.03em]"
style={{
color: "hsl(var(--surface-ink))",
fontSize: "clamp(24px, 2.6vw, 32px)",
fontWeight: 400,
}}
>
All <span className="italic">ingests</span>, newest first.
</h3>
</div>
<div
className="text-[12.5px] display italic"
style={{ color: "hsl(var(--surface-ink-2))", maxWidth: 380 }}
>
Tap a row to open the envelope drawer. Use{" "}
<kbd
className="mono not-italic text-[10.5px] uppercase tracking-[0.14em] px-1 py-0.5 rounded-sm border"
style={{
borderColor: "hsl(30 14% 14% / 0.20)",
color: "hsl(var(--surface-ink))",
}}
>
</kbd>{" "}
/{" "}
<kbd
className="mono not-italic text-[10.5px] uppercase tracking-[0.14em] px-1 py-0.5 rounded-sm border"
style={{
borderColor: "hsl(30 14% 14% / 0.20)",
color: "hsl(var(--surface-ink))",
}}
>
</kbd>{" "}
inside the drawer to step.
</div>
</div>
{isError ? (
<div
className="rounded-md border p-5"
style={{
borderColor: "hsl(30 14% 14% / 0.16)",
backgroundColor: "hsl(36 22% 96%)",
}}
>
<ErrorState
message="Couldn't load batches from the backend."
detail={error instanceof Error ? error.message : String(error)}
onRetry={() => refetch()}
/>
</div>
) : isLoading ? (
<div
className="rounded-md border p-4 space-y-2"
style={{
borderColor: "hsl(30 14% 14% / 0.10)",
backgroundColor: "hsl(36 22% 96%)",
}}
>
<BatchesListSkeleton />
</div>
) : items.length === 0 ? (
<div
className="rounded-md border p-10 text-center"
style={{
borderColor: "hsl(30 14% 14% / 0.16)",
borderStyle: "dashed",
backgroundColor: "hsl(36 22% 96%)",
}}
>
<EmptyState
eyebrow="Batches · awaiting first ingest"
message="Upload an 837P or 835 file on the Upload page to populate this list."
/>
</div>
) : (
<div
className="rounded-md border overflow-hidden"
style={{
borderColor: "hsl(30 14% 14% / 0.10)",
backgroundColor: "hsl(36 22% 98%)",
boxShadow:
"inset 0 1px 0 0 hsl(0 0% 100% / 0.5)",
}}
>
<BatchesList
items={items}
openId={batchId}
onOpen={open}
tone="paper"
/>
</div>
)}
</div>
</section>
{/* Footer */}
<div
className="relative px-8 lg:px-14 py-5 border-t flex items-center justify-between mono text-[10.5px] uppercase tracking-[0.18em]"
style={{
borderColor: "hsl(30 14% 14% / 0.12)",
color: "hsl(var(--surface-ink-3))",
}}
>
<span>End of register</span>
<span>Cyclone · Batches</span>
<span>
{totals.count} {totals.count === 1 ? "row" : "rows"}
</span>
</div>
</div> </div>
</div> </div>
</> </>
); );
} }
// ---------------------------------------------------------------------------
// BatchesKpiTile — paper-toned metric for the batch register.
// Mirrors AckKpiTile / KpiTile in the other hybrid pages.
// ---------------------------------------------------------------------------
function BatchesKpiTile({
label,
value,
tone,
icon,
}: {
label: string;
value: number;
tone: "blue" | "amber" | "ink" | "success";
icon?: React.ReactNode;
}) {
const accentMap = {
blue: "hsl(212 100% 45%)",
amber: "hsl(36 92% 50%)",
ink: "hsl(var(--surface-ink))",
success: "hsl(152 64% 38%)",
} as const;
const tintMap = {
blue: "hsl(212 85% 92%)",
amber: "hsl(36 82% 92%)",
ink: "hsl(36 22% 90%)",
success: "hsl(152 50% 88%)",
} as const;
const accent = accentMap[tone];
const tint = tintMap[tone];
return (
<div
className="relative rounded-xl p-5 overflow-hidden border"
style={{
backgroundColor: "hsl(var(--surface))",
boxShadow:
"inset 0 1px 0 0 hsl(0 0% 100% / 0.45), 0 1px 0 0 hsl(30 14% 22% / 0.06), inset 3px 0 0 0 hsl(0 0% 100% / 0.4)",
borderColor: "hsl(30 14% 14% / 0.10)",
}}
>
<div
aria-hidden
className="absolute left-0 top-5 bottom-5 w-[3px] rounded-r-sm"
style={{ backgroundColor: accent, opacity: 0.85 }}
/>
<div className="flex items-center justify-between mb-2.5">
<div
className="mono text-[10px] uppercase tracking-[0.18em] font-semibold"
style={{ color: "hsl(var(--surface-ink-3))" }}
>
{label}
</div>
<div
className="h-5 w-5 rounded-md flex items-center justify-center"
style={{ backgroundColor: tint, color: accent }}
>
{icon ?? (
<span
className="block h-1.5 w-1.5 rounded-full"
style={{ backgroundColor: accent }}
/>
)}
</div>
</div>
<div
className="display tabular-nums tracking-[-0.04em]"
style={{
color: "hsl(var(--surface-ink))",
fontSize: "clamp(28px, 3vw, 40px)",
lineHeight: 1,
fontWeight: 400,
}}
>
{value}
</div>
</div>
);
}
+63
View File
@@ -699,4 +699,67 @@ describe("Claims page drawer wiring", () => {
unmount(); unmount();
}); });
// -------------------------------------------------------------------
// Regression for SP21 Task 2.4 — DrillableCell click bubbling.
//
// The provider cell renders a <button> (via DrillableCell) inside a
// <TableRow onClick={() => open(c.id)}>. Before the fix, clicking the
// provider button (1) navigated to /providers?provider=… and then
// (2) bubbled to the row, where open() rebuilt the URL on top of the
// new /providers URL and appended a phantom ?claim=CLM-1. The page
// mounted on /providers, but the URL was a Frankenstein of both
// nav states and the browser history was polluted with two entries
// per click.
//
// We assert the URL after a provider-cell click does NOT carry
// ?claim=. The fix lives in DrillableCell (stopPropagation), so this
// is an end-to-end check that the component-level guard closes the
// bubble all the way back at the row.
//
// Note on MemoryRouter: react-router's `navigate()` updates the
// router's internal history but does NOT push to window.history, so
// `window.location.href` in this test stays on `/claims`. That's
// still the right place to assert "no phantom claim= param landed on
// window.history" — that's where the bug manifested (buildUrl() in
// the row's open() reads window.location and pushState's the bad
// URL). In a real BrowserRouter the URL would advance to /providers
// after navigate(), and the same assertion holds: ?claim= would be
// absent.
// -------------------------------------------------------------------
it("test_clicking_provider_cell_navigates_without_pushing_claim_param", async () => {
const { unmount } = renderClaims();
// Wait for the table to populate from the mocked api.listClaims.
await settle(
() => document.body.textContent?.includes("CLM-1") ?? false,
);
// Both SAMPLE_CLAIMS use providerNpi "1234567890", which doesn't
// match any seeded sampleProvider, so the aria-label falls through
// to `View provider 1234567890`. Pick the first matching button.
const btn = Array.from(document.querySelectorAll("button")).find(
(b) =>
b.getAttribute("aria-label")?.startsWith("View provider ") ?? false,
) as HTMLButtonElement | undefined;
expect(btn).toBeDefined();
// Sanity: row's claim-param is not in the URL before the click.
expect(window.location.href).not.toContain("claim=");
// Click it. With the fix, the click handler stops propagation before
// the row's onClick can fire. Without the fix, the row's open()
// would push a phantom ?claim=CLM-1 onto window.history.
await act(async () => {
btn!.click();
});
// The URL must not carry a ?claim= param. buildUrl() inside open()
// would have added that param if the click had bubbled to the row.
// (See the MemoryRouter note above for why we don't also assert
// on /providers here.)
expect(window.location.href).not.toContain("claim=");
unmount();
});
}); });
+24 -5
View File
@@ -1,5 +1,5 @@
import { useEffect, useMemo, useRef, useState } from "react"; import { useEffect, useMemo, useRef, useState } from "react";
import { useSearchParams } from "react-router-dom"; import { useNavigate, useSearchParams } from "react-router-dom";
import { Search, X } from "lucide-react"; import { Search, X } from "lucide-react";
import { Input } from "@/components/ui/input"; import { Input } from "@/components/ui/input";
import { import {
@@ -29,6 +29,7 @@ import { Pagination } from "@/components/ui/pagination";
import { PageHeader } from "@/components/PageHeader"; import { PageHeader } from "@/components/PageHeader";
import { useClaims } from "@/hooks/useClaims"; import { useClaims } from "@/hooks/useClaims";
import { useDrawerUrlState } from "@/hooks/useDrawerUrlState"; import { useDrawerUrlState } from "@/hooks/useDrawerUrlState";
import { DrillableCell } from "@/components/drill/DrillableCell";
import { useTailStream } from "@/hooks/useTailStream"; import { useTailStream } from "@/hooks/useTailStream";
import { useMergedTail } from "@/hooks/useMergedTail"; import { useMergedTail } from "@/hooks/useMergedTail";
import { TailStatusPill } from "@/components/TailStatusPill"; import { TailStatusPill } from "@/components/TailStatusPill";
@@ -78,6 +79,7 @@ export function Claims() {
// using a separate `?order=` param. // using a separate `?order=` param.
// ------------------------------------------------------------------------- // -------------------------------------------------------------------------
const [searchParams, setSearchParams] = useSearchParams(); const [searchParams, setSearchParams] = useSearchParams();
const navigate = useNavigate();
const rawStatus = searchParams.get("status"); const rawStatus = searchParams.get("status");
const status: ClaimStatus | typeof ALL = const status: ClaimStatus | typeof ALL =
@@ -366,10 +368,27 @@ export function Claims() {
</TableCell> </TableCell>
<TableCell className="font-medium text-[13px]">{c.patientName}</TableCell> <TableCell className="font-medium text-[13px]">{c.patientName}</TableCell>
<TableCell> <TableCell>
<div className="text-[13px]">{provider?.name ?? "Unknown"}</div> <DrillableCell
<div className="mono text-[10.5px] text-muted-foreground"> ariaLabel={`View provider ${provider?.name ?? c.providerNpi}`}
{c.providerNpi} onClick={() =>
</div> navigate(
`/providers?provider=${encodeURIComponent(c.providerNpi)}`,
)
}
>
{/*
DrillableCell renders an inline-flex button,
so the two stacked lines would otherwise land
side-by-side. The flex-col wrapper preserves
the original "name on top, NPI below" layout.
*/}
<div className="flex flex-col items-start">
<div className="text-[13px]">{provider?.name ?? "Unknown"}</div>
<div className="mono text-[10.5px] text-muted-foreground">
{c.providerNpi}
</div>
</div>
</DrillableCell>
</TableCell> </TableCell>
<TableCell className="text-muted-foreground text-[13px]"> <TableCell className="text-muted-foreground text-[13px]">
{c.payerName} {c.payerName}
+151
View File
@@ -0,0 +1,151 @@
// @vitest-environment happy-dom
// SP21 Task 2.5: Dashboard "Recent activity" card routes clicks by event
// kind. This test verifies the wiring end-to-end: a `claim_paid` event
// in the activity slice becomes a clickable row that navigates to
// `/claims?claim=<id>`, while a `remit_received` event surfaces a
// "coming in a later phase" toast (since the RemitDrawer lands in
// Phase 4).
//
// `Dashboard` reads `claims`, `providers`, `activity` from the
// `useAppStore` slice, so we override the slice directly via
// `useAppStore.setState` instead of mocking `useActivity` — the
// sample-data mode is exactly what the dashboard sees when no API is
// configured, so the test stays faithful to production behavior.
(globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }).IS_REACT_ACT_ENVIRONMENT = true;
import { afterEach, describe, expect, it, vi } from "vitest";
import { cleanup, fireEvent, render } from "@testing-library/react";
import { MemoryRouter } from "react-router-dom";
import { Dashboard } from "./Dashboard";
import { useAppStore } from "@/store";
import type { Activity } from "@/types";
// sonner renders toasts through a portal; jsdom has no layout so the
// `position` style is a no-op. We just verify that `toast.info` is
// called with the expected message — sonner itself has its own tests.
vi.mock("sonner", () => ({
toast: {
info: vi.fn(),
success: vi.fn(),
error: vi.fn(),
},
}));
// Capture navigation side effects so we can assert on the URL the
// Dashboard would push. We use a `MemoryRouter` (initialEntries=["/"])
// and observe the rendered route via a tiny listener component that
// reads the current `<MemoryRouter>` entry — no real `window.history`
// or `BrowserRouter` required.
import { useLocation } from "react-router-dom";
function LocationProbe() {
const loc = useLocation();
return (
<div
data-testid="location"
data-pathname={loc.pathname}
data-search={loc.search}
/>
);
}
afterEach(() => {
cleanup();
vi.clearAllMocks();
// Reset the activity slice so tests don't bleed into each other.
useAppStore.setState({ activity: [] });
});
describe("Dashboard · Recent activity event routing (SP21 Task 2.5)", () => {
it("navigates to /claims?claim=ID when a claim_paid event is clicked", () => {
const activity: Activity[] = [
{
id: "ae-1",
kind: "claim_paid",
message: "Paid CLM-42 · Jordan Smith",
timestamp: "2026-06-20T12:00:00Z",
claimId: "CLM-42",
remittanceId: null,
},
];
useAppStore.setState({ activity });
const { getByTestId, getByRole } = render(
<MemoryRouter initialEntries={["/"]}>
<Dashboard />
<LocationProbe />
</MemoryRouter>,
);
// The row becomes a button-like <li> with role="button" and a
// descriptive aria-label derived from the kind.
const row = getByRole("button", { name: /View claim paid/ });
fireEvent.click(row);
const probe = getByTestId("location");
expect(probe.getAttribute("data-pathname")).toBe("/claims");
expect(probe.getAttribute("data-search")).toBe("?claim=CLM-42");
});
it("navigates to /providers?provider=NPI when a provider_added event is clicked", () => {
const activity: Activity[] = [
{
id: "ae-2",
kind: "provider_added",
message: "Added Cedar Park Family Medicine",
timestamp: "2026-06-20T12:00:00Z",
npi: "1730187395",
claimId: null,
remittanceId: null,
},
];
useAppStore.setState({ activity });
const { getByTestId, getByRole } = render(
<MemoryRouter initialEntries={["/"]}>
<Dashboard />
<LocationProbe />
</MemoryRouter>,
);
fireEvent.click(getByRole("button", { name: /View provider added/ }));
const probe = getByTestId("location");
expect(probe.getAttribute("data-pathname")).toBe("/providers");
expect(probe.getAttribute("data-search")).toBe("?provider=1730187395");
});
it("fires the toast (no navigation) for remit_received — Phase 4 drawer", async () => {
const { toast } = await import("sonner");
const activity: Activity[] = [
{
id: "ae-3",
kind: "remit_received",
message: "Remit REM-7 received",
timestamp: "2026-06-20T12:00:00Z",
claimId: null,
remittanceId: "REM-7",
},
];
useAppStore.setState({ activity });
const { getByTestId, getByRole } = render(
<MemoryRouter initialEntries={["/"]}>
<Dashboard />
<LocationProbe />
</MemoryRouter>,
);
fireEvent.click(getByRole("button", { name: /View remit received/ }));
expect(toast.info).toHaveBeenCalledTimes(1);
const msg = (toast.info as ReturnType<typeof vi.fn>).mock.calls[0]?.[0] as string;
expect(msg).toMatch(/remit received/i);
expect(msg).toMatch(/coming in a later phase/i);
// URL must not have changed — the toast path is non-navigating.
const probe = getByTestId("location");
expect(probe.getAttribute("data-pathname")).toBe("/");
expect(probe.getAttribute("data-search")).toBe("");
});
});
+20 -1
View File
@@ -16,7 +16,9 @@ import { ActivityFeed } from "@/components/ActivityFeed";
import { AnimatedNumber } from "@/components/AnimatedNumber"; import { AnimatedNumber } from "@/components/AnimatedNumber";
import { DrillableCell } from "@/components/drill/DrillableCell"; import { DrillableCell } from "@/components/drill/DrillableCell";
import { fmt } from "@/lib/format"; import { fmt } from "@/lib/format";
import { eventKindToUrl } from "@/lib/event-routing";
import { useAppStore } from "@/store"; import { useAppStore } from "@/store";
import { toast } from "sonner";
const MONTHS_BACK = 6; const MONTHS_BACK = 6;
@@ -275,7 +277,24 @@ export function Dashboard() {
</span> </span>
</CardHeader> </CardHeader>
<CardContent className="pt-0"> <CardContent className="pt-0">
<ActivityFeed items={activity.slice(0, 10)} /> <ActivityFeed
items={activity.slice(0, 10)}
onItemClick={(evt) => {
// SP21 Task 2.5: route by event kind. claim_* kinds
// navigate to the matching claim drawer (URL-driven,
// drawer mounts in Phase 5); provider_added opens the
// ProviderDrawer. remit_received and any unmapped
// kind surface a "coming soon" toast so the click
// still gives feedback until the RemitDrawer lands in
// Phase 4.
const url = eventKindToUrl(evt);
if (url) navigate(url);
else
toast.info(
`Drill for ${evt.kind.replace(/_/g, " ")} coming in a later phase.`,
);
}}
/>
</CardContent> </CardContent>
</Card> </Card>
+13 -1
View File
@@ -3,12 +3,15 @@ import { Skeleton } from "@/components/ui/skeleton";
import { EmptyState } from "@/components/ui/empty-state"; import { EmptyState } from "@/components/ui/empty-state";
import { ErrorState } from "@/components/ui/error-state"; import { ErrorState } from "@/components/ui/error-state";
import { PageHeader } from "@/components/PageHeader"; import { PageHeader } from "@/components/PageHeader";
import { ProviderDrawer } from "@/components/ProviderDrawer";
import { useProviderDrawerUrlState } from "@/hooks/useProviderDrawerUrlState";
import { useProviders } from "@/hooks/useProviders"; import { useProviders } from "@/hooks/useProviders";
import { fmt } from "@/lib/format"; import { fmt } from "@/lib/format";
export function Providers() { export function Providers() {
const { data, isLoading, isError, error, refetch } = useProviders(); const { data, isLoading, isError, error, refetch } = useProviders();
const items = data?.items ?? []; const items = data?.items ?? [];
const { providerNpi, open, close } = useProviderDrawerUrlState();
return ( return (
<div className="space-y-6 lg:space-y-8 animate-fade-in"> <div className="space-y-6 lg:space-y-8 animate-fade-in">
@@ -44,7 +47,14 @@ export function Providers() {
{items.map((p) => ( {items.map((p) => (
<article <article
key={p.npi} key={p.npi}
className="group surface-2 rounded-xl p-5 flex flex-col gap-4 transition-colors hover:bg-muted/20 cursor-default" onClick={() => open(p.npi)}
onKeyDown={(e) => {
if (e.key === "Enter") open(p.npi);
}}
role="button"
tabIndex={0}
aria-label={`View provider ${p.name}`}
className="group drillable surface-2 rounded-xl p-5 flex flex-col gap-4 transition-colors hover:bg-muted/20 cursor-pointer"
> >
<div className="flex items-start gap-3"> <div className="flex items-start gap-3">
<div className="h-10 w-10 rounded-md bg-muted/60 ring-1 ring-inset ring-border/40 flex items-center justify-center text-foreground"> <div className="h-10 w-10 rounded-md bg-muted/60 ring-1 ring-inset ring-border/40 flex items-center justify-center text-foreground">
@@ -91,6 +101,8 @@ export function Providers() {
))} ))}
</div> </div>
)} )}
<ProviderDrawer npi={providerNpi} onClose={close} />
</div> </div>
); );
} }
+4
View File
@@ -49,6 +49,10 @@ export const useAppStore = create<AppState>((set) => ({
timestamp: claim.submissionDate, timestamp: claim.submissionDate,
npi: claim.providerNpi, npi: claim.providerNpi,
amount: claim.billedAmount, amount: claim.billedAmount,
// SP21 Task 2.5: mirror the backend wire shape so the
// Dashboard routing helper finds the claim id.
claimId: claim.id,
remittanceId: null,
}, },
...s.activity, ...s.activity,
], ],
+17
View File
@@ -155,6 +155,23 @@ export interface Activity {
timestamp: string; timestamp: string;
npi?: string; npi?: string;
amount?: number; amount?: number;
/**
* SP21 Task 2.5: read from the backend `ActivityEvent.claim_id` so
* the Dashboard "Recent activity" card can route a click on a
* `claim_*` event to the matching claim drawer (via
* `src/lib/event-routing.ts`). Populated only for events that
* correspond to a specific claim; `null` for orphan events such as
* `remit_received` or `provider_added`.
*/
claimId?: string | null;
/**
* SP21 Task 2.5: read from the backend `ActivityEvent.remittance_id`.
* Populated only for events that reference a specific remittance
* (e.g. `remit_received`); `null` otherwise. The Dashboard toast
* covers the Phase 2 case where this routes to a not-yet-built
* `RemitDrawer` (Phase 4).
*/
remittanceId?: string | null;
} }
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------