3 Commits

Author SHA1 Message Date
cyclone ad6629c7ab fix(sp41): thread canonical envelope into Pipeline-A 837P
The previous _serialize_pipeline_a emitted a placeholder envelope:
billing_provider=BillingProvider(name='REBILL PROVIDER', npi='0000000000')
with no tax_id, no address, no Subscriber address, no real payer name,
and no submitter contact block. Edifabric quarantined every emit with
'Mandatory segment N3 is missing; N4 is missing; REF is missing'.

This fix pulls the canonical envelope constants from
cyclone.rebill.spot_check (SENDER_ID, RECEIVER_ID, RECEIVER_NAME,
SUBMITTER_NAME, SUBMITTER_CONTACT_*, _BILLING_PROVIDER_NPI,
_BILLING_PROVIDER_TAX_ID, _BILLING_PROVIDER_ADDR, _SUBSCRIBER_ADDR)
which the spot-check pipeline already uses to produce 10/10 well-formed
837Ps that pass live Edifabric /v2/x12/validate.

Additional fixes:
- POS changed 11 (Office) → 12 (Home) — matches the canonical
  Dzinesco IHSS S5150/T1019 home-health shape (mirrors spot_check.py).
- Subscriber gets dob, gender, address so NM1*IL → N3/N4 emit.
- Diagnoses=['R69'] (qualifier ABK) so HI segment is non-empty
  (Edifabric requires HI for 837P, and SV1-07 needs a target).
- Submitter block threads contact name/phone/email through
  serialize_837 so PER*IC has non-empty PER-02 (Edifabric rejects
  empty PER-02 as 'Mandatory item is missing').

Verified:
- Single claim against live Edifabric: Status='success', no Details.
- Full backend suite: 1593 passed, 10 skipped, 0 failed.
- Spot-check driver suite (mock Edifabric): 2/2 passed.
- test_run_rebill_emits_real_files_for_pipeline_a updated for POS=12.
2026-07-08 08:48:50 -06:00
Nora b0ad0c27b8 fix(sp41): trailing newline + unused imports + defensive filename handling + a/b test coverage 2026-07-07 23:32:40 -06:00
Cyclone Dev b0d03bc10e feat(sp41): Edifabric gate on every emitted 837P (quarantine on failure)
Replace the run_rebill() .touch() placeholders for Pipeline A and Pipeline B with real serialize → validate → write paths.

Pipeline A: build a ClaimOutput adapter from the canonical RebillClaim fields (claim_id/member_id/procedure/svc_date/charge) — the per-claim envelope context (provider NPI, subscriber name, payer name) comes from the original claim being replaced and isn't carried forward by the rebill pipeline, so the adapter emits safe placeholders and lets the SP40 serializer fallbacks fill PER / SBR09. Then serialize_837 → cyclone.edifabric.validate_edi → write to pipeline-a/ on success or quarantine/ on Status=='error'.

Pipeline B: serialize_member_week_batch(b, tpid=tpid) (the Task 14 overload — takes a MemberWeekBatch, not a ClaimOutput) → cyclone.edifabric.validate_edi → write to pipeline-b/ or quarantine/.

Filename disambiguation: build_outbound_filename embeds a millisecond timestamp; multiple files emitted in the same millisecond would collide. Append per-claim / per-batch suffix so the audit trail (claim_id ↔ file / batch_key ↔ file) stays one-to-one.

Edifabric unavailability (no API key, network error, 5xx) fails OPEN with a WARNING log: the file lands in the pipeline dir, matches the SP40 dev/CI posture for boxes without a paid key. Quarantine only on Edifabric Status=='error'.

New tests in backend/tests/test_rebill_run.py cover: real 837P file emission (non-empty, ISA..IEA envelope) for both pipelines, quarantine on Edifabric error, fail-open on Edifabric unavailability, HCPF-spec filename prefix preserved, per-claim / per-batch disambiguation suffix present, original claim_id preserved in Pipeline A CLM01.
2026-07-07 23:25:15 -06:00