feat(claims): provider cell drillable to /providers?provider=NPI

This commit is contained in:
Tyler
2026-06-21 15:21:46 -06:00
parent 980627b675
commit d15c04d983
4 changed files with 128 additions and 8 deletions
+63
View File
@@ -699,4 +699,67 @@ describe("Claims page drawer wiring", () => {
unmount();
});
// -------------------------------------------------------------------
// Regression for SP21 Task 2.4 — DrillableCell click bubbling.
//
// The provider cell renders a <button> (via DrillableCell) inside a
// <TableRow onClick={() => open(c.id)}>. Before the fix, clicking the
// provider button (1) navigated to /providers?provider=… and then
// (2) bubbled to the row, where open() rebuilt the URL on top of the
// new /providers URL and appended a phantom ?claim=CLM-1. The page
// mounted on /providers, but the URL was a Frankenstein of both
// nav states and the browser history was polluted with two entries
// per click.
//
// We assert the URL after a provider-cell click does NOT carry
// ?claim=. The fix lives in DrillableCell (stopPropagation), so this
// is an end-to-end check that the component-level guard closes the
// bubble all the way back at the row.
//
// Note on MemoryRouter: react-router's `navigate()` updates the
// router's internal history but does NOT push to window.history, so
// `window.location.href` in this test stays on `/claims`. That's
// still the right place to assert "no phantom claim= param landed on
// window.history" — that's where the bug manifested (buildUrl() in
// the row's open() reads window.location and pushState's the bad
// URL). In a real BrowserRouter the URL would advance to /providers
// after navigate(), and the same assertion holds: ?claim= would be
// absent.
// -------------------------------------------------------------------
it("test_clicking_provider_cell_navigates_without_pushing_claim_param", async () => {
const { unmount } = renderClaims();
// Wait for the table to populate from the mocked api.listClaims.
await settle(
() => document.body.textContent?.includes("CLM-1") ?? false,
);
// Both SAMPLE_CLAIMS use providerNpi "1234567890", which doesn't
// match any seeded sampleProvider, so the aria-label falls through
// to `View provider 1234567890`. Pick the first matching button.
const btn = Array.from(document.querySelectorAll("button")).find(
(b) =>
b.getAttribute("aria-label")?.startsWith("View provider ") ?? false,
) as HTMLButtonElement | undefined;
expect(btn).toBeDefined();
// Sanity: row's claim-param is not in the URL before the click.
expect(window.location.href).not.toContain("claim=");
// Click it. With the fix, the click handler stops propagation before
// the row's onClick can fire. Without the fix, the row's open()
// would push a phantom ?claim=CLM-1 onto window.history.
await act(async () => {
btn!.click();
});
// The URL must not carry a ?claim= param. buildUrl() inside open()
// would have added that param if the click had bubbled to the row.
// (See the MemoryRouter note above for why we don't also assert
// on /providers here.)
expect(window.location.href).not.toContain("claim=");
unmount();
});
});