feat(db): migration 0014 relaxes claims/remittances PK to (batch_id, id)
Migration 0014 changes the PRIMARY KEYs of claims and remittances from single-column id to composite (batch_id, id). Enables the spec'd cross-batch CLM01 / CLP01 collision workflow: same CLM01 in multiple batches is now representable (resubmits), pre-flight dedup 409 path is genuinely exercisable, force-insert can skip pre-existing duplicates. Strategy: PRAGMA defer_foreign_keys = ON + table recreation for every table whose FKs pointed at the old single-column PK. Tables recreated: remittances, claims, matches, cas_adjustments, service_line_payments, line_reconciliations. Each child table gains a batch_id (or remittance_batch_id) column for the composite FK side; INSERT INTO new SELECT FROM old JOINs populate it from the already-recreated parent. Cross-table FKs (remittances.claim_id, claims.matched_remittance_id) cannot be SQL-enforced with composite PKs (SQLite has no ALTER CONSTRAINT). Dropped at SQL level; enforced via application-layer invariants in store.manual_match / manual_unmatch / reconcile.run and the dedup.preflight_* helpers. ORM updates (db.py): - Claim / Remittance: composite PK via explicit PrimaryKeyConstraint in __table_args__ (column order matches SQL: batch_id, id). - New Claim.matched_remittance_batch_id column. - Match / CasAdjustment / ServiceLinePayment / LineReconciliation: added the batch side of their composite FK to the parent table. - SQLAlchemy before_insert events auto-populate the batch side of the composite FK from session.new, then identity_map, then SQL fallback. Production code updates: - store.manual_match / manual_unmatch: also write matched_remittance_batch_id on the claim (was missing). - api.py manual-match endpoint: same fix. - reconcile.run: same fix for auto-matched pairs. Test updates: replaced s.get(Claim, X) with the composite key (batch_id, id) where batch_id is known, or s.query().filter().first() where the test only knows the id. Tests that previously inserted a Match row pointing at a non-existent Remittance now seed the parent Remittance so the new NOT NULL composite FK is satisfied.
This commit is contained in:
@@ -116,17 +116,20 @@ def _seed_pair_with_two_lines():
|
||||
reconcile_run(s, bid_835)
|
||||
s.commit()
|
||||
|
||||
return claim_id
|
||||
return claim_id, bid_837
|
||||
|
||||
|
||||
def test_done_today_lane_includes_matched_remittance_line_counts(client):
|
||||
claim_id = _seed_pair_with_two_lines()
|
||||
claim_id, bid_837 = _seed_pair_with_two_lines()
|
||||
# Backfill state_changed_at so the claim lands in the done_today lane
|
||||
# (reconcile.run() doesn't write it; the API surface is exercised by
|
||||
# the existing manual-match flow which sets it).
|
||||
from sqlalchemy.orm import Session
|
||||
with db.SessionLocal()() as s:
|
||||
cl = s.get(db.Claim, claim_id)
|
||||
# Migration 0014: composite PK (batch_id, id). Use filter-by-id
|
||||
# since we don't have a single canonical batch_id (the test seeds
|
||||
# both 837 and 835 batches under fresh UUIDs).
|
||||
cl = s.query(db.Claim).filter(db.Claim.id == claim_id).first()
|
||||
cl.state_changed_at = datetime.now(timezone.utc)
|
||||
s.commit()
|
||||
|
||||
|
||||
Reference in New Issue
Block a user