tyler/cyclone
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(api): trailing newlines + hoist acks.py parser imports to top-level

Browse Source 
Self-review nits from the router-split commit:
- All four new files lacked a trailing newline (PEP 8 / POSIX).
- acks.py was lazily importing ParseResult999 / serialize_999 inside
  get_ack_endpoint. Hoist to module-level — there's no import cycle
  (acks.py does not import from cyclone.api), so the imports are safe
  to do once.

No behavior change. Targeted tests (test_acks + test_health + test_api_gets)
still pass 41/41.
This commit is contained in:
Tyler
2026-06-21 00:50:31 -06:00
parent a63ba5e88c
commit 1267a341e3
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/cyclone/api_routers/acks.py
+2 -2
View File
@@ -17,6 +17,8 @@ from fastapi import APIRouter, HTTPException, Query, Request
from fastapi.responses import StreamingResponse from fastapi.responses import StreamingResponse
from cyclone.api_helpers import ndjson_stream_list, wants_ndjson from cyclone.api_helpers import ndjson_stream_list, wants_ndjson
from cyclone.parsers.models_999 import ParseResult999
from cyclone.parsers.serialize_999 import serialize_999
from cyclone.store import store from cyclone.store import store
router = APIRouter() router = APIRouter()
@@ -91,8 +93,6 @@ def get_ack_endpoint(ack_id: int) -> dict:
# the regenerated text to keep payloads small; detail does.) # the regenerated text to keep payloads small; detail does.)
if row.raw_json: if row.raw_json:
try: try:
from cyclone.parsers.models_999 import ParseResult999
from cyclone.parsers.serialize_999 import serialize_999
regenerated = ParseResult999.model_validate(row.raw_json) regenerated = ParseResult999.model_validate(row.raw_json)
icn = regenerated.envelope.control_number or "000000001" icn = regenerated.envelope.control_number or "000000001"
body["raw_999_text"] = serialize_999(regenerated, interchange_control_number=icn) body["raw_999_text"] = serialize_999(regenerated, interchange_control_number=icn)